From f7ca61e5c35e561b0f4882c5a4fc78b73c391555 Mon Sep 17 00:00:00 2001 From: Jan Nowakowski Date: Mon, 5 May 2025 12:45:53 +0200 Subject: [PATCH] Fix selection mode on new report page --- src/components/MoneyReportHeader.tsx | 16 ++++++++++++++ .../MoneyRequestReportView.tsx | 22 +------------------ 2 files changed, 17 insertions(+), 21 deletions(-) diff --git a/src/components/MoneyReportHeader.tsx b/src/components/MoneyReportHeader.tsx index f0522404186a2..102b750d31537 100644 --- a/src/components/MoneyReportHeader.tsx +++ b/src/components/MoneyReportHeader.tsx @@ -5,6 +5,7 @@ import type {OnyxEntry} from 'react-native-onyx'; import {useOnyx} from 'react-native-onyx'; import type {ValueOf} from 'type-fest'; import useLocalize from '@hooks/useLocalize'; +import useMobileSelectionMode from '@hooks/useMobileSelectionMode'; import useNetwork from '@hooks/useNetwork'; import usePaymentAnimations from '@hooks/usePaymentAnimations'; import useReportIsArchived from '@hooks/useReportIsArchived'; @@ -12,6 +13,7 @@ import useResponsiveLayout from '@hooks/useResponsiveLayout'; import useSelectedTransactionsActions from '@hooks/useSelectedTransactionsActions'; import useTheme from '@hooks/useTheme'; import useThemeStyles from '@hooks/useThemeStyles'; +import {turnOffMobileSelectionMode} from '@libs/actions/MobileSelectionMode'; import {exportReportToCSV, exportToIntegration, markAsManuallyExported} from '@libs/actions/Report'; import {convertToDisplayString} from '@libs/CurrencyUtils'; import Navigation from '@libs/Navigation/Navigation'; @@ -659,6 +661,20 @@ function MoneyReportHeader({policy, report: moneyRequestReport, transactionThrea [connectedIntegrationName, styles.noWrap, styles.textStrong, translate], ); + const {selectionMode} = useMobileSelectionMode(); + + if (selectionMode?.isEnabled) { + return ( + { + setSelectedTransactionsID([]); + turnOffMobileSelectionMode(); + }} + /> + ); + } + return ( removeFailedReport(reportID)); }, [activeWorkspaceID, reportID]); - const {selectionMode} = useMobileSelectionMode(); - - const {setSelectedTransactionsID} = useMoneyRequestReportContext(); - // Special case handling a report that is a transaction thread // If true we will use standard `ReportActionsView` to display report data and a special header, anything else is handled via `MoneyRequestReportActionsList` const isTransactionThreadView = isReportTransactionThread(report); @@ -210,17 +200,7 @@ function MoneyRequestReportView({report, policy, reportMetadata, shouldDisplayRe errorRowStyles={[styles.ph5, styles.mv2]} > - {selectionMode?.isEnabled ? ( - { - setSelectedTransactionsID([]); - turnOffMobileSelectionMode(); - }} - /> - ) : ( - reportHeaderView - )} + {reportHeaderView} {shouldDisplayMoneyRequestActionsList ? (