diff --git a/src/pages/workspace/WorkspaceMembersPage.tsx b/src/pages/workspace/WorkspaceMembersPage.tsx index ca91f20587604..d97b3a037934e 100644 --- a/src/pages/workspace/WorkspaceMembersPage.tsx +++ b/src/pages/workspace/WorkspaceMembersPage.tsx @@ -408,7 +408,7 @@ function WorkspaceMembersPage({personalDetails, route, policy, currentUserPerson const policyOwner = policy?.owner; const currentUserLogin = currentUserPersonalDetails.login; - const invitedPrimaryToSecondaryLogins = invertObject(policy?.primaryLoginsInvited ?? {}); + const invitedPrimaryToSecondaryLogins = useMemo(() => invertObject(policy?.primaryLoginsInvited ?? {}), [policy?.primaryLoginsInvited]); const data: MemberOption[] = useMemo(() => { const result: MemberOption[] = []; diff --git a/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx b/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx index ce6a7e4e6024a..d5ffb3c866fa3 100644 --- a/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx +++ b/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx @@ -329,24 +329,6 @@ function WorkspaceCategoriesPage({route}: WorkspaceCategoriesPageProps) { }, [setSelectedCategories, selectionMode?.isEnabled]); const hasVisibleCategories = categoryList.some((category) => category.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || isOffline); - const getHeaderText = () => ( - - {!hasSyncError && isConnectionVerified ? ( - - {`${translate('workspace.categories.importedFromAccountingSoftware')} `} - - {`${currentConnectionName} ${translate('workspace.accounting.settings')}`} - - . - - ) : ( - {translate('workspace.categories.subtitle')} - )} - - ); const threeDotsMenuItems = useMemo(() => { const menuItems = []; @@ -439,7 +421,22 @@ function WorkspaceCategoriesPage({route}: WorkspaceCategoriesPageProps) { danger /> {shouldUseNarrowLayout && {getHeaderButtons()}} - {hasVisibleCategories && !isLoading && getHeaderText()} + + {!hasSyncError && isConnectionVerified ? ( + + {`${translate('workspace.categories.importedFromAccountingSoftware')} `} + + {`${currentConnectionName} ${translate('workspace.accounting.settings')}`} + + . + + ) : ( + {translate('workspace.categories.subtitle')} + )} + {categoryList.length > CONST.SEARCH_ITEM_LIMIT && ( ) : ( - <> + - + )} subRate.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || isOffline); - const getHeaderText = () => ( - - - {translate('workspace.perDiem.subtitle')} - openExternalLink(CONST.DEEP_DIVE_PER_DIEM)} - > - {translate('workspace.common.learnMore')} - - - - ); - const threeDotsMenuItems = useMemo(() => { const menuItems = [ { @@ -420,7 +406,17 @@ function WorkspacePerDiemPage({route}: WorkspacePerDiemPageProps) { danger /> {shouldUseNarrowLayout && {getHeaderButtons()}} - {(!hasVisibleSubRates || isLoading) && getHeaderText()} + + + {translate('workspace.perDiem.subtitle')} + openExternalLink(CONST.DEEP_DIVE_PER_DIEM)} + > + {translate('workspace.common.learnMore')} + + + {subRatesList.length > CONST.SEARCH_ITEM_LIMIT && ( {translate('workspace.reportFields.listInputSubtitle')} - {filteredListValues.length > CONST.SEARCH_ITEM_LIMIT && ( + {data.length > CONST.SEARCH_ITEM_LIMIT && ( ( - - {!hasSyncError && isConnectionVerified ? ( - - {`${translate('workspace.tags.importedFromAccountingSoftware')} `} - - {`${currentConnectionName} ${translate('workspace.accounting.settings')}`} - - . - - ) : ( - {translate('workspace.tags.subtitle')} - )} - - ); - const selectionModeHeader = selectionMode?.isEnabled && shouldUseNarrowLayout; return ( @@ -490,7 +471,22 @@ function WorkspaceTagsPage({route}: WorkspaceTagsPageProps) { cancelText={translate('common.cancel')} danger /> - {(!shouldUseNarrowLayout || !hasVisibleTags || isLoading) && getHeaderText()} + + {!hasSyncError && isConnectionVerified ? ( + + {`${translate('workspace.tags.importedFromAccountingSoftware')} `} + + {`${currentConnectionName} ${translate('workspace.accounting.settings')}`} + + . + + ) : ( + {translate('workspace.tags.subtitle')} + )} + {tagList.length > CONST.SEARCH_ITEM_LIMIT && ( !isMultiLevelTags && clearPolicyTagErrors(policyID, item.value, 0)} - listHeaderContent={shouldUseNarrowLayout ? getHeaderText() : null} showScrollIndicator={false} addBottomSafeAreaPadding />