From 489151b0864a3437f67d9ca0aed2fad013ded5c1 Mon Sep 17 00:00:00 2001 From: Getabalew Date: Fri, 27 Jun 2025 21:33:06 +0300 Subject: [PATCH 1/2] remove redundant code for real this time --- src/libs/SearchUIUtils.ts | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/libs/SearchUIUtils.ts b/src/libs/SearchUIUtils.ts index 986467ff84535..0a262e565277f 100644 --- a/src/libs/SearchUIUtils.ts +++ b/src/libs/SearchUIUtils.ts @@ -501,10 +501,7 @@ function getTransactionsSections(data: OnyxTypes.SearchResults['data'], metadata // Use Map.get() for faster lookups with default values const from = personalDetailsMap.get(transactionItem.accountID.toString()) ?? emptyPersonalDetails; const to = transactionItem.managerID && !shouldShowBlankTo ? (personalDetailsMap.get(transactionItem.managerID.toString()) ?? emptyPersonalDetails) : emptyPersonalDetails; - // const isPolicyExpenseChat = !!reports.find((rp) => rp.policyID === transactionItem.policyID && rp.isPolicyExpenseChat); - // console.log({reports}) - // console.log({isPolicyExpenseChat}); const {formattedFrom, formattedTo, formattedTotal, formattedMerchant, date} = getTransactionItemCommonFormattedProperties(transactionItem, from, to, policy); const transactionSection: TransactionListItemType = { @@ -525,7 +522,6 @@ function getTransactionsSections(data: OnyxTypes.SearchResults['data'], metadata isAmountColumnWide: shouldShowAmountInWideColumn, isTaxAmountColumnWide: shouldShowTaxAmountInWideColumn, violations: transactionViolations, - // isPolicyExpenseChat, // Manually copying all the properties from transactionItem transactionID: transactionItem.transactionID, @@ -909,7 +905,6 @@ function getReportSections(data: OnyxTypes.SearchResults['data'], metadata: Onyx const from = data.personalDetailsList?.[transactionItem.accountID]; const to = transactionItem.managerID && !shouldShowBlankTo ? (data.personalDetailsList?.[transactionItem.managerID] ?? emptyPersonalDetails) : emptyPersonalDetails; - // const isPolicyExpenseChat = !!reports.find((rp) => rp.policyID === transactionItem.policyID && rp.isPolicyExpenseChat); const {formattedFrom, formattedTo, formattedTotal, formattedMerchant, date} = getTransactionItemCommonFormattedProperties(transactionItem, from, to, policy); @@ -932,7 +927,6 @@ function getReportSections(data: OnyxTypes.SearchResults['data'], metadata: Onyx violations: transactionViolations, isAmountColumnWide: shouldShowAmountInWideColumn, isTaxAmountColumnWide: shouldShowTaxAmountInWideColumn, - // isPolicyExpenseChat, }; if (reportIDToTransactions[reportKey]?.transactions) { reportIDToTransactions[reportKey].transactions.push(transaction); From 5be399051a41e51560bfc1832737bd6347dd0807 Mon Sep 17 00:00:00 2001 From: Getabalew Date: Fri, 27 Jun 2025 21:50:18 +0300 Subject: [PATCH 2/2] remove redundant type --- src/components/SelectionList/types.ts | 3 --- src/types/onyx/SearchResults.ts | 3 --- 2 files changed, 6 deletions(-) diff --git a/src/components/SelectionList/types.ts b/src/components/SelectionList/types.ts index e51cfebf1731e..0e9c9f05dbeaf 100644 --- a/src/components/SelectionList/types.ts +++ b/src/components/SelectionList/types.ts @@ -270,9 +270,6 @@ type TransactionListItemType = ListItem & /** IOUs report */ iouReportID?: string | undefined; - /** Whether the report is policyExpenseChat */ - isPolicyExpenseChat?: boolean; - /** Precomputed violations */ violations?: TransactionViolation[]; }; diff --git a/src/types/onyx/SearchResults.ts b/src/types/onyx/SearchResults.ts index fd48068f6fe29..8fce5ca0fb90f 100644 --- a/src/types/onyx/SearchResults.ts +++ b/src/types/onyx/SearchResults.ts @@ -224,9 +224,6 @@ type SearchReportAction = { /** The name of the report */ reportName: string; - - /** Whether the report is policyExpenseChat */ - isPolicyExpenseChat?: boolean; }; /** Model of policy search result */