From db046cc9d31ea2d0829c425ad6b1b7069e527b72 Mon Sep 17 00:00:00 2001 From: Manan Jadhav Date: Thu, 16 Dec 2021 02:59:16 +0530 Subject: [PATCH 1/4] fix(room-visibility-translation): Added translation for visibility options --- src/languages/en.js | 4 ++++ src/languages/es.js | 4 ++++ src/pages/workspace/WorkspaceNewRoomPage.js | 11 +++++++---- 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/src/languages/en.js b/src/languages/en.js index ec2d7c206b2b6..b855e70a354f4 100755 --- a/src/languages/en.js +++ b/src/languages/en.js @@ -808,6 +808,10 @@ export default { social: 'social', selectAWorkspace: 'Select a workspace', growlMessageOnError: 'Unable to create policy room, please check your connection and try again.', + visibilityOptions: { + restricted: 'Restricted', + private: 'Private', + }, }, keyboardShortcutModal: { title: 'Keyboard Shortcuts', diff --git a/src/languages/es.js b/src/languages/es.js index 59561df795953..f97d7113d5ae9 100644 --- a/src/languages/es.js +++ b/src/languages/es.js @@ -810,6 +810,10 @@ export default { social: 'social', selectAWorkspace: 'Seleccionar un espacio de trabajo', growlMessageOnError: 'No ha sido posible crear el espacio de trabajo, por favor comprueba tu conexión e inténtalo de nuevo.', + visibilityOptions: { + restricted: 'Restringido', + private: 'Privado', + }, }, keyboardShortcutModal: { title: 'Atajos de teclado', diff --git a/src/pages/workspace/WorkspaceNewRoomPage.js b/src/pages/workspace/WorkspaceNewRoomPage.js index d4f2e715cc8c6..36c335e8e284a 100644 --- a/src/pages/workspace/WorkspaceNewRoomPage.js +++ b/src/pages/workspace/WorkspaceNewRoomPage.js @@ -129,6 +129,12 @@ class WorkspaceNewRoomPage extends React.Component { return null; } const shouldDisableSubmit = Boolean(!this.state.roomName || !this.state.policyID || this.state.error); + + const visibilityOptions = _.map(_.values(CONST.REPORT.VISIBILITY), v => ({ + label: this.props.translate(`newRoomPage.visibilityOptions.${v}`), + value: v, + })); + return ( this.setState({visibility})} /> From e51fb6986ef0b2068b46c32f8541c41a0fe64fa6 Mon Sep 17 00:00:00 2001 From: Manan Jadhav Date: Thu, 16 Dec 2021 03:08:51 +0530 Subject: [PATCH 2/4] fix(room-visibility-translation): Updated var name --- src/pages/workspace/WorkspaceNewRoomPage.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pages/workspace/WorkspaceNewRoomPage.js b/src/pages/workspace/WorkspaceNewRoomPage.js index 36c335e8e284a..6fbf540736f34 100644 --- a/src/pages/workspace/WorkspaceNewRoomPage.js +++ b/src/pages/workspace/WorkspaceNewRoomPage.js @@ -130,8 +130,8 @@ class WorkspaceNewRoomPage extends React.Component { } const shouldDisableSubmit = Boolean(!this.state.roomName || !this.state.policyID || this.state.error); - const visibilityOptions = _.map(_.values(CONST.REPORT.VISIBILITY), v => ({ - label: this.props.translate(`newRoomPage.visibilityOptions.${v}`), + const visibilityOptions = _.map(_.values(CONST.REPORT.VISIBILITY), visibilityOption => ({ + label: this.props.translate(`newRoomPage.visibilityOptions.${visibilityOption}`), value: v, })); From f92a35494e6cd1a810e64d0671888b1fea5f793d Mon Sep 17 00:00:00 2001 From: Manan Jadhav Date: Thu, 16 Dec 2021 03:09:57 +0530 Subject: [PATCH 3/4] fix(room-visibility-translation): Updated var name --- src/pages/workspace/WorkspaceNewRoomPage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/workspace/WorkspaceNewRoomPage.js b/src/pages/workspace/WorkspaceNewRoomPage.js index 6fbf540736f34..489a7581e692c 100644 --- a/src/pages/workspace/WorkspaceNewRoomPage.js +++ b/src/pages/workspace/WorkspaceNewRoomPage.js @@ -132,7 +132,7 @@ class WorkspaceNewRoomPage extends React.Component { const visibilityOptions = _.map(_.values(CONST.REPORT.VISIBILITY), visibilityOption => ({ label: this.props.translate(`newRoomPage.visibilityOptions.${visibilityOption}`), - value: v, + value: visibilityOption, })); return ( From ea8618b4a258ec4ef3cec32249c8a3c1decb0197 Mon Sep 17 00:00:00 2001 From: Manan Jadhav Date: Thu, 16 Dec 2021 08:12:00 +0530 Subject: [PATCH 4/4] fix(room-visibility-translation): Updated translations --- src/languages/es.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/languages/es.js b/src/languages/es.js index f97d7113d5ae9..bc1a0e733e014 100644 --- a/src/languages/es.js +++ b/src/languages/es.js @@ -811,8 +811,8 @@ export default { selectAWorkspace: 'Seleccionar un espacio de trabajo', growlMessageOnError: 'No ha sido posible crear el espacio de trabajo, por favor comprueba tu conexión e inténtalo de nuevo.', visibilityOptions: { - restricted: 'Restringido', - private: 'Privado', + restricted: 'Restringida', + private: 'Privada', }, }, keyboardShortcutModal: {