From 95db8c8508bdcfccb2ce11301eeb0549ce52bf2f Mon Sep 17 00:00:00 2001 From: DylanDylann Date: Mon, 20 Oct 2025 11:51:01 +0700 Subject: [PATCH 1/3] remove connect method --- src/libs/PersonalDetailsUtils.ts | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/libs/PersonalDetailsUtils.ts b/src/libs/PersonalDetailsUtils.ts index 52360cc79d605..cbb92c1ffdd6a 100644 --- a/src/libs/PersonalDetailsUtils.ts +++ b/src/libs/PersonalDetailsUtils.ts @@ -35,21 +35,8 @@ Onyx.connect({ }, }); -let hiddenTranslation = ''; -let youTranslation = ''; - -Onyx.connect({ - key: ONYXKEYS.ARE_TRANSLATIONS_LOADING, - initWithStoredValues: false, - callback: (value) => { - if (value ?? true) { - return; - } - hiddenTranslation = translateLocal('common.hidden'); - youTranslation = translateLocal('common.you').toLowerCase(); - }, -}); - +const hiddenTranslation = translateLocal('common.hidden'); +const youTranslation = translateLocal('common.you').toLowerCase(); const regexMergedAccount = new RegExp(CONST.REGEX.MERGED_ACCOUNT_PREFIX); function getDisplayNameOrDefault( From e5efbbe96c74de428e058c5da43402304ec77576 Mon Sep 17 00:00:00 2001 From: DylanDylann Date: Tue, 21 Oct 2025 10:51:44 +0700 Subject: [PATCH 2/3] chore: update translation --- src/libs/PersonalDetailsUtils.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/libs/PersonalDetailsUtils.ts b/src/libs/PersonalDetailsUtils.ts index cbb92c1ffdd6a..e68fc6cfdf528 100644 --- a/src/libs/PersonalDetailsUtils.ts +++ b/src/libs/PersonalDetailsUtils.ts @@ -35,8 +35,6 @@ Onyx.connect({ }, }); -const hiddenTranslation = translateLocal('common.hidden'); -const youTranslation = translateLocal('common.you').toLowerCase(); const regexMergedAccount = new RegExp(CONST.REGEX.MERGED_ACCOUNT_PREFIX); function getDisplayNameOrDefault( @@ -44,7 +42,7 @@ function getDisplayNameOrDefault( defaultValue = '', shouldFallbackToHidden = true, shouldAddCurrentUserPostfix = false, - youAfterTranslation = youTranslation, + youAfterTranslation = translateLocal('common.you').toLowerCase(), ): string { let displayName = passedPersonalDetails?.displayName ?? ''; @@ -85,7 +83,7 @@ function getDisplayNameOrDefault( return login; } - return shouldFallbackToHidden ? hiddenTranslation : ''; + return shouldFallbackToHidden ? translateLocal('common.hidden') : ''; } /** From ef89a2d444b6ad3dd35ff68c21c7b5d33af0a267 Mon Sep 17 00:00:00 2001 From: DylanDylann Date: Tue, 21 Oct 2025 11:04:36 +0700 Subject: [PATCH 3/3] fixx eslint --- src/libs/PersonalDetailsUtils.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libs/PersonalDetailsUtils.ts b/src/libs/PersonalDetailsUtils.ts index e68fc6cfdf528..71890f6ba36b8 100644 --- a/src/libs/PersonalDetailsUtils.ts +++ b/src/libs/PersonalDetailsUtils.ts @@ -42,6 +42,7 @@ function getDisplayNameOrDefault( defaultValue = '', shouldFallbackToHidden = true, shouldAddCurrentUserPostfix = false, + // eslint-disable-next-line @typescript-eslint/no-deprecated youAfterTranslation = translateLocal('common.you').toLowerCase(), ): string { let displayName = passedPersonalDetails?.displayName ?? ''; @@ -82,7 +83,7 @@ function getDisplayNameOrDefault( if (login) { return login; } - + // eslint-disable-next-line @typescript-eslint/no-deprecated return shouldFallbackToHidden ? translateLocal('common.hidden') : ''; } @@ -112,6 +113,7 @@ function getPersonalDetailsByIDs({ if (shouldChangeUserDisplayName && currentUserAccountID === detail.accountID) { return { ...detail, + // eslint-disable-next-line @typescript-eslint/no-deprecated displayName: translateLocal('common.you'), }; }