From 8458a084d7dba425e90fa0ffe96f4552858bae46 Mon Sep 17 00:00:00 2001 From: Samran Ahmed Date: Sat, 15 Nov 2025 13:51:53 +0500 Subject: [PATCH 1/2] fix: BillingBanner subtitle to only show when available --- .../Subscription/CardSection/BillingBanner/BillingBanner.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/settings/Subscription/CardSection/BillingBanner/BillingBanner.tsx b/src/pages/settings/Subscription/CardSection/BillingBanner/BillingBanner.tsx index fa0525562a91f..f95e7f74608bd 100644 --- a/src/pages/settings/Subscription/CardSection/BillingBanner/BillingBanner.tsx +++ b/src/pages/settings/Subscription/CardSection/BillingBanner/BillingBanner.tsx @@ -107,7 +107,7 @@ function BillingBanner({ {typeof title === 'string' ? {title} : title} - {typeof subtitle === 'string' ? {subtitle} : subtitle} + {!!subtitle && (typeof subtitle === 'string' ? {subtitle} : subtitle)} {shouldUseNarrowLayout ? ( <> From 83de27bd4fb80c48055d11c4b7dc6c4abe74f1a9 Mon Sep 17 00:00:00 2001 From: Samran Ahmed Date: Sat, 15 Nov 2025 14:44:04 +0500 Subject: [PATCH 2/2] fix: lint expensifyIcons import --- .../Subscription/CardSection/BillingBanner/BillingBanner.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/pages/settings/Subscription/CardSection/BillingBanner/BillingBanner.tsx b/src/pages/settings/Subscription/CardSection/BillingBanner/BillingBanner.tsx index f95e7f74608bd..46ff788693c19 100644 --- a/src/pages/settings/Subscription/CardSection/BillingBanner/BillingBanner.tsx +++ b/src/pages/settings/Subscription/CardSection/BillingBanner/BillingBanner.tsx @@ -3,9 +3,9 @@ import type {StyleProp, TextStyle, ViewStyle} from 'react-native'; import {View} from 'react-native'; import type {ValueOf} from 'type-fest'; import Icon from '@components/Icon'; -import * as Expensicons from '@components/Icon/Expensicons'; import {PressableWithoutFeedback} from '@components/Pressable'; import Text from '@components/Text'; +import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset'; import useResponsiveLayout from '@hooks/useResponsiveLayout'; import useTheme from '@hooks/useTheme'; import useThemeStyles from '@hooks/useThemeStyles'; @@ -64,6 +64,7 @@ function BillingBanner({ const styles = useThemeStyles(); const theme = useTheme(); const {shouldUseNarrowLayout} = useResponsiveLayout(); + const expensifyIcons = useMemoizedLazyExpensifyIcons(['DotIndicator'] as const); const rightIconComponent = useMemo(() => { if (rightIcon) { @@ -90,7 +91,7 @@ function BillingBanner({ return ( !!brickRoadIndicator && ( )