From 6adf170d621b37d0ed6c7daf9fc611f0b6e7e49e Mon Sep 17 00:00:00 2001 From: Qichen Zhu <57348009+QichenZhu@users.noreply.github.com> Date: Wed, 10 Dec 2025 15:06:04 +1300 Subject: [PATCH 1/2] Fix lint warnings --- src/pages/ReportAddApproverPage.tsx | 2 +- src/pages/ReportChangeApproverPage.tsx | 2 +- src/pages/Search/SearchPage.tsx | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/pages/ReportAddApproverPage.tsx b/src/pages/ReportAddApproverPage.tsx index 36d00792b1e15..198b27e5a5f4f 100644 --- a/src/pages/ReportAddApproverPage.tsx +++ b/src/pages/ReportAddApproverPage.tsx @@ -101,7 +101,7 @@ function ReportAddApproverPage({report, isLoadingReportData, policy}: ReportAddA reportNextStep, ); Navigation.dismissModal(); - }, [allApprovers, selectedApproverEmail, report, currentUserDetails.accountID, currentUserDetails.email, policy, hasViolations, isASAPSubmitBetaEnabled]); + }, [allApprovers, selectedApproverEmail, report, currentUserDetails.accountID, currentUserDetails.email, policy, hasViolations, isASAPSubmitBetaEnabled, reportNextStep]); const button = useMemo(() => { return ( diff --git a/src/pages/ReportChangeApproverPage.tsx b/src/pages/ReportChangeApproverPage.tsx index 8170d55b41ef7..755d2db5dc520 100644 --- a/src/pages/ReportChangeApproverPage.tsx +++ b/src/pages/ReportChangeApproverPage.tsx @@ -74,7 +74,7 @@ function ReportChangeApproverPage({report, policy, isLoadingReportData}: ReportC } assignReportToMe(report, currentUserDetails.accountID, currentUserDetails.email ?? '', policy, hasViolations, isASAPSubmitBetaEnabled, reportNextStep); Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(reportID)); - }, [selectedApproverType, report, currentUserDetails.accountID, currentUserDetails.email, policy, hasViolations, isASAPSubmitBetaEnabled, reportID]); + }, [selectedApproverType, report, currentUserDetails.accountID, currentUserDetails.email, policy, hasViolations, isASAPSubmitBetaEnabled, reportNextStep, reportID]); const approverTypes = useMemo(() => { const data: Array> = [ diff --git a/src/pages/Search/SearchPage.tsx b/src/pages/Search/SearchPage.tsx index d89b2fdac31ca..edfeaa40ee98a 100644 --- a/src/pages/Search/SearchPage.tsx +++ b/src/pages/Search/SearchPage.tsx @@ -709,7 +709,6 @@ function SearchPage({route}: SearchPageProps) { dismissedHoldUseExplanation, dismissedRejectUseExplanation, areAllTransactionsFromSubmitter, - currentUserPersonalDetails?.login, ]); const handleDeleteExpenses = () => { From 22c0ce8c8c4e0ce7ef18832495da4faf2b87606f Mon Sep 17 00:00:00 2001 From: Qichen Zhu <57348009+QichenZhu@users.noreply.github.com> Date: Wed, 10 Dec 2025 15:21:53 +1300 Subject: [PATCH 2/2] Fix types --- tests/unit/Search/SearchContextTest.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/unit/Search/SearchContextTest.tsx b/tests/unit/Search/SearchContextTest.tsx index 2d973768314d4..5e2f605d5e656 100644 --- a/tests/unit/Search/SearchContextTest.tsx +++ b/tests/unit/Search/SearchContextTest.tsx @@ -26,6 +26,7 @@ const mockSelectedTransaction: SelectedTransactionInfo = { const mockTransaction: TransactionListItemType = { accountID: 1, amount: 0, + canDelete: true, category: '', groupAmount: 1284, groupCurrency: 'USD',