From 298da1e1374fda915ecb9d96e493556b6bbd374c Mon Sep 17 00:00:00 2001 From: Tsaqif Date: Tue, 13 Jan 2026 16:59:43 +0700 Subject: [PATCH] Fix workflow job failure in WorkspaceMembersTest Signed-off-by: Tsaqif --- jest/setup.ts | 8 ++++++-- src/pages/workspace/WorkspaceMembersPage.tsx | 5 +++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/jest/setup.ts b/jest/setup.ts index 56c5d1afe83c1..7ae6c9ba6d93e 100644 --- a/jest/setup.ts +++ b/jest/setup.ts @@ -179,7 +179,9 @@ jest.mock('../src/hooks/useLazyAsset.ts', () => ({ }; } return mockIllustrations; - }, [names]), + + // Use a value-based dependency to avoid returning a new object caused by reference changes on names + }, [names.join(',')]), ), useMemoizedLazyExpensifyIcons: jest.fn((names: readonly string[]) => mockUseMemo(() => { @@ -194,7 +196,9 @@ jest.mock('../src/hooks/useLazyAsset.ts', () => ({ }; } return mockIcons; - }, [names]), + + // Use a value-based dependency to avoid returning a new object caused by reference changes on names + }, [names.join(',')]), ), default: jest.fn((importFn) => mockUseMemo(() => { diff --git a/src/pages/workspace/WorkspaceMembersPage.tsx b/src/pages/workspace/WorkspaceMembersPage.tsx index 6455ca836335e..0e537b27cf639 100644 --- a/src/pages/workspace/WorkspaceMembersPage.tsx +++ b/src/pages/workspace/WorkspaceMembersPage.tsx @@ -9,7 +9,7 @@ import type {DropdownOption, WorkspaceMemberBulkActionType} from '@components/Bu import ConfirmModal from '@components/ConfirmModal'; import DecisionModal from '@components/DecisionModal'; // eslint-disable-next-line no-restricted-imports -import {FallbackAvatar, Plus} from '@components/Icon/Expensicons'; +import {Plus} from '@components/Icon/Expensicons'; import {LockedAccountContext} from '@components/LockedAccountModalProvider'; import MessagesRow from '@components/MessagesRow'; import SearchBar from '@components/SearchBar'; @@ -426,7 +426,7 @@ function WorkspaceMembersPage({personalDetails, route, policy}: WorkspaceMembers ), icons: [ { - source: details.avatar ?? FallbackAvatar, + source: details.avatar ?? icons.FallbackAvatar, name: formatPhoneNumber(details?.login ?? ''), type: CONST.ICON_TYPE_AVATAR, id: accountID, @@ -458,6 +458,7 @@ function WorkspaceMembersPage({personalDetails, route, policy}: WorkspaceMembers invitedPrimaryToSecondaryLogins, policyOwner, currentUserLogin, + icons.FallbackAvatar, ]); const filterMember = useCallback((memberOption: MemberOption, searchQuery: string) => {