From a105211d5e8d91c9db56657ba50386d40259140b Mon Sep 17 00:00:00 2001 From: Ryan Teguh Date: Fri, 30 Jan 2026 17:47:01 +0800 Subject: [PATCH 01/10] Fix: Hide Concierge help button on every Search RHP --- src/components/Search/FilterComponents/DateFilterBase.tsx | 1 + src/components/Search/SearchBooleanFilterBasePage.tsx | 1 + src/components/Search/SearchFiltersAmountBase.tsx | 2 ++ src/components/Search/SearchFiltersCurrencyBase.tsx | 1 + src/components/Search/SearchFiltersTextBase.tsx | 1 + src/pages/Search/SavedSearchRenamePage.tsx | 5 ++++- src/pages/Search/SearchAdvancedFiltersPage.tsx | 5 ++++- .../SearchAdvancedFiltersPage/SearchFiltersAssigneePage.tsx | 1 + .../SearchAdvancedFiltersPage/SearchFiltersAttendeePage.tsx | 1 + .../SearchAdvancedFiltersPage/SearchFiltersCardPage.tsx | 1 + .../SearchAdvancedFiltersPage/SearchFiltersCategoryPage.tsx | 1 + .../SearchFiltersExpenseTypePage.tsx | 1 + .../SearchAdvancedFiltersPage/SearchFiltersFromPage.tsx | 1 + .../SearchAdvancedFiltersPage/SearchFiltersGroupByPage.tsx | 1 + .../SearchAdvancedFiltersPage/SearchFiltersHasPage.tsx | 1 + .../Search/SearchAdvancedFiltersPage/SearchFiltersInPage.tsx | 1 + .../Search/SearchAdvancedFiltersPage/SearchFiltersIsPage.tsx | 1 + .../SearchFiltersReportFieldPage/ReportFieldList.tsx | 1 + .../SearchFiltersReportFieldPage/ReportFieldText.tsx | 1 + .../SearchFiltersReportFieldPage/index.tsx | 1 + .../SearchAdvancedFiltersPage/SearchFiltersStatusPage.tsx | 1 + .../SearchAdvancedFiltersPage/SearchFiltersTagPage.tsx | 1 + .../SearchAdvancedFiltersPage/SearchFiltersTaxRatePage.tsx | 1 + .../Search/SearchAdvancedFiltersPage/SearchFiltersToPage.tsx | 1 + .../SearchAdvancedFiltersPage/SearchFiltersTypePage.tsx | 1 + .../SearchFiltersWithdrawalTypePage.tsx | 1 + .../SearchAdvancedFiltersPage/SearchFiltersWorkspacePage.tsx | 1 + src/pages/Search/SearchColumnsPage.tsx | 5 ++++- 28 files changed, 38 insertions(+), 3 deletions(-) diff --git a/src/components/Search/FilterComponents/DateFilterBase.tsx b/src/components/Search/FilterComponents/DateFilterBase.tsx index 5f7545e0eb214..28a6099c3dbec 100644 --- a/src/components/Search/FilterComponents/DateFilterBase.tsx +++ b/src/components/Search/FilterComponents/DateFilterBase.tsx @@ -117,6 +117,7 @@ function DateFilterBase({title, dateKey, back, onSubmit}: DateFilterBaseProps) { { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute())} + shouldDisplayHelpButton={false} /> @@ -203,6 +204,7 @@ function SearchFiltersAmountBase({title, filterKey, testID}: {title: Translation { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> {multiselect && ( diff --git a/src/components/Search/SearchFiltersTextBase.tsx b/src/components/Search/SearchFiltersTextBase.tsx index 64419fb64cd35..2052486bde8c0 100644 --- a/src/components/Search/SearchFiltersTextBase.tsx +++ b/src/components/Search/SearchFiltersTextBase.tsx @@ -50,6 +50,7 @@ function SearchFiltersTextBase({filterKey, titleKey, testID, characterLimit = CO onBackButtonPress={() => { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> - + - + {shouldShowResetFilters && {translate('search.resetFilters')}} diff --git a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersAssigneePage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersAssigneePage.tsx index f1b53c4fbafaa..7ef207c3fe49c 100644 --- a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersAssigneePage.tsx +++ b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersAssigneePage.tsx @@ -30,6 +30,7 @@ function SearchFiltersAssigneePage() { onBackButtonPress={() => { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> diff --git a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCategoryPage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCategoryPage.tsx index bb612bf806223..75d85fc3b6f6e 100644 --- a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCategoryPage.tsx +++ b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCategoryPage.tsx @@ -96,6 +96,7 @@ function SearchFiltersCategoryPage() { onBackButtonPress={() => { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> {listItems.map((item) => ( diff --git a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersStatusPage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersStatusPage.tsx index f7a30fd93a170..63ac8a3dfaa67 100644 --- a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersStatusPage.tsx +++ b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersStatusPage.tsx @@ -89,6 +89,7 @@ function SearchFiltersStatusPage() { onBackButtonPress={() => { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} + shouldDisplayHelpButton={false} /> {shouldShowLoadingIndicator ? ( diff --git a/src/pages/Search/SearchColumnsPage.tsx b/src/pages/Search/SearchColumnsPage.tsx index 405aea75a7cb1..c151c868e90e5 100644 --- a/src/pages/Search/SearchColumnsPage.tsx +++ b/src/pages/Search/SearchColumnsPage.tsx @@ -215,7 +215,10 @@ function SearchColumnsPage() { offlineIndicatorStyle={styles.mtAuto} includeSafeAreaPaddingBottom > - + {!isDefaultState && {translate('search.resetColumns')}} From 2c8083fa27f3ee49db74492649a8a5f789da7552 Mon Sep 17 00:00:00 2001 From: Ryan Teguh Date: Mon, 9 Feb 2026 09:37:30 +0800 Subject: [PATCH 02/10] Revert first commit --- src/components/Search/FilterComponents/DateFilterBase.tsx | 1 - src/components/Search/SearchBooleanFilterBasePage.tsx | 1 - src/components/Search/SearchFiltersAmountBase.tsx | 2 -- src/components/Search/SearchFiltersCurrencyBase.tsx | 1 - src/components/Search/SearchFiltersTextBase.tsx | 1 - src/pages/Search/SavedSearchRenamePage.tsx | 5 +---- src/pages/Search/SearchAdvancedFiltersPage.tsx | 5 +---- .../SearchAdvancedFiltersPage/SearchFiltersAssigneePage.tsx | 1 - .../SearchAdvancedFiltersPage/SearchFiltersAttendeePage.tsx | 1 - .../SearchAdvancedFiltersPage/SearchFiltersCardPage.tsx | 1 - .../SearchAdvancedFiltersPage/SearchFiltersCategoryPage.tsx | 1 - .../SearchFiltersExpenseTypePage.tsx | 1 - .../SearchAdvancedFiltersPage/SearchFiltersFromPage.tsx | 1 - .../SearchAdvancedFiltersPage/SearchFiltersGroupByPage.tsx | 1 - .../SearchAdvancedFiltersPage/SearchFiltersHasPage.tsx | 1 - .../Search/SearchAdvancedFiltersPage/SearchFiltersInPage.tsx | 1 - .../Search/SearchAdvancedFiltersPage/SearchFiltersIsPage.tsx | 1 - .../SearchFiltersReportFieldPage/ReportFieldList.tsx | 1 - .../SearchFiltersReportFieldPage/ReportFieldText.tsx | 1 - .../SearchFiltersReportFieldPage/index.tsx | 1 - .../SearchAdvancedFiltersPage/SearchFiltersStatusPage.tsx | 1 - .../SearchAdvancedFiltersPage/SearchFiltersTagPage.tsx | 1 - .../SearchAdvancedFiltersPage/SearchFiltersTaxRatePage.tsx | 1 - .../Search/SearchAdvancedFiltersPage/SearchFiltersToPage.tsx | 1 - .../SearchAdvancedFiltersPage/SearchFiltersTypePage.tsx | 1 - .../SearchFiltersWithdrawalTypePage.tsx | 1 - .../SearchAdvancedFiltersPage/SearchFiltersWorkspacePage.tsx | 1 - src/pages/Search/SearchColumnsPage.tsx | 5 +---- 28 files changed, 3 insertions(+), 38 deletions(-) diff --git a/src/components/Search/FilterComponents/DateFilterBase.tsx b/src/components/Search/FilterComponents/DateFilterBase.tsx index 28a6099c3dbec..5f7545e0eb214 100644 --- a/src/components/Search/FilterComponents/DateFilterBase.tsx +++ b/src/components/Search/FilterComponents/DateFilterBase.tsx @@ -117,7 +117,6 @@ function DateFilterBase({title, dateKey, back, onSubmit}: DateFilterBaseProps) { { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute())} - shouldDisplayHelpButton={false} /> @@ -204,7 +203,6 @@ function SearchFiltersAmountBase({title, filterKey, testID}: {title: Translation { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> {multiselect && ( diff --git a/src/components/Search/SearchFiltersTextBase.tsx b/src/components/Search/SearchFiltersTextBase.tsx index 4821a04d68478..24655d4651ce6 100644 --- a/src/components/Search/SearchFiltersTextBase.tsx +++ b/src/components/Search/SearchFiltersTextBase.tsx @@ -53,7 +53,6 @@ function SearchFiltersTextBase({filterKey, titleKey, testID, characterLimit = CO onBackButtonPress={() => { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> - + - + {shouldShowResetFilters && {translate('search.resetFilters')}} diff --git a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersAssigneePage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersAssigneePage.tsx index 7ef207c3fe49c..f1b53c4fbafaa 100644 --- a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersAssigneePage.tsx +++ b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersAssigneePage.tsx @@ -30,7 +30,6 @@ function SearchFiltersAssigneePage() { onBackButtonPress={() => { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> diff --git a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCategoryPage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCategoryPage.tsx index 75d85fc3b6f6e..bb612bf806223 100644 --- a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCategoryPage.tsx +++ b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCategoryPage.tsx @@ -96,7 +96,6 @@ function SearchFiltersCategoryPage() { onBackButtonPress={() => { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> {listItems.map((item) => ( diff --git a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersStatusPage.tsx b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersStatusPage.tsx index 63ac8a3dfaa67..f7a30fd93a170 100644 --- a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersStatusPage.tsx +++ b/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersStatusPage.tsx @@ -89,7 +89,6 @@ function SearchFiltersStatusPage() { onBackButtonPress={() => { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> { Navigation.goBack(ROUTES.SEARCH_ADVANCED_FILTERS.getRoute()); }} - shouldDisplayHelpButton={false} /> {shouldShowLoadingIndicator ? ( diff --git a/src/pages/Search/SearchColumnsPage.tsx b/src/pages/Search/SearchColumnsPage.tsx index f1b4eafa745d0..ea46fb82c3014 100644 --- a/src/pages/Search/SearchColumnsPage.tsx +++ b/src/pages/Search/SearchColumnsPage.tsx @@ -218,10 +218,7 @@ function SearchColumnsPage() { offlineIndicatorStyle={styles.mtAuto} includeSafeAreaPaddingBottom > - + {!isDefaultState && {translate('search.resetColumns')}} From 0ccdd4cf7320242a8cbf7406ed130df31594b44c Mon Sep 17 00:00:00 2001 From: Ryan Teguh Date: Mon, 9 Feb 2026 09:47:43 +0800 Subject: [PATCH 03/10] Fix: Hide Concierge help button on RHP --- src/components/HeaderWithBackButton/index.tsx | 2 +- src/components/MoneyReportHeader.tsx | 1 + src/components/Navigation/TopBar.tsx | 2 +- src/pages/TeachersUnite/SaveTheWorldPage.tsx | 1 + src/pages/home/HomePage.tsx | 1 + src/pages/settings/AboutPage/AboutPage.tsx | 1 + src/pages/settings/Preferences/PreferencesPage.tsx | 1 + src/pages/settings/Profile/ProfilePage.tsx | 1 + src/pages/settings/Rules/ExpenseRulesPage.tsx | 1 + src/pages/settings/Security/SecuritySettingsPage.tsx | 1 + .../settings/Subscription/SubscriptionSettingsPage.tsx | 1 + src/pages/settings/Troubleshoot/TroubleshootPage.tsx | 1 + src/pages/settings/Wallet/WalletPage/index.tsx | 1 + src/pages/workspace/WorkspaceMoreFeaturesPage.tsx | 1 + src/pages/workspace/WorkspacePageWithSections.tsx | 1 + src/pages/workspace/WorkspacesListPage.tsx | 7 ++++++- src/pages/workspace/accounting/PolicyAccountingPage.tsx | 1 + src/pages/workspace/categories/WorkspaceCategoriesPage.tsx | 1 + .../workspace/distanceRates/PolicyDistanceRatesPage.tsx | 1 + .../expensifyCard/WorkspaceExpensifyCardListPage.tsx | 1 + src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx | 1 + .../receiptPartners/WorkspaceReceiptPartnersPage.tsx | 1 + src/pages/workspace/reports/WorkspaceReportsPage.tsx | 1 + src/pages/workspace/tags/WorkspaceTagsPage.tsx | 1 + src/pages/workspace/taxes/WorkspaceTaxesPage.tsx | 1 + src/pages/workspace/travel/PolicyTravelPage.tsx | 1 + 26 files changed, 31 insertions(+), 3 deletions(-) diff --git a/src/components/HeaderWithBackButton/index.tsx b/src/components/HeaderWithBackButton/index.tsx index 7466984c27dd1..203b55468223f 100755 --- a/src/components/HeaderWithBackButton/index.tsx +++ b/src/components/HeaderWithBackButton/index.tsx @@ -68,7 +68,7 @@ function HeaderWithBackButton({ shouldOverlayDots = false, shouldOverlay = false, shouldNavigateToTopMostReport = false, - shouldDisplayHelpButton = true, + shouldDisplayHelpButton = false, shouldDisplaySearchRouter = false, progressBarPercentage, style, diff --git a/src/components/MoneyReportHeader.tsx b/src/components/MoneyReportHeader.tsx index cf41cc300790e..f3a30128ebb76 100644 --- a/src/components/MoneyReportHeader.tsx +++ b/src/components/MoneyReportHeader.tsx @@ -1759,6 +1759,7 @@ function MoneyReportHeader({ report={moneyRequestReport} shouldShowBackButton={shouldShowBackButton} shouldDisplaySearchRouter={shouldDisplaySearchRouter} + shouldDisplayHelpButton onBackButtonPress={onBackButtonPress} shouldShowBorderBottom={false} shouldEnableDetailPageNavigation diff --git a/src/components/Navigation/TopBar.tsx b/src/components/Navigation/TopBar.tsx index 80db06732353f..4eda3a904bf6c 100644 --- a/src/components/Navigation/TopBar.tsx +++ b/src/components/Navigation/TopBar.tsx @@ -27,7 +27,7 @@ type TopBarProps = { const authTokenTypeSelector = (session: OnyxEntry) => session && {authTokenType: session.authTokenType}; -function TopBar({breadcrumbLabel, shouldDisplaySearch = true, shouldDisplayHelpButton = true, cancelSearch, shouldShowLoadingBar = false, children}: TopBarProps) { +function TopBar({breadcrumbLabel, shouldDisplaySearch = true, shouldDisplayHelpButton = false, cancelSearch, shouldShowLoadingBar = false, children}: TopBarProps) { const styles = useThemeStyles(); const {translate} = useLocalize(); const [session] = useOnyx(ONYXKEYS.SESSION, {selector: authTokenTypeSelector, canBeMissing: true}); diff --git a/src/pages/TeachersUnite/SaveTheWorldPage.tsx b/src/pages/TeachersUnite/SaveTheWorldPage.tsx index 38c5803b74bd4..848d5364b9977 100644 --- a/src/pages/TeachersUnite/SaveTheWorldPage.tsx +++ b/src/pages/TeachersUnite/SaveTheWorldPage.tsx @@ -58,6 +58,7 @@ function SaveTheWorldPage() { title={translate('sidebarScreen.saveTheWorld')} shouldShowBackButton={shouldUseNarrowLayout} shouldDisplaySearchRouter + shouldDisplayHelpButton onBackButtonPress={Navigation.popToSidebar} icon={illustrations.TeachersUnite} shouldUseHeadlineHeader diff --git a/src/pages/home/HomePage.tsx b/src/pages/home/HomePage.tsx index 34e3100326fd6..8c859fea7f46f 100644 --- a/src/pages/home/HomePage.tsx +++ b/src/pages/home/HomePage.tsx @@ -48,6 +48,7 @@ function HomePage() { diff --git a/src/pages/settings/Profile/ProfilePage.tsx b/src/pages/settings/Profile/ProfilePage.tsx index 1983955c30d68..b039e1006fba8 100755 --- a/src/pages/settings/Profile/ProfilePage.tsx +++ b/src/pages/settings/Profile/ProfilePage.tsx @@ -168,6 +168,7 @@ function ProfilePage() { }} shouldShowBackButton={shouldUseNarrowLayout} shouldDisplaySearchRouter + shouldDisplayHelpButton icon={Profile} shouldUseHeadlineHeader /> diff --git a/src/pages/settings/Rules/ExpenseRulesPage.tsx b/src/pages/settings/Rules/ExpenseRulesPage.tsx index ab2d85090957b..15ee3e5dc15b2 100644 --- a/src/pages/settings/Rules/ExpenseRulesPage.tsx +++ b/src/pages/settings/Rules/ExpenseRulesPage.tsx @@ -248,6 +248,7 @@ function ExpenseRulesPage() { }} shouldShowBackButton={shouldUseNarrowLayout} shouldUseHeadlineHeader={!selectionModeHeader} + shouldDisplayHelpButton title={selectionModeHeader ? translate('common.selectMultiple') : translate('expenseRulesPage.title')} > {!shouldUseNarrowLayout && headerButton} diff --git a/src/pages/settings/Security/SecuritySettingsPage.tsx b/src/pages/settings/Security/SecuritySettingsPage.tsx index cb5059d4c1c23..4687c82d0d140 100644 --- a/src/pages/settings/Security/SecuritySettingsPage.tsx +++ b/src/pages/settings/Security/SecuritySettingsPage.tsx @@ -371,6 +371,7 @@ function SecuritySettingsPage() { icon={illustrations.LockClosed} shouldUseHeadlineHeader shouldDisplaySearchRouter + shouldDisplayHelpButton /> diff --git a/src/pages/settings/Subscription/SubscriptionSettingsPage.tsx b/src/pages/settings/Subscription/SubscriptionSettingsPage.tsx index cfdf294e41da9..f275d65200f00 100644 --- a/src/pages/settings/Subscription/SubscriptionSettingsPage.tsx +++ b/src/pages/settings/Subscription/SubscriptionSettingsPage.tsx @@ -64,6 +64,7 @@ function SubscriptionSettingsPage({route}: SubscriptionSettingsPageProps) { }} shouldShowBackButton={shouldUseNarrowLayout} shouldDisplaySearchRouter + shouldDisplayHelpButton icon={illustrations.CreditCardsNew} shouldUseHeadlineHeader /> diff --git a/src/pages/settings/Troubleshoot/TroubleshootPage.tsx b/src/pages/settings/Troubleshoot/TroubleshootPage.tsx index 8d55ddd4ada47..38a5f3553d193 100644 --- a/src/pages/settings/Troubleshoot/TroubleshootPage.tsx +++ b/src/pages/settings/Troubleshoot/TroubleshootPage.tsx @@ -180,6 +180,7 @@ function TroubleshootPage() { title={translate('initialSettingsPage.aboutPage.troubleshoot')} shouldShowBackButton={shouldUseNarrowLayout} shouldDisplaySearchRouter + shouldDisplayHelpButton onBackButtonPress={Navigation.popToSidebar} icon={illustrations.Lightbulb} shouldUseHeadlineHeader diff --git a/src/pages/settings/Wallet/WalletPage/index.tsx b/src/pages/settings/Wallet/WalletPage/index.tsx index 1ecf1008e36e0..3c531dbc09fc1 100644 --- a/src/pages/settings/Wallet/WalletPage/index.tsx +++ b/src/pages/settings/Wallet/WalletPage/index.tsx @@ -327,6 +327,7 @@ function WalletPage() { shouldUseHeadlineHeader shouldShowBackButton={shouldUseNarrowLayout} shouldDisplaySearchRouter + shouldDisplayHelpButton onBackButtonPress={Navigation.popToSidebar} /> ); diff --git a/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx b/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx index fc2c308b5059b..66c5e94345fe0 100644 --- a/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx +++ b/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx @@ -630,6 +630,7 @@ function WorkspaceMoreFeaturesPage({policy, route}: WorkspaceMoreFeaturesPagePro shouldUseHeadlineHeader title={translate('workspace.common.moreFeatures')} shouldShowBackButton={shouldUseNarrowLayout} + shouldDisplayHelpButton onBackButtonPress={() => Navigation.goBack()} /> diff --git a/src/pages/workspace/WorkspacePageWithSections.tsx b/src/pages/workspace/WorkspacePageWithSections.tsx index 949550ce8f373..4b7ada2699acc 100644 --- a/src/pages/workspace/WorkspacePageWithSections.tsx +++ b/src/pages/workspace/WorkspacePageWithSections.tsx @@ -225,6 +225,7 @@ function WorkspacePageWithSections({ shouldShowThreeDotsButton={shouldShowThreeDotsButton} threeDotsMenuItems={threeDotsMenuItems} shouldUseHeadlineHeader={shouldUseHeadlineHeader} + shouldDisplayHelpButton > {headerContent} diff --git a/src/pages/workspace/WorkspacesListPage.tsx b/src/pages/workspace/WorkspacesListPage.tsx index d13060cacba11..0050a58d149ee 100755 --- a/src/pages/workspace/WorkspacesListPage.tsx +++ b/src/pages/workspace/WorkspacesListPage.tsx @@ -824,7 +824,12 @@ function WorkspacesListPage() { } > - {!shouldUseNarrowLayout && {headerButton}} + + {!shouldUseNarrowLayout && {headerButton}} + {shouldUseNarrowLayout && {headerButton}} {shouldShowLoadingIndicator ? ( diff --git a/src/pages/workspace/accounting/PolicyAccountingPage.tsx b/src/pages/workspace/accounting/PolicyAccountingPage.tsx index dbb0da02177be..22f3d0ca987bf 100644 --- a/src/pages/workspace/accounting/PolicyAccountingPage.tsx +++ b/src/pages/workspace/accounting/PolicyAccountingPage.tsx @@ -557,6 +557,7 @@ function PolicyAccountingPage({policy}: PolicyAccountingPageProps) { shouldShowBackButton={shouldUseNarrowLayout} icon={illustrations.Accounting} shouldUseHeadlineHeader + shouldDisplayHelpButton onBackButtonPress={Navigation.popToSidebar} /> { if (isMobileSelectionModeEnabled) { setSelectedCategories([]); diff --git a/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx b/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx index 24aac8ba48cd3..50186f06436c8 100644 --- a/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx +++ b/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx @@ -476,6 +476,7 @@ function PolicyDistanceRatesPage({ shouldUseHeadlineHeader={!selectionModeHeader} title={translate(!selectionModeHeader ? 'workspace.common.distanceRates' : 'common.selectMultiple')} shouldShowBackButton={shouldUseNarrowLayout} + shouldDisplayHelpButton onBackButtonPress={() => { if (isMobileSelectionModeEnabled) { setSelectedDistanceRates([]); diff --git a/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx b/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx index fa75015552f4a..4cf37d6fa04a8 100644 --- a/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx +++ b/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx @@ -228,6 +228,7 @@ function WorkspaceExpensifyCardListPage({route, cardsList, fundID}: WorkspaceExp shouldUseHeadlineHeader title={translate('workspace.common.expensifyCard')} shouldShowBackButton={shouldUseNarrowLayout} + shouldDisplayHelpButton onBackButtonPress={handleBackButtonPress} > {!shouldShowSelector && !shouldUseNarrowLayout && isBankAccountVerified && getHeaderButtons()} diff --git a/src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx b/src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx index e72e00a8393e9..f5f31adbb8988 100644 --- a/src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx +++ b/src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx @@ -423,6 +423,7 @@ function WorkspacePerDiemPage({route}: WorkspacePerDiemPageProps) { title={translate(selectionModeHeader ? 'common.selectMultiple' : 'common.perDiem')} icon={!selectionModeHeader ? illustrations.PerDiem : undefined} shouldUseHeadlineHeader={!selectionModeHeader} + shouldDisplayHelpButton onBackButtonPress={() => { if (isMobileSelectionModeEnabled) { setSelectedPerDiem([]); diff --git a/src/pages/workspace/receiptPartners/WorkspaceReceiptPartnersPage.tsx b/src/pages/workspace/receiptPartners/WorkspaceReceiptPartnersPage.tsx index 15a82f8d39982..3c58ff9cb81ea 100644 --- a/src/pages/workspace/receiptPartners/WorkspaceReceiptPartnersPage.tsx +++ b/src/pages/workspace/receiptPartners/WorkspaceReceiptPartnersPage.tsx @@ -271,6 +271,7 @@ function WorkspaceReceiptPartnersPage({route}: WorkspaceReceiptPartnersPageProps shouldShowBackButton={shouldUseNarrowLayout} icon={ReceiptPartners} shouldUseHeadlineHeader + shouldDisplayHelpButton onBackButtonPress={Navigation.popToSidebar} /> {isLoading && ( diff --git a/src/pages/workspace/tags/WorkspaceTagsPage.tsx b/src/pages/workspace/tags/WorkspaceTagsPage.tsx index 957340630af4c..2a3e752d48303 100644 --- a/src/pages/workspace/tags/WorkspaceTagsPage.tsx +++ b/src/pages/workspace/tags/WorkspaceTagsPage.tsx @@ -750,6 +750,7 @@ function WorkspaceTagsPage({route}: WorkspaceTagsPageProps) { shouldUseHeadlineHeader={!selectionModeHeader} title={translate(selectionModeHeader ? 'common.selectMultiple' : 'workspace.common.tags')} shouldShowBackButton={shouldUseNarrowLayout} + shouldDisplayHelpButton onBackButtonPress={() => { if (isMobileSelectionModeEnabled) { setSelectedTags([]); diff --git a/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx b/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx index 1c7f7907ec9c4..f9ddadc0a6a7a 100644 --- a/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx +++ b/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx @@ -400,6 +400,7 @@ function WorkspaceTaxesPage({ shouldUseHeadlineHeader={!selectionModeHeader} title={translate(selectionModeHeader ? 'common.selectMultiple' : 'workspace.common.taxes')} shouldShowBackButton={shouldUseNarrowLayout} + shouldDisplayHelpButton onBackButtonPress={() => { if (isMobileSelectionModeEnabled) { setSelectedTaxesIDs([]); diff --git a/src/pages/workspace/travel/PolicyTravelPage.tsx b/src/pages/workspace/travel/PolicyTravelPage.tsx index 50f9e8260b053..66147bfb32762 100644 --- a/src/pages/workspace/travel/PolicyTravelPage.tsx +++ b/src/pages/workspace/travel/PolicyTravelPage.tsx @@ -104,6 +104,7 @@ function WorkspaceTravelPage({ title={translate('workspace.moreFeatures.travel.title')} shouldUseHeadlineHeader shouldShowBackButton={shouldUseNarrowLayout} + shouldDisplayHelpButton onBackButtonPress={Navigation.popToSidebar} /> From 5bf080b84806c5450dc920da292f864a074ad33a Mon Sep 17 00:00:00 2001 From: Ryan Teguh Date: Mon, 9 Feb 2026 10:55:50 +0800 Subject: [PATCH 04/10] Hide help button on submit expense confirmation RHP --- src/pages/iou/request/step/IOURequestStepConfirmation.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/pages/iou/request/step/IOURequestStepConfirmation.tsx b/src/pages/iou/request/step/IOURequestStepConfirmation.tsx index dd9f72ad55637..37e50236d7425 100644 --- a/src/pages/iou/request/step/IOURequestStepConfirmation.tsx +++ b/src/pages/iou/request/step/IOURequestStepConfirmation.tsx @@ -1376,7 +1376,6 @@ function IOURequestStepConfirmation({ title={headerTitle} subtitle={hasMultipleTransactions ? `${currentTransactionIndex + 1} ${translate('common.of')} ${transactions.length}` : undefined} onBackButtonPress={navigateBack} - shouldDisplayHelpButton={!hasMultipleTransactions} > {hasMultipleTransactions ? ( Date: Mon, 9 Feb 2026 11:08:10 +0800 Subject: [PATCH 05/10] ESLint fix --- src/CONST/index.ts | 2 ++ src/components/HeaderWithBackButton/index.tsx | 1 + src/components/Navigation/TopBar.tsx | 2 ++ 3 files changed, 5 insertions(+) diff --git a/src/CONST/index.ts b/src/CONST/index.ts index 7f930af355a1d..ca197863c6601 100755 --- a/src/CONST/index.ts +++ b/src/CONST/index.ts @@ -8067,6 +8067,7 @@ const CONST = { DOWNLOAD_BUTTON: 'Header-DownloadButton', CLOSE_BUTTON: 'Header-CloseButton', MORE_BUTTON: 'Header-MoreButton', + ROTATE_BUTTON: 'Header-RotateButton', }, VIDEO_PLAYER: { PLAY_PAUSE_BUTTON: 'VideoPlayer-PlayPauseButton', @@ -8097,6 +8098,7 @@ const CONST = { USER_SELECTION_CHECKBOX: 'Search-UserSelectionCheckbox', TRANSACTION_GROUP_LIST_ITEM: 'Search-TransactionGroupListItem', SELECT_ALL_BUTTON: 'Search-SelectAllButton', + CANCEL_BUTTON: 'Search-CancelButton', }, REPORT: { FLOATING_MESSAGE_COUNTER: 'Report-FloatingMessageCounter', diff --git a/src/components/HeaderWithBackButton/index.tsx b/src/components/HeaderWithBackButton/index.tsx index 203b55468223f..e6885e504d616 100755 --- a/src/components/HeaderWithBackButton/index.tsx +++ b/src/components/HeaderWithBackButton/index.tsx @@ -290,6 +290,7 @@ function HeaderWithBackButton({ style={[styles.touchableButtonImage]} role="button" accessibilityLabel={translate('common.rotate')} + sentryLabel={CONST.SENTRY_LABEL.HEADER.ROTATE_BUTTON} > { cancelSearch(); }} + sentryLabel={CONST.SENTRY_LABEL.SEARCH.CANCEL_BUTTON} > {translate('common.cancel')} From 246d593df5f4a93bab48ea10d86239073c005951 Mon Sep 17 00:00:00 2001 From: Ryan Teguh Date: Fri, 20 Feb 2026 22:34:53 +0800 Subject: [PATCH 06/10] Prettier --- src/components/Navigation/TopBar.tsx | 1 - src/pages/home/HomePage.tsx | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/components/Navigation/TopBar.tsx b/src/components/Navigation/TopBar.tsx index e01a689ef7f16..9a8aee0c6a58a 100644 --- a/src/components/Navigation/TopBar.tsx +++ b/src/components/Navigation/TopBar.tsx @@ -68,7 +68,6 @@ function TopBar({breadcrumbLabel, shouldDisplaySearch = true, shouldDisplayHelpB onPress={() => { cancelSearch(); }} - sentryLabel={CONST.SENTRY_LABEL.SEARCH.CANCEL_BUTTON} > {translate('common.cancel')} diff --git a/src/pages/home/HomePage.tsx b/src/pages/home/HomePage.tsx index 62d64dedb489b..5b7f395e8bb13 100644 --- a/src/pages/home/HomePage.tsx +++ b/src/pages/home/HomePage.tsx @@ -59,7 +59,7 @@ function HomePage() { breadcrumbLabel={translate('common.home')} shouldShowLoadingBar={false} shouldDisplayHelpButton - /> + /> Date: Fri, 20 Feb 2026 23:06:10 +0800 Subject: [PATCH 07/10] Hide help button on SearchPageNarrow --- src/pages/Search/SearchPageNarrow.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pages/Search/SearchPageNarrow.tsx b/src/pages/Search/SearchPageNarrow.tsx index 94ecdfa219e83..90da8cbc08d25 100644 --- a/src/pages/Search/SearchPageNarrow.tsx +++ b/src/pages/Search/SearchPageNarrow.tsx @@ -197,6 +197,7 @@ function SearchPageNarrow({ shouldShowLoadingBar={shouldShowLoadingState} breadcrumbLabel={translate('common.reports')} shouldDisplaySearch={false} + shouldDisplayHelpButton cancelSearch={shouldDisplayCancelSearch ? cancelSearchCallback : undefined} /> From e82f4880c979213af1b4b8c88425c1bf92bc06ce Mon Sep 17 00:00:00 2001 From: Ryan Teguh Date: Sat, 21 Feb 2026 00:14:20 +0800 Subject: [PATCH 08/10] Hide help button on MoneyReportHeader --- src/components/MoneyReportHeader.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/MoneyReportHeader.tsx b/src/components/MoneyReportHeader.tsx index 2e194d68296af..019a049b5c25f 100644 --- a/src/components/MoneyReportHeader.tsx +++ b/src/components/MoneyReportHeader.tsx @@ -1795,7 +1795,7 @@ function MoneyReportHeader({ report={moneyRequestReport} shouldShowBackButton={shouldShowBackButton} shouldDisplaySearchRouter={shouldDisplaySearchRouter} - shouldDisplayHelpButton + shouldDisplayHelpButton={!(isReportInRHP && shouldUseNarrowLayout)} onBackButtonPress={onBackButtonPress} shouldShowBorderBottom={false} shouldEnableDetailPageNavigation From de045180210728668d877d8cdf139357a6a291f9 Mon Sep 17 00:00:00 2001 From: Ryan Teguh Date: Mon, 23 Feb 2026 22:54:57 +0800 Subject: [PATCH 09/10] Add TopBar to InitialSettingsPage --- src/pages/settings/InitialSettingsPage.tsx | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/pages/settings/InitialSettingsPage.tsx b/src/pages/settings/InitialSettingsPage.tsx index 4a9759d056305..6fb7d8ad3da2c 100755 --- a/src/pages/settings/InitialSettingsPage.tsx +++ b/src/pages/settings/InitialSettingsPage.tsx @@ -13,6 +13,7 @@ import MenuItem from '@components/MenuItem'; import {ModalActions} from '@components/Modal/Global/ModalContext'; import NavigationTabBar from '@components/Navigation/NavigationTabBar'; import NAVIGATION_TABS from '@components/Navigation/NavigationTabBar/NAVIGATION_TABS'; +import TopBar from '@components/Navigation/TopBar'; import {PressableWithFeedback} from '@components/Pressable'; import ScreenWrapper from '@components/ScreenWrapper'; import {ScrollOffsetContext} from '@components/ScrollOffsetContextProvider'; @@ -532,6 +533,13 @@ function InitialSettingsPage({currentUserPersonalDetails}: InitialSettingsPagePr shouldEnableKeyboardAvoidingView={false} > {shouldDisplayLHB && } + {shouldUseNarrowLayout && ( + + )} {headerContent} Date: Tue, 24 Feb 2026 20:42:07 +0800 Subject: [PATCH 10/10] Swap SearchButton and SidePanelButton position --- src/components/HeaderWithBackButton/index.tsx | 2 +- src/components/Navigation/TopBar.tsx | 2 +- src/pages/inbox/HeaderView.tsx | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/HeaderWithBackButton/index.tsx b/src/components/HeaderWithBackButton/index.tsx index 92627a3399dc7..7e1de49ba2065 100755 --- a/src/components/HeaderWithBackButton/index.tsx +++ b/src/components/HeaderWithBackButton/index.tsx @@ -344,8 +344,8 @@ function HeaderWithBackButton({ )} - {shouldDisplayHelpButton && } {shouldDisplaySearchRouter && } + {shouldDisplayHelpButton && } ); diff --git a/src/components/Navigation/TopBar.tsx b/src/components/Navigation/TopBar.tsx index 0e9e0c1805449..6783188e263f0 100644 --- a/src/components/Navigation/TopBar.tsx +++ b/src/components/Navigation/TopBar.tsx @@ -72,8 +72,8 @@ function TopBar({breadcrumbLabel, shouldDisplaySearch = true, shouldDisplayHelpB {translate('common.cancel')} )} - {shouldDisplayHelpButton && } {displaySearch && } + {shouldDisplayHelpButton && } diff --git a/src/pages/inbox/HeaderView.tsx b/src/pages/inbox/HeaderView.tsx index 95b651ea38c21..2c4b6bfbe3c6c 100644 --- a/src/pages/inbox/HeaderView.tsx +++ b/src/pages/inbox/HeaderView.tsx @@ -391,8 +391,8 @@ function HeaderView({report, parentReportAction, onNavigationMenuButtonClicked, {!shouldUseNarrowLayout && isOpenTaskReport(report, parentReportAction) && } {!isParentReportLoading && canJoin && !shouldUseNarrowLayout && joinButton} - {!isInSidePanel && } - {shouldDisplaySearchRouter && } + {shouldDisplaySearchRouter && } + {!isInSidePanel && } )}