From 004d903f77bf386f01236c6b300ba75637f9084b Mon Sep 17 00:00:00 2001 From: MelvinBot Date: Wed, 18 Feb 2026 14:54:26 +0000 Subject: [PATCH] Stop clearing commentHint when toggling Require description off The setPolicyCategoryDescriptionRequired function was resetting commentHint to an empty string whenever areCommentsRequired was set to false. This was originally acceptable when the Description Hint field was only visible while Require description was enabled. After the Description Hint was moved to always be visible when rules are enabled, this clearing became a visible bug. Remove the commentHint side effect so that toggling Require description only updates areCommentsRequired. Co-authored-by: Neil Marcellini --- src/libs/actions/Policy/Category.ts | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/libs/actions/Policy/Category.ts b/src/libs/actions/Policy/Category.ts index b85e1c29800f5..0c7b372fe4554 100644 --- a/src/libs/actions/Policy/Category.ts +++ b/src/libs/actions/Policy/Category.ts @@ -479,10 +479,6 @@ function setWorkspaceCategoryEnabled({ function setPolicyCategoryDescriptionRequired(policyID: string, categoryName: string, areCommentsRequired: boolean, policyCategories: PolicyCategories = {}) { const policyCategoryToUpdate = policyCategories?.[categoryName]; const originalAreCommentsRequired = policyCategoryToUpdate?.areCommentsRequired; - const originalCommentHint = policyCategoryToUpdate?.commentHint; - - // When areCommentsRequired is set to false, commentHint has to be reset - const updatedCommentHint = areCommentsRequired ? policyCategories?.[categoryName]?.commentHint : ''; const onyxData: OnyxData = { optimisticData: [ @@ -496,7 +492,6 @@ function setPolicyCategoryDescriptionRequired(policyID: string, categoryName: st areCommentsRequired: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE, }, areCommentsRequired, - commentHint: updatedCommentHint, }, }, }, @@ -512,7 +507,6 @@ function setPolicyCategoryDescriptionRequired(policyID: string, categoryName: st areCommentsRequired: null, }, areCommentsRequired, - commentHint: updatedCommentHint, }, }, }, @@ -529,7 +523,6 @@ function setPolicyCategoryDescriptionRequired(policyID: string, categoryName: st areCommentsRequired: null, }, areCommentsRequired: originalAreCommentsRequired, - commentHint: originalCommentHint, }, }, },