From 89164d1af580b0f4987e5a7c9efa2a5ac6a7e005 Mon Sep 17 00:00:00 2001 From: "Puneet Lath (via MelvinBot)" Date: Fri, 13 Mar 2026 20:57:06 +0000 Subject: [PATCH 1/2] Remove redirect to Search/Reports for migrated users The MigratedUserWelcomeModalGuard was passing ROUTES.SEARCH_ROOT.route as the backTo parameter when redirecting to the migration welcome modal. This caused users to be navigated to the Search/Reports page after dismissing the modal. By removing this argument, the modal still shows but the user stays on their current page (Home) after dismissal. Co-authored-by: Puneet Lath --- src/libs/Navigation/guards/MigratedUserWelcomeModalGuard.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/Navigation/guards/MigratedUserWelcomeModalGuard.ts b/src/libs/Navigation/guards/MigratedUserWelcomeModalGuard.ts index 85ade61a1a549..38fb868504ce0 100644 --- a/src/libs/Navigation/guards/MigratedUserWelcomeModalGuard.ts +++ b/src/libs/Navigation/guards/MigratedUserWelcomeModalGuard.ts @@ -89,7 +89,7 @@ const MigratedUserWelcomeModalGuard: NavigationGuard = { return { type: 'REDIRECT', - route: ROUTES.MIGRATED_USER_WELCOME_MODAL.getRoute(ROUTES.SEARCH_ROOT.route), + route: ROUTES.MIGRATED_USER_WELCOME_MODAL.getRoute(), }; } From f1e6ded728f6d840f5d848ae68635ec052b89355 Mon Sep 17 00:00:00 2001 From: "Puneet Lath (via MelvinBot)" Date: Fri, 13 Mar 2026 21:08:42 +0000 Subject: [PATCH 2/2] Fix: Update MigratedUserWelcomeModalGuard test to match removed backTo parameter Co-authored-by: Puneet Lath --- .../Navigation/guards/MigratedUserWelcomeModalGuard.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/Navigation/guards/MigratedUserWelcomeModalGuard.test.ts b/tests/unit/Navigation/guards/MigratedUserWelcomeModalGuard.test.ts index 25240cdfe3665..41e508195a354 100644 --- a/tests/unit/Navigation/guards/MigratedUserWelcomeModalGuard.test.ts +++ b/tests/unit/Navigation/guards/MigratedUserWelcomeModalGuard.test.ts @@ -63,7 +63,7 @@ describe('MigratedUserWelcomeModalGuard', () => { const result = MigratedUserWelcomeModalGuard.evaluate(mockState, mockAction, defaultContext); expect(result.type).toBe('REDIRECT'); if (result.type === 'REDIRECT') { - expect(result.route).toBe(ROUTES.MIGRATED_USER_WELCOME_MODAL.getRoute(ROUTES.SEARCH_ROOT.route)); + expect(result.route).toBe(ROUTES.MIGRATED_USER_WELCOME_MODAL.getRoute()); } });