From 68b6e2b3956681e1ea10db451d45a02759eaa17f Mon Sep 17 00:00:00 2001 From: "Rodrigo Lino da Costa (via MelvinBot)" Date: Thu, 19 Mar 2026 14:27:42 +0000 Subject: [PATCH] Fix flaky canEditFieldOfMoneyRequest test by pinning approvalMode The test was flaky because createRandomPolicy() randomly assigns approvalMode. When it picked DYNAMICEXTERNAL (~20% chance), canEditMoneyRequest() returned false for the SUBMITTED expense report, causing two test assertions to fail. Pin approvalMode to OPTIONAL to eliminate the randomness. Co-authored-by: Rodrigo Lino da Costa --- tests/unit/canEditFieldOfMoneyRequestTest.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/canEditFieldOfMoneyRequestTest.ts b/tests/unit/canEditFieldOfMoneyRequestTest.ts index 589a869505616..12abeb30bdd25 100644 --- a/tests/unit/canEditFieldOfMoneyRequestTest.ts +++ b/tests/unit/canEditFieldOfMoneyRequestTest.ts @@ -136,7 +136,7 @@ describe('canEditFieldOfMoneyRequest', () => { const randomReportAction = createRandomReportAction(reportActionID); const policyID = '11'; - const expensePolicy = {...createRandomPolicy(Number(policyID), CONST.POLICY.TYPE.TEAM), role: CONST.POLICY.ROLE.USER}; + const expensePolicy = {...createRandomPolicy(Number(policyID), CONST.POLICY.TYPE.TEAM), role: CONST.POLICY.ROLE.USER, approvalMode: CONST.POLICY.APPROVAL_MODE.OPTIONAL}; // Create outstanding expense reports in the same policy (different IDs than our main expense report) const outstandingExpenseReport1 = {