From dfc38e3413d840206dc33d8ae91863f97aff5134 Mon Sep 17 00:00:00 2001 From: Rory Abraham Date: Wed, 6 Jul 2022 16:54:37 -0700 Subject: [PATCH 1/2] Make it possible to locally prevent event propagation --- src/libs/KeyboardShortcut/index.js | 5 +++-- src/pages/signin/ChangeExpensifyLoginLink.js | 4 ++++ src/pages/signin/PasswordForm.js | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/libs/KeyboardShortcut/index.js b/src/libs/KeyboardShortcut/index.js index f948d69914610..0f2863ddda31d 100644 --- a/src/libs/KeyboardShortcut/index.js +++ b/src/libs/KeyboardShortcut/index.js @@ -103,8 +103,9 @@ function bindHandlerToKeydownEvent(event) { } // Make sure we don't add multiple listeners -document.removeEventListener('keydown', bindHandlerToKeydownEvent, {capture: true}); -document.addEventListener('keydown', bindHandlerToKeydownEvent, {capture: true}); +const rootNode = document.getElementById('root'); +rootNode.removeEventListener('keydown', bindHandlerToKeydownEvent); +rootNode.addEventListener('keydown', bindHandlerToKeydownEvent); /** * Unsubscribes a keyboard event handler. diff --git a/src/pages/signin/ChangeExpensifyLoginLink.js b/src/pages/signin/ChangeExpensifyLoginLink.js index 8d48d708bc9e2..fdf7dc437c2d3 100755 --- a/src/pages/signin/ChangeExpensifyLoginLink.js +++ b/src/pages/signin/ChangeExpensifyLoginLink.js @@ -40,6 +40,10 @@ const ChangeExpensifyLoginLink = props => ( { + e.stopPropagation(); + Session.clearSignInData(); + }} underlayColor={themeColors.componentBG} > diff --git a/src/pages/signin/PasswordForm.js b/src/pages/signin/PasswordForm.js index 0801487c88038..571f2353bf6be 100755 --- a/src/pages/signin/PasswordForm.js +++ b/src/pages/signin/PasswordForm.js @@ -181,6 +181,7 @@ class PasswordForm extends React.Component {