From f13c30db98ba0175b07eeed85b4c13e064e5f8fd Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Tue, 11 Nov 2025 18:04:13 +0100 Subject: [PATCH 01/16] remove java 17 from test matrix for maven verify --- .github/workflows/test-maven-verify.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/test-maven-verify.yml b/.github/workflows/test-maven-verify.yml index 183e205..ed52c81 100644 --- a/.github/workflows/test-maven-verify.yml +++ b/.github/workflows/test-maven-verify.yml @@ -15,7 +15,6 @@ jobs: strategy: matrix: java: - - 17 - 21 db: - type: mongodb From b96a8165a17460058f38b777127af13ebb396fe2 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Tue, 11 Nov 2025 18:04:59 +0100 Subject: [PATCH 02/16] add windows and macos runners to test matrix for maven-verify --- .github/workflows/test-maven-verify.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test-maven-verify.yml b/.github/workflows/test-maven-verify.yml index ed52c81..09c3e70 100644 --- a/.github/workflows/test-maven-verify.yml +++ b/.github/workflows/test-maven-verify.yml @@ -14,6 +14,10 @@ jobs: test: strategy: matrix: + runner: + - ubuntu-24.04 + - windows-2022 + - macos-14 java: - 21 db: @@ -31,7 +35,7 @@ jobs: version: 0 # not used for postgres uses: ./.github/workflows/maven-verify.yml with: - runner: ubuntu-24.04 + runner: ${{ matrix.runner }} java-version: ${{ matrix.java }} db-type: ${{ matrix.db.type }} db-name: ${{ matrix.db.name }} From 0931cea7bb2efa827644ee5a2637c0e0f022ff8b Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Tue, 11 Nov 2025 18:21:18 +0100 Subject: [PATCH 03/16] override mongo version for windows --- .github/workflows/test-maven-verify.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/test-maven-verify.yml b/.github/workflows/test-maven-verify.yml index 09c3e70..2fe1dd9 100644 --- a/.github/workflows/test-maven-verify.yml +++ b/.github/workflows/test-maven-verify.yml @@ -33,6 +33,9 @@ jobs: password: 'test' port: 5432 version: 0 # not used for postgres + include: + - runner: windows-2022 + db.version: 6 uses: ./.github/workflows/maven-verify.yml with: runner: ${{ matrix.runner }} From 0d1a3d17ec08e713b17863735e77134ada770375 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Tue, 11 Nov 2025 18:22:23 +0100 Subject: [PATCH 04/16] comments [skip-ci] --- .github/workflows/test-maven-verify.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test-maven-verify.yml b/.github/workflows/test-maven-verify.yml index 2fe1dd9..9948ef0 100644 --- a/.github/workflows/test-maven-verify.yml +++ b/.github/workflows/test-maven-verify.yml @@ -33,6 +33,8 @@ jobs: password: 'test' port: 5432 version: 0 # not used for postgres + # https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#example-expanding-configurations + # https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/run-job-variations include: - runner: windows-2022 db.version: 6 From b71659cf9f2c982173021ffcef74b5ddd7133b93 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Tue, 11 Nov 2025 18:24:51 +0100 Subject: [PATCH 05/16] try specifying db.type --- .github/workflows/test-maven-verify.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test-maven-verify.yml b/.github/workflows/test-maven-verify.yml index 9948ef0..cfa26f9 100644 --- a/.github/workflows/test-maven-verify.yml +++ b/.github/workflows/test-maven-verify.yml @@ -37,6 +37,7 @@ jobs: # https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/run-job-variations include: - runner: windows-2022 + db.type: mongodb db.version: 6 uses: ./.github/workflows/maven-verify.yml with: From cb01dcd122808df50b7820afb4d230d4cef67d38 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Tue, 11 Nov 2025 18:28:00 +0100 Subject: [PATCH 06/16] try whole db object --- .github/workflows/test-maven-verify.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/test-maven-verify.yml b/.github/workflows/test-maven-verify.yml index cfa26f9..9b4daad 100644 --- a/.github/workflows/test-maven-verify.yml +++ b/.github/workflows/test-maven-verify.yml @@ -37,8 +37,7 @@ jobs: # https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/run-job-variations include: - runner: windows-2022 - db.type: mongodb - db.version: 6 + db: { type: mongodb, version: 6 } uses: ./.github/workflows/maven-verify.yml with: runner: ${{ matrix.runner }} From 469dae16e4fc8fd98cc4c35095d059e3a8481488 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Tue, 11 Nov 2025 18:29:13 +0100 Subject: [PATCH 07/16] try really whole db object --- .github/workflows/test-maven-verify.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-maven-verify.yml b/.github/workflows/test-maven-verify.yml index 9b4daad..93be3c6 100644 --- a/.github/workflows/test-maven-verify.yml +++ b/.github/workflows/test-maven-verify.yml @@ -37,7 +37,7 @@ jobs: # https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/run-job-variations include: - runner: windows-2022 - db: { type: mongodb, version: 6 } + db: { type: mongodb, name: '', username: '', password: '', port: 0, version: 6 } uses: ./.github/workflows/maven-verify.yml with: runner: ${{ matrix.runner }} From 78e22a9128e70e24264b4845d80fb5a3922f9f30 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Tue, 11 Nov 2025 18:37:31 +0100 Subject: [PATCH 08/16] different approach using include --- .github/workflows/test-maven-verify.yml | 38 ++++++++++++------------- 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/.github/workflows/test-maven-verify.yml b/.github/workflows/test-maven-verify.yml index 93be3c6..cf2abd6 100644 --- a/.github/workflows/test-maven-verify.yml +++ b/.github/workflows/test-maven-verify.yml @@ -20,31 +20,29 @@ jobs: - macos-14 java: - 21 - db: - - type: mongodb - name: '' # not used for mongo - username: '' # not used for mongo - password: '' # not used for mongo - port: 0 # not used for mongo - version: 8 - - type: postgresql - name: 'test' - username: 'test' - password: 'test' - port: 5432 - version: 0 # not used for postgres + db_type: + - mongodb + - postgresql # https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#example-expanding-configurations # https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/run-job-variations include: + - db_type: mongodb + db_version: 8 - runner: windows-2022 - db: { type: mongodb, name: '', username: '', password: '', port: 0, version: 6 } + db_type: mongodb + db_version: 6 + - db_type: postgresql + db_name: 'test' + db_username: 'test' + db_password: 'test' + db_port: 5432 uses: ./.github/workflows/maven-verify.yml with: runner: ${{ matrix.runner }} java-version: ${{ matrix.java }} - db-type: ${{ matrix.db.type }} - db-name: ${{ matrix.db.name }} - db-username: ${{ matrix.db.username }} - db-password: ${{ matrix.db.password }} - db-port: ${{ matrix.db.port }} - db-version: ${{ matrix.db.version }} + db-type: ${{ matrix.db_type }} + db-name: ${{ matrix.db_name }} + db-username: ${{ matrix.db_username }} + db-password: ${{ matrix.db_password }} + db-port: ${{ matrix.db_port }} + db-version: ${{ matrix.db_version }} From b5daf12f25a456bda9212826bf648a7c27a762c5 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Tue, 11 Nov 2025 18:39:26 +0100 Subject: [PATCH 09/16] complete include --- .github/workflows/test-maven-verify.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/test-maven-verify.yml b/.github/workflows/test-maven-verify.yml index cf2abd6..131f966 100644 --- a/.github/workflows/test-maven-verify.yml +++ b/.github/workflows/test-maven-verify.yml @@ -27,15 +27,24 @@ jobs: # https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/run-job-variations include: - db_type: mongodb + db_name: '' + db_username: '' + db_password: '' + db_port: 0 db_version: 8 - runner: windows-2022 db_type: mongodb + db_name: '' + db_username: '' + db_password: '' + db_port: 0 db_version: 6 - db_type: postgresql db_name: 'test' db_username: 'test' db_password: 'test' db_port: 5432 + db_version: 0 uses: ./.github/workflows/maven-verify.yml with: runner: ${{ matrix.runner }} From 980d2b69af2b1174783c267462cf885fdd5406c4 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Wed, 12 Nov 2025 09:00:38 +0100 Subject: [PATCH 10/16] try include with defaults --- .github/workflows/test-maven-verify.yml | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/.github/workflows/test-maven-verify.yml b/.github/workflows/test-maven-verify.yml index 131f966..4d15b76 100644 --- a/.github/workflows/test-maven-verify.yml +++ b/.github/workflows/test-maven-verify.yml @@ -27,31 +27,22 @@ jobs: # https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/run-job-variations include: - db_type: mongodb - db_name: '' - db_username: '' - db_password: '' - db_port: 0 db_version: 8 - runner: windows-2022 db_type: mongodb - db_name: '' - db_username: '' - db_password: '' - db_port: 0 db_version: 6 - db_type: postgresql db_name: 'test' db_username: 'test' db_password: 'test' db_port: 5432 - db_version: 0 uses: ./.github/workflows/maven-verify.yml with: runner: ${{ matrix.runner }} java-version: ${{ matrix.java }} db-type: ${{ matrix.db_type }} - db-name: ${{ matrix.db_name }} - db-username: ${{ matrix.db_username }} - db-password: ${{ matrix.db_password }} - db-port: ${{ matrix.db_port }} - db-version: ${{ matrix.db_version }} + db-name: ${{ matrix.db_name || '' }} + db-username: ${{ matrix.db_username || '' }} + db-password: ${{ matrix.db_password || '' }} + db-port: ${{ matrix.db_port || 0 }} + db-version: ${{ matrix.db_version || 0 }} From 7792b4e8e70ffe5f65600381c18e90313e9d7c7e Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Wed, 12 Nov 2025 09:06:28 +0100 Subject: [PATCH 11/16] rename java to java_version for consistency --- .github/workflows/test-maven-verify.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-maven-verify.yml b/.github/workflows/test-maven-verify.yml index 4d15b76..c47a47b 100644 --- a/.github/workflows/test-maven-verify.yml +++ b/.github/workflows/test-maven-verify.yml @@ -18,13 +18,14 @@ jobs: - ubuntu-24.04 - windows-2022 - macos-14 - java: + java_version: - 21 db_type: - mongodb - postgresql # https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#example-expanding-configurations # https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/run-job-variations + # https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#operators include: - db_type: mongodb db_version: 8 @@ -39,7 +40,7 @@ jobs: uses: ./.github/workflows/maven-verify.yml with: runner: ${{ matrix.runner }} - java-version: ${{ matrix.java }} + java-version: ${{ matrix.java_version }} db-type: ${{ matrix.db_type }} db-name: ${{ matrix.db_name || '' }} db-username: ${{ matrix.db_username || '' }} From 244c96c0d0f1c591f97306c37f1c51665351cd93 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Wed, 12 Nov 2025 09:08:29 +0100 Subject: [PATCH 12/16] try setup-mongodb version default --- .github/workflows/test-maven-verify.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-maven-verify.yml b/.github/workflows/test-maven-verify.yml index c47a47b..2431574 100644 --- a/.github/workflows/test-maven-verify.yml +++ b/.github/workflows/test-maven-verify.yml @@ -31,7 +31,7 @@ jobs: db_version: 8 - runner: windows-2022 db_type: mongodb - db_version: 6 + db_version: '' # defaults to 5 (https://github.com/ankane/setup-mongodb) - db_type: postgresql db_name: 'test' db_username: 'test' @@ -46,4 +46,4 @@ jobs: db-username: ${{ matrix.db_username || '' }} db-password: ${{ matrix.db_password || '' }} db-port: ${{ matrix.db_port || 0 }} - db-version: ${{ matrix.db_version || 0 }} + db-version: ${{ matrix.db_version || '' }} From db064ceafb108e91f08f977af15770ab95de0af7 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Wed, 12 Nov 2025 09:10:56 +0100 Subject: [PATCH 13/16] restore explicit mongo version --- .github/workflows/test-maven-verify.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-maven-verify.yml b/.github/workflows/test-maven-verify.yml index 2431574..cef7705 100644 --- a/.github/workflows/test-maven-verify.yml +++ b/.github/workflows/test-maven-verify.yml @@ -31,7 +31,7 @@ jobs: db_version: 8 - runner: windows-2022 db_type: mongodb - db_version: '' # defaults to 5 (https://github.com/ankane/setup-mongodb) + db_version: 5 # depends on runner, see https://github.com/ankane/setup-mongodb - db_type: postgresql db_name: 'test' db_username: 'test' @@ -46,4 +46,4 @@ jobs: db-username: ${{ matrix.db_username || '' }} db-password: ${{ matrix.db_password || '' }} db-port: ${{ matrix.db_port || 0 }} - db-version: ${{ matrix.db_version || '' }} + db-version: ${{ matrix.db_version || 0 }} From 1e7a13d25764ab8267f06ef350b53914309cb531 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Wed, 12 Nov 2025 09:14:13 +0100 Subject: [PATCH 14/16] switch to windows-2025 runner because that is the latest, and windows-2022 only supports mongodb 5, which means we would need to handle both the old mongo and new mongosh commands --- .github/workflows/test-maven-verify.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test-maven-verify.yml b/.github/workflows/test-maven-verify.yml index cef7705..631d8d5 100644 --- a/.github/workflows/test-maven-verify.yml +++ b/.github/workflows/test-maven-verify.yml @@ -16,7 +16,7 @@ jobs: matrix: runner: - ubuntu-24.04 - - windows-2022 + - windows-2025 - macos-14 java_version: - 21 @@ -29,9 +29,9 @@ jobs: include: - db_type: mongodb db_version: 8 - - runner: windows-2022 + - runner: windows-2025 db_type: mongodb - db_version: 5 # depends on runner, see https://github.com/ankane/setup-mongodb + db_version: 7 # depends on runner, see https://github.com/ankane/setup-mongodb - db_type: postgresql db_name: 'test' db_username: 'test' From db7498ce38fc92d39d2f5f1b7ba3583327d1727a Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Wed, 12 Nov 2025 09:22:20 +0100 Subject: [PATCH 15/16] add link to list of runner images --- .github/workflows/test-maven-verify.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test-maven-verify.yml b/.github/workflows/test-maven-verify.yml index 631d8d5..a858ccc 100644 --- a/.github/workflows/test-maven-verify.yml +++ b/.github/workflows/test-maven-verify.yml @@ -15,6 +15,7 @@ jobs: strategy: matrix: runner: + # https://github.com/actions/runner-images - ubuntu-24.04 - windows-2025 - macos-14 From 5d511f29db74327b51565b9b18e0f870dc58c96f Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Wed, 12 Nov 2025 09:33:39 +0100 Subject: [PATCH 16/16] gitignore target dir --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index e69de29..2f7896d 100644 --- a/.gitignore +++ b/.gitignore @@ -0,0 +1 @@ +target/