From be605de3b6b8171d1cd0606adbe20cf791644697 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Fri, 14 Nov 2025 09:28:39 +0100 Subject: [PATCH 1/3] assign postgres-version parameter in maven-verify --- .github/workflows/maven-verify.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/maven-verify.yml b/.github/workflows/maven-verify.yml index fe3956b..88b783c 100644 --- a/.github/workflows/maven-verify.yml +++ b/.github/workflows/maven-verify.yml @@ -74,6 +74,7 @@ jobs: password: ${{ inputs.db-password }} database: ${{ inputs.db-name }} port: ${{ inputs.db-port }} + postgres-version: ${{ inputs.db-version }} - name: Test PostgreSQL connection if: inputs.db-type == 'postgresql' From a607674123bcb37836fc680b0b7cb03208e18a60 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Fri, 14 Nov 2025 09:29:13 +0100 Subject: [PATCH 2/3] test maven-verify with postgres 17 instead of the default 18 --- .github/workflows/test-maven-verify.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test-maven-verify.yml b/.github/workflows/test-maven-verify.yml index 3edd180..9d4d838 100644 --- a/.github/workflows/test-maven-verify.yml +++ b/.github/workflows/test-maven-verify.yml @@ -38,6 +38,7 @@ jobs: db_username: 'test' db_password: 'test' db_port: 54321 + db_version: 17 uses: ./.github/workflows/maven-verify.yml with: runner: ${{ matrix.runner }} From 7cf8b7ac9bede60391142a943d6f8f23670f1402 Mon Sep 17 00:00:00 2001 From: dennisvang <29799340+dennisvang@users.noreply.github.com> Date: Fri, 14 Nov 2025 09:44:08 +0100 Subject: [PATCH 3/3] replace underscore by hyphen in test variable names for consistency --- .github/workflows/test-maven-verify.yml | 38 ++++++++++++------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/.github/workflows/test-maven-verify.yml b/.github/workflows/test-maven-verify.yml index 9d4d838..02c0ab0 100644 --- a/.github/workflows/test-maven-verify.yml +++ b/.github/workflows/test-maven-verify.yml @@ -19,33 +19,33 @@ jobs: - ubuntu-24.04 - windows-2025 - macos-14 - java_version: + java-version: - 21 - db_type: + db-type: - mongodb - postgresql # https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#example-expanding-configurations # https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/run-job-variations # https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#operators include: - - db_type: mongodb - db_version: 8 + - db-type: mongodb + db-version: 8 - runner: windows-2025 - db_type: mongodb - db_version: 7 # depends on runner, see https://github.com/ankane/setup-mongodb - - db_type: postgresql - db_name: 'test' - db_username: 'test' - db_password: 'test' - db_port: 54321 - db_version: 17 + db-type: mongodb + db-version: 7 # depends on runner, see https://github.com/ankane/setup-mongodb + - db-type: postgresql + db-name: 'test' + db-username: 'test' + db-password: 'test' + db-port: 54321 + db-version: 17 uses: ./.github/workflows/maven-verify.yml with: runner: ${{ matrix.runner }} - java-version: ${{ matrix.java_version }} - db-type: ${{ matrix.db_type }} - db-name: ${{ matrix.db_name || '' }} - db-username: ${{ matrix.db_username || '' }} - db-password: ${{ matrix.db_password || '' }} - db-port: ${{ matrix.db_port || 0 }} - db-version: ${{ matrix.db_version || 0 }} + java-version: ${{ matrix.java-version }} + db-type: ${{ matrix.db-type }} + db-name: ${{ matrix.db-name || '' }} + db-username: ${{ matrix.db-username || '' }} + db-password: ${{ matrix.db-password || '' }} + db-port: ${{ matrix.db-port || 0 }} + db-version: ${{ matrix.db-version || 0 }}