From 5e1cf642b0e04704a8d55f3ba2c1aff1dc8d54b1 Mon Sep 17 00:00:00 2001 From: Dominik Riebeling Date: Sat, 7 Jun 2025 21:54:31 +0200 Subject: [PATCH 1/4] fix: Primary Number indicator not visible with light theme When the color scheme is set to use a white background color the star icon indicating the default number is drawn in white, making it invisible. The Edit activity explicitly sets the tint for the icon, do it for the View activity as well. Fixes #289 --- .../org/fossify/contacts/activities/ViewContactActivity.kt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/src/main/kotlin/org/fossify/contacts/activities/ViewContactActivity.kt b/app/src/main/kotlin/org/fossify/contacts/activities/ViewContactActivity.kt index a72bfe14f..64384a967 100644 --- a/app/src/main/kotlin/org/fossify/contacts/activities/ViewContactActivity.kt +++ b/app/src/main/kotlin/org/fossify/contacts/activities/ViewContactActivity.kt @@ -403,6 +403,10 @@ class ViewContactActivity : ContactActivity() { } defaultToggleIcon.isVisible = phoneNumber.isPrimary + defaultToggleIcon.drawable?.apply { + mutate() + setTint(getProperTextColor()) + } } } binding.contactNumbersImage.beVisible() From 8cbf4a5666391f5b9cbe55fdf2b28d643abd0c6c Mon Sep 17 00:00:00 2001 From: Dominik Riebeling Date: Sat, 7 Jun 2025 22:59:50 +0200 Subject: [PATCH 2/4] Update Changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7f757acb1..8dfce5f11 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Fixed + +- Fixed preferred number indicator not visible on white background + ## [1.2.1] - 2025-06-03 ### Changed From 087f884bb735479f4af017f95ee0bb196a645009 Mon Sep 17 00:00:00 2001 From: bluebrother Date: Sun, 8 Jun 2025 08:28:08 +0200 Subject: [PATCH 3/4] Use helper function for setting color Co-authored-by: Naveen Singh <36371707+naveensingh@users.noreply.github.com> --- .../org/fossify/contacts/activities/ViewContactActivity.kt | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/app/src/main/kotlin/org/fossify/contacts/activities/ViewContactActivity.kt b/app/src/main/kotlin/org/fossify/contacts/activities/ViewContactActivity.kt index 64384a967..8b587da59 100644 --- a/app/src/main/kotlin/org/fossify/contacts/activities/ViewContactActivity.kt +++ b/app/src/main/kotlin/org/fossify/contacts/activities/ViewContactActivity.kt @@ -403,10 +403,7 @@ class ViewContactActivity : ContactActivity() { } defaultToggleIcon.isVisible = phoneNumber.isPrimary - defaultToggleIcon.drawable?.apply { - mutate() - setTint(getProperTextColor()) - } + defaultToggleIcon.applyColorFilter(getProperTextColor()) } } binding.contactNumbersImage.beVisible() From 4d8e25ca068c6fb1c3dc3f5062b8cf3d519d14fe Mon Sep 17 00:00:00 2001 From: Dominik Riebeling Date: Sun, 8 Jun 2025 08:30:59 +0200 Subject: [PATCH 4/4] Update Changelog --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8dfce5f11..2b8a49ed6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed -- Fixed preferred number indicator not visible on white background +- Fixed invisible preferred number indicator in light themes ([#289]) ## [1.2.1] - 2025-06-03 @@ -74,3 +74,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 [#30]: https://github.com/FossifyOrg/Contacts/issues/30 [#201]: https://github.com/FossifyOrg/Contacts/issues/201 [#281]: https://github.com/FossifyOrg/Contacts/issues/281 +[#289]: https://github.com/FossifyOrg/Contacts/issues/289