Check result of branch-deploy on every subsequent step

[kevinbackhouse]

Unfortunately, this seems to be the only solution. See #111 for my previous attempts.

[Copilot]

Pull request overview

This PR refactors the smoketest workflow by consolidating it from a two-job structure into a single job that checks the branch-deploy output on each subsequent step. This approach eliminates the need for job dependencies and output passing between jobs.

Key Changes:

• Merged permission-check and run-tests jobs into a single Linux job
• Added conditional checks on each step to verify branch-deploy continue output
• Removed job-level needs and outputs configuration

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The if conditional syntax is incorrect. In GitHub Actions, the if keyword should be followed by a colon : and the condition expression should reference the step output using ${{ }} syntax.

The correct syntax should be:

- if: steps.branch-deploy.outputs.continue == 'true'
  name: Run tests

Note the colon after if and the proper expression syntax with ${{ }}.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

[nitpick] The if conditional should be placed after the name field. Consider:

- name: Run tests
  if: steps.branch-deploy.outputs.continue == 'true'
  env:
    AI_API_TOKEN: ${{ secrets.AI_API_TOKEN }}
    GITHUB_AUTH_HEADER: "Bearer ${{ secrets.GITHUB_TOKEN }}"
  run: |
    ...

See below for a potential fix:

      - name: Setup Python
        if: steps.branch-deploy.outputs.continue == "true"
        uses: actions/setup-python@v5
        with:
          python-version: '3.11'

      - name: Checkout the repo
        if: steps.branch-deploy.outputs.continue == "true"
        uses: actions/checkout@v6
        with:
          ref: ${{ steps.branch-deploy.outputs.sha }}

      - name: Setup Python venv
        if: steps.branch-deploy.outputs.continue == "true"
        run: |
          python -m venv .venv
          source .venv/bin/activate
          python -m pip install hatch

      - name: Run tests
        if: steps.branch-deploy.outputs.continue == "true"

[Copilot]

[nitpick] The if conditional should be placed after the name field in the step definition, not before it. While GitHub Actions is sometimes forgiving about field order, the standard convention is:

- name: Setup Python
  if: steps.branch-deploy.outputs.continue == 'true'
  uses: actions/setup-python@v5
  with:
    python-version: '3.11'

This ensures better readability and follows GitHub Actions best practices.

See below for a potential fix:

      - name: Setup Python
        if: steps.branch-deploy.outputs.continue == "true"
        uses: actions/setup-python@v5
        with:
          python-version: '3.11'

      - name: Checkout the repo
        if: steps.branch-deploy.outputs.continue == "true"
        uses: actions/checkout@v6
        with:
          ref: ${{ steps.branch-deploy.outputs.sha }}

      - name: Setup Python venv
        if: steps.branch-deploy.outputs.continue == "true"
        run: |
          python -m venv .venv
          source .venv/bin/activate
          python -m pip install hatch

      - name: Run tests
        if: steps.branch-deploy.outputs.continue == "true"

[Copilot]

[nitpick] The if conditional should be placed after the name field. Consider:

- name: Checkout the repo
  if: steps.branch-deploy.outputs.continue == 'true'
  uses: actions/checkout@v6
  with:
    ref: ${{ steps.branch-deploy.outputs.sha }}

See below for a potential fix:

      - name: Setup Python
        if: steps.branch-deploy.outputs.continue == "true"
        uses: actions/setup-python@v5
        with:
          python-version: '3.11'

      - name: Checkout the repo
        if: steps.branch-deploy.outputs.continue == "true"
        uses: actions/checkout@v6
        with:
          ref: ${{ steps.branch-deploy.outputs.sha }}

      - name: Setup Python venv
        if: steps.branch-deploy.outputs.continue == "true"
        run: |
          python -m venv .venv
          source .venv/bin/activate
          python -m pip install hatch

      - name: Run tests
        if: steps.branch-deploy.outputs.continue == "true"

[Copilot]

[nitpick] The if conditional should be placed after the name field. Consider:

- name: Setup Python venv
  if: steps.branch-deploy.outputs.continue == 'true'
  run: |
    python -m venv .venv
    source .venv/bin/activate
    python -m pip install hatch

Suggested change

	- if: steps.branch-deploy.outputs.continue == "true"
	name: Setup Python venv
	- name: Setup Python venv
	if: steps.branch-deploy.outputs.continue == "true"