From 5ed1b86a601a162ff00f42ae9dba1677425991be Mon Sep 17 00:00:00 2001 From: github-actions Date: Wed, 11 Mar 2026 10:55:41 +0000 Subject: [PATCH] chore: post-release core cleanup for v1.12.1 --- contract_verifier_test.go | 2 +- health_contract_bdd_test.go | 28 ++++++++++++++-------------- health_test.go | 6 +++--- logger_decorator_base_bdd_test.go | 10 +++++----- metrics_test.go | 4 ++-- observer_test.go | 2 +- plugin_test.go | 6 +++--- reload_contract_bdd_test.go | 4 ++-- reload_integration_test.go | 6 +++--- reload_test.go | 2 +- tenant_config_loader_test.go | 2 +- 11 files changed, 36 insertions(+), 36 deletions(-) diff --git a/contract_verifier_test.go b/contract_verifier_test.go index a4237365..d5520c3d 100644 --- a/contract_verifier_test.go +++ b/contract_verifier_test.go @@ -17,7 +17,7 @@ func (w *wellBehavedReloadable) Reload(ctx context.Context, _ []ConfigChange) er } return nil } -func (w *wellBehavedReloadable) CanReload() bool { return true } +func (w *wellBehavedReloadable) CanReload() bool { return true } func (w *wellBehavedReloadable) ReloadTimeout() time.Duration { return 5 * time.Second } // zeroTimeoutReloadable returns a zero timeout. diff --git a/health_contract_bdd_test.go b/health_contract_bdd_test.go index 517bae85..9e6278c1 100644 --- a/health_contract_bdd_test.go +++ b/health_contract_bdd_test.go @@ -14,16 +14,16 @@ import ( // Static errors for health contract BDD tests. var ( - errExpectedOverallHealthy = errors.New("expected overall status to be healthy") - errExpectedOverallUnhealthy = errors.New("expected overall status to be unhealthy") - errExpectedReadinessHealthy = errors.New("expected readiness to be healthy") - errExpectedReadinessUnhealthy = errors.New("expected readiness to be unhealthy") - errExpectedPanicUnhealthy = errors.New("expected panicking provider to report unhealthy") + errExpectedOverallHealthy = errors.New("expected overall status to be healthy") + errExpectedOverallUnhealthy = errors.New("expected overall status to be unhealthy") + errExpectedReadinessHealthy = errors.New("expected readiness to be healthy") + errExpectedReadinessUnhealthy = errors.New("expected readiness to be unhealthy") + errExpectedPanicUnhealthy = errors.New("expected panicking provider to report unhealthy") errExpectedOtherProvidersChecked = errors.New("expected other providers to still be checked") - errExpectedDegradedStatus = errors.New("expected provider status to be degraded") - errExpectedSingleCall = errors.New("expected provider to be called only once") - errExpectedRefreshCall = errors.New("expected provider to be called again on refresh") - errExpectedStatusChangedEvent = errors.New("expected health status changed event") + errExpectedDegradedStatus = errors.New("expected provider status to be degraded") + errExpectedSingleCall = errors.New("expected provider to be called only once") + errExpectedRefreshCall = errors.New("expected provider to be called again on refresh") + errExpectedStatusChangedEvent = errors.New("expected health status changed event") ) // healthBDDProvider is a configurable mock HealthProvider for BDD tests. @@ -102,11 +102,11 @@ func (s *healthBDDSubject) reset() { // HealthBDDContext holds state for health contract BDD scenarios. type HealthBDDContext struct { - service *AggregateHealthService - subject *healthBDDSubject - providers map[string]*healthBDDProvider - result *AggregatedHealth - checkErr error + service *AggregateHealthService + subject *healthBDDSubject + providers map[string]*healthBDDProvider + result *AggregatedHealth + checkErr error } func (hc *HealthBDDContext) reset() { diff --git a/health_test.go b/health_test.go index 96e47683..9a200dc4 100644 --- a/health_test.go +++ b/health_test.go @@ -102,9 +102,9 @@ type testSubject struct { events []cloudevents.Event } -func (s *testSubject) RegisterObserver(_ Observer, _ ...string) error { return nil } -func (s *testSubject) UnregisterObserver(_ Observer) error { return nil } -func (s *testSubject) GetObservers() []ObserverInfo { return nil } +func (s *testSubject) RegisterObserver(_ Observer, _ ...string) error { return nil } +func (s *testSubject) UnregisterObserver(_ Observer) error { return nil } +func (s *testSubject) GetObservers() []ObserverInfo { return nil } func (s *testSubject) NotifyObservers(_ context.Context, event cloudevents.Event) error { s.mu.Lock() s.events = append(s.events, event) diff --git a/logger_decorator_base_bdd_test.go b/logger_decorator_base_bdd_test.go index acd93702..55415c91 100644 --- a/logger_decorator_base_bdd_test.go +++ b/logger_decorator_base_bdd_test.go @@ -8,11 +8,11 @@ import ( // Static errors for logger decorator BDD tests var ( - errLoggerNotSet = errors.New("logger not set") - errBaseLoggerNotSet = errors.New("base logger not set") - errPrimaryLoggerNotSet = errors.New("primary logger not set") - errSecondaryLoggerNotSet = errors.New("secondary logger not set") - errDecoratedLoggerNotSet = errors.New("decorated logger not set") + errLoggerNotSet = errors.New("logger not set") + errBaseLoggerNotSet = errors.New("base logger not set") + errPrimaryLoggerNotSet = errors.New("primary logger not set") + errSecondaryLoggerNotSet = errors.New("secondary logger not set") + errDecoratedLoggerNotSet = errors.New("decorated logger not set") errNoMessagesLogged = errors.New("no messages logged") errServiceLoggerMismatch = errors.New("service logger mismatch") ) diff --git a/metrics_test.go b/metrics_test.go index 561de7d0..06d64089 100644 --- a/metrics_test.go +++ b/metrics_test.go @@ -9,7 +9,7 @@ type metricsTestModule struct { name string } -func (m *metricsTestModule) Name() string { return m.name } +func (m *metricsTestModule) Name() string { return m.name } func (m *metricsTestModule) Init(app Application) error { return nil } func (m *metricsTestModule) CollectMetrics(ctx context.Context) ModuleMetrics { return ModuleMetrics{ @@ -22,7 +22,7 @@ type nonMetricsModule struct { name string } -func (m *nonMetricsModule) Name() string { return m.name } +func (m *nonMetricsModule) Name() string { return m.name } func (m *nonMetricsModule) Init(app Application) error { return nil } func TestCollectAllMetrics(t *testing.T) { diff --git a/observer_test.go b/observer_test.go index 53be5000..775a210a 100644 --- a/observer_test.go +++ b/observer_test.go @@ -1,9 +1,9 @@ package modular import ( - "slices" "context" "errors" + "slices" "testing" "time" diff --git a/plugin_test.go b/plugin_test.go index acd07798..8c0af737 100644 --- a/plugin_test.go +++ b/plugin_test.go @@ -8,9 +8,9 @@ type testPlugin struct { hookRan bool } -func (p *testPlugin) Name() string { return "test-plugin" } -func (p *testPlugin) Modules() []Module { return p.modules } -func (p *testPlugin) Services() []ServiceDefinition { return p.services } +func (p *testPlugin) Name() string { return "test-plugin" } +func (p *testPlugin) Modules() []Module { return p.modules } +func (p *testPlugin) Services() []ServiceDefinition { return p.services } func (p *testPlugin) InitHooks() []func(Application) error { return []func(Application) error{ func(app Application) error { diff --git a/reload_contract_bdd_test.go b/reload_contract_bdd_test.go index c506c208..6e7aa4e1 100644 --- a/reload_contract_bdd_test.go +++ b/reload_contract_bdd_test.go @@ -1,10 +1,10 @@ package modular import ( - "slices" "context" "errors" "fmt" + "slices" "strings" "sync" "sync/atomic" @@ -49,7 +49,7 @@ func (m *reloadBDDMockReloadable) Reload(_ context.Context, changes []ConfigChan return m.reloadErr } -func (m *reloadBDDMockReloadable) CanReload() bool { return m.canReload } +func (m *reloadBDDMockReloadable) CanReload() bool { return m.canReload } func (m *reloadBDDMockReloadable) ReloadTimeout() time.Duration { return m.timeout } // reloadBDDSubject captures events for BDD reload contract tests. diff --git a/reload_integration_test.go b/reload_integration_test.go index 8dc6a47a..f1cbac3d 100644 --- a/reload_integration_test.go +++ b/reload_integration_test.go @@ -12,9 +12,9 @@ type reloadableTestModule struct { reloadCount atomic.Int32 } -func (m *reloadableTestModule) Name() string { return m.name } -func (m *reloadableTestModule) Init(app Application) error { return nil } -func (m *reloadableTestModule) CanReload() bool { return true } +func (m *reloadableTestModule) Name() string { return m.name } +func (m *reloadableTestModule) Init(app Application) error { return nil } +func (m *reloadableTestModule) CanReload() bool { return true } func (m *reloadableTestModule) ReloadTimeout() time.Duration { return 5 * time.Second } func (m *reloadableTestModule) Reload(ctx context.Context, changes []ConfigChange) error { m.reloadCount.Add(1) diff --git a/reload_test.go b/reload_test.go index 24bdef0f..a03cb6b5 100644 --- a/reload_test.go +++ b/reload_test.go @@ -1,10 +1,10 @@ package modular import ( - "slices" "context" "errors" "fmt" + "slices" "strings" "sync" "sync/atomic" diff --git a/tenant_config_loader_test.go b/tenant_config_loader_test.go index e4ac8ace..4476ac78 100644 --- a/tenant_config_loader_test.go +++ b/tenant_config_loader_test.go @@ -1,8 +1,8 @@ package modular import ( - "maps" "log/slog" + "maps" "os" "path/filepath" "regexp"