From fd6c0fb38ee882bc9609c74d9b316f339c90b7d4 Mon Sep 17 00:00:00 2001 From: Olivier Bilodeau Date: Wed, 14 Aug 2019 16:18:40 -0400 Subject: [PATCH 1/2] CI: checking `malboxes list` return code Otherwise python or other low-level errors don't get logged in Jenkins --- tests/smoke/build-all-templates.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/smoke/build-all-templates.sh b/tests/smoke/build-all-templates.sh index 1c1ab8d..8122b04 100755 --- a/tests/smoke/build-all-templates.sh +++ b/tests/smoke/build-all-templates.sh @@ -22,6 +22,11 @@ pip3 install -e . echo "Fetching all templates..." TEMPLATES=`malboxes list | head -n-1 | tail -n+3` +if [[ ${PIPESTATUS[0]} != 0 ]]; then + echo "Malboxes didn't list templates. This is a fatal error. Force failing the build." + exit 1 +fi + # build all templates declare -A RESULTS From a9dc95d2a03d1053ac4040eef5d6b9f39bc766d2 Mon Sep 17 00:00:00 2001 From: Olivier Bilodeau Date: Wed, 14 Aug 2019 16:27:15 -0400 Subject: [PATCH 2/2] Updated CHANGELOG --- CHANGELOG.adoc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc index c185209..7b27515 100644 --- a/CHANGELOG.adoc +++ b/CHANGELOG.adoc @@ -13,8 +13,7 @@ Bug fixes:: * Disabled malware protection, cloud and automatic sample submission on Windows 10 ({uri-issue}120[#120]) Infrastructure Improvements:: -* Further improvements to Jenkins CI system fixed Windows 7 build issues ({uri-issue}108[#108], {uri-issue}110[#110]) -* Jenkins CI system can now perform smoke tests on external PRs ({uri-issue}123[#123]) +* Various Jenkins CI system improvements ({uri-issue}108[#108], {uri-issue}110[#110], {uri-issue}123[#123], {uri-issue}124[#124]) == 0.4.0