Clarification of hasOfflineStartUrl rule (#2775)

karolklp · paulirish · commit 7097d5cf742e · 2017-08-14T14:34:07.000-07:00
* Clarification of hasOfflineStartUrl rule Error message is confusing for some users (https://stackoverflow.com/questions/45330087/manifest-start-url-is-not-cached-by-a-service-worker) and technically it's not true. There's check if the start_url is returned, and if not the message that it's not cached is returned. There's possibility for service worker to cache it but not return it and receive this error message. * Adjusted wording
diff --git a/lighthouse-core/audits/webapp-install-banner.js b/lighthouse-core/audits/webapp-install-banner.js
@@ -81,7 +81,7 @@ class WebappInstallBanner extends MultiCheckAudit {
     const hasOfflineStartUrl = artifacts.StartUrl.statusCode === 200;
 
     if (!hasOfflineStartUrl) {
-      result.failures.push('Manifest start_url is not cached by a service worker');
+      result.failures.push('Service worker does not successfully serve the manifest\'s start_url');
     }
 
     if (artifacts.StartUrl.debugString) {

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ class WebappInstallBanner extends MultiCheckAudit {`
`81`	`81`	`const hasOfflineStartUrl = artifacts.StartUrl.statusCode === 200;`
`82`	`82`
`83`	`83`	`if (!hasOfflineStartUrl) {`
`84`		`- result.failures.push('Manifest start_url is not cached by a service worker');`
	`84`	`+ result.failures.push('Service worker does not successfully serve the manifest\'s start_url');`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`if (artifacts.StartUrl.debugString) {`