Skip to content

Commit a6b71c9

Browse files
paulirishpatrickhulce
authored andcommitted
emulation comment: can remove injectedTouchEventsFunction in October (#2889)
1 parent 618a678 commit a6b71c9

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

lighthouse-core/lib/emulation.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,11 @@ const CPU_THROTTLE_METRICS = {
7575
};
7676

7777
function enableNexus5X(driver) {
78+
// COMPAT FIMXE
79+
// Injecting this function clientside is no longer neccessary as of m62. This is done
80+
// on the backend when `Emulation.setTouchEmulationEnabled` is set.
81+
// https://bugs.chromium.org/p/chromium/issues/detail?id=133915#c63
82+
// Once m62 hits stable (~Oct 20th) we can nuke this entirely
7883
/**
7984
* Finalizes touch emulation by enabling `"ontouchstart" in window` feature detect
8085
* to work. Messy hack, though copied verbatim from DevTools' emulation/TouchModel.js

0 commit comments

Comments
 (0)