smoke test: simplify --harmony branching. check for viewport

paulirish · web-flow · commit d45883a10be2 · 2016-07-11T19:13:11.000-07:00
diff --git a/lighthouse-cli/scripts/run-smoke-tests.sh b/lighthouse-cli/scripts/run-smoke-tests.sh
@@ -2,27 +2,37 @@
 
 cd lighthouse-cli/test/fixtures && python -m SimpleHTTPServer 9999 &
 
-if [[ $(node -v) =~ ^v4.* ]]; then
-  node --harmony lighthouse-cli/index.js http://localhost:9999/online-only.html > results
-else
-  ./lighthouse-cli/index.js http://localhost:9999/online-only.html > results
+NODE=$([ $(node -v | grep -E "v4") ] && echo "node --harmony" || echo "node")
+offline200result="URL responds with a 200 when offline"
+
+
+$NODE lighthouse-cli http://localhost:9999/online-only.html > results
+
+# test that we have results
+if ! grep -q "$offline200result" results; then
+  echo "Fail! Lighthouse run didn't create a result file"
+  exit 1
 fi
 
-if ! grep -q "URL responds with a 200 when offline: false" results; then
+# test that we have a meta viewport defined in the static page
+if ! grep -q "HTML has a viewport <meta>: true" results; then
+  echo "Fail! Meta viewort not detected in the page"
+  exit 1
+fi
+
+# test static page which should fail the offline test
+if ! grep -q "$offline200result: false" results; then
   echo "Fail! online only site worked while offline"
   cat results
   exit 1
 fi
 
 sleep 5s
 
-if [[ $(node -v) =~ ^v4.* ]]; then
-  node --harmony lighthouse-cli/index.js https://www.moji-brush.com > results
-else
-  ./lighthouse-cli/index.js https://www.moji-brush.com > results
-fi
+# test mojibrush which should pass the offline test
+$NODE  lighthouse-cli https://www.moji-brush.com > results
 
-if ! grep -q "URL responds with a 200 when offline: true" results; then
+if ! grep -q "$offline200result: true" results; then
   echo "Fail! offline ready site did not work while offline"
   cat results
   exit 1
diff --git a/lighthouse-cli/test/fixtures/online-only.html b/lighthouse-cli/test/fixtures/online-only.html
@@ -1,4 +1,5 @@
 <html>
+  <meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=1.0">
   <body>
     There was nothing special about this site,
     nothing was left to be seen,

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`<html>`
	`2`	`+ <meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=1.0">`
`2`	`3`	`<body>`
`3`	`4`	`There was nothing special about this site,`
`4`	`5`	`nothing was left to be seen,`