Skip to content

Commit d7ffec1

Browse files
authored
driver: add compat comment on PerfObserver GC bug
1 parent 78a8bd7 commit d7ffec1

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

lighthouse-core/gather/driver.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1118,6 +1118,8 @@ function registerPerformanceObserverInPage() {
11181118
// HACK: A PerformanceObserver will be GC'd if there are no more references to it, so attach it to
11191119
// window to ensure we still receive longtask notifications. See https://crbug.com/742530.
11201120
// For an example test of this behavior see https://gist.github.com/patrickhulce/69d8bed1807e762218994b121d06fea6.
1121+
// FIXME COMPAT: This hack isn't neccessary as of Chrome 62.0.3176.0
1122+
// https://bugs.chromium.org/p/chromium/issues/detail?id=742530#c7
11211123
window.____lhPerformanceObserver = observer;
11221124
}
11231125

0 commit comments

Comments
 (0)