Skip to content

Commit 51c61aa

Browse files
authored
Merge pull request #124 from nkubala/staging_image
rename FULL_BASE_IMAGE to STAGING_IMAGE to match integration test fra…
2 parents a1e6904 + 2d172e0 commit 51c61aa

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

build.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,8 @@ fi
108108

109109
# Use latest released Debian as our base image
110110
export DEBIAN_BASE_IMAGE="gcr.io/google-appengine/debian8:latest"
111-
export FULL_BASE_IMAGE="${DOCKER_NAMESPACE}/python:${TAG}"
112-
echo "Using base image name ${FULL_BASE_IMAGE}"
111+
export STAGING_IMAGE="${DOCKER_NAMESPACE}/python:${TAG}"
112+
echo "Using base image name ${STAGING_IMAGE}"
113113

114114
# Generate Dockerfiles
115115
for outfile in \
@@ -120,7 +120,7 @@ for outfile in \
120120
tests/google-cloud-python-system/Dockerfile \
121121
tests/integration/Dockerfile \
122122
; do
123-
envsubst <"${outfile}".in >"${outfile}" '$DEBIAN_BASE_IMAGE $FULL_BASE_IMAGE $GOOGLE_CLOUD_PROJECT_FOR_TESTS'
123+
envsubst <"${outfile}".in >"${outfile}" '$DEBIAN_BASE_IMAGE $STAGING_IMAGE $GOOGLE_CLOUD_PROJECT_FOR_TESTS'
124124
done
125125

126126
# Build images and push to GCR

tests/benchmark/Dockerfile.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM ${FULL_BASE_IMAGE}
1+
FROM ${STAGING_IMAGE}
22

33
# Install performance
44
RUN pip install performance

tests/benchmark/benchmark_between_releases.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@
22

33
# Build the benchmark image for release 1 from Dockerfile
44
echo "Building image for release 1"
5-
export FULL_BASE_IMAGE="${DOCKER_NAMESPACE}/python:${TAG1}"
6-
envsubst <"Dockerfile".in >"Dockerfile" '$FULL_BASE_IMAGE'
5+
export STAGING_IMAGE="${DOCKER_NAMESPACE}/python:${TAG1}"
6+
envsubst <"Dockerfile".in >"Dockerfile" '$STAGING_IMAGE'
77
docker build --no-cache -t benchmark_1 .
88
rm Dockerfile
99

1010
# Build the benchmark image for release 2 from Dockerfile
1111
echo "Building image for release 2"
12-
export FULL_BASE_IMAGE="${DOCKER_NAMESPACE}/python:${TAG2}"
13-
envsubst <"Dockerfile".in >"Dockerfile" '$FULL_BASE_IMAGE'
12+
export STAGING_IMAGE="${DOCKER_NAMESPACE}/python:${TAG2}"
13+
envsubst <"Dockerfile".in >"Dockerfile" '$STAGING_IMAGE'
1414
docker build --no-cache -t benchmark_2 .
1515
rm Dockerfile
1616

tests/google-cloud-python-system/Dockerfile.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM ${FULL_BASE_IMAGE}
1+
FROM ${STAGING_IMAGE}
22

33
# Get the source.
44
RUN git clone --depth 1 https://github.com/GoogleCloudPlatform/google-cloud-python.git

tests/google-cloud-python/Dockerfile.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM ${FULL_BASE_IMAGE}
1+
FROM ${STAGING_IMAGE}
22

33
# Get the source.
44
RUN git clone --depth 1 https://github.com/GoogleCloudPlatform/google-cloud-python.git

tests/integration/Dockerfile.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
FROM ${FULL_BASE_IMAGE}
15+
FROM ${STAGING_IMAGE}
1616

1717
COPY . /app
1818
WORKDIR /app

0 commit comments

Comments
 (0)