Skip to content

Conversation

@fengys1996
Copy link
Contributor

@fengys1996 fengys1996 commented Dec 5, 2025

What's Changed in this PR

This pr mainly introduces describe of for and keep_firing_for clauses in trigger.

Checklist

  • Please confirm that all corresponding versions of the documents have been revised.
  • Please ensure that the content in sidebars.ts matches the current document structure when you changed the document structure.
  • This change requires follow-up update in localized docs.

@fengys1996 fengys1996 changed the title docs(trigger): add description of for and keep_firing_for clause docs(trigger): for and keep_firing_for Dec 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds documentation for two new optional clauses in the GreptimeDB Trigger syntax: FOR and KEEP_FIRING_FOR. These clauses provide control over alert state transitions, similar to Prometheus Alerting Rules. The documentation updates both the English and Chinese localized versions.

  • Added FOR clause documentation to control the pending duration before an alert fires
  • Added KEEP_FIRING_FOR clause documentation to control minimum firing duration after an alert triggers
  • Updated query expression descriptions to clarify alert instance concepts

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/reference/sql/trigger-syntax.md Added English documentation for FOR and KEEP_FIRING_FOR clauses in trigger syntax, clarified alert instance behavior and terminology
i18n/zh/docusaurus-plugin-content-docs/current/reference/sql/trigger-syntax.md Added Chinese documentation for FOR and KEEP_FIRING_FOR clauses in trigger syntax, clarified alert instance behavior and terminology

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fengys1996 fengys1996 marked this pull request as ready for review December 8, 2025 02:25
@fengys1996 fengys1996 requested a review from sunng87 December 8, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants