From 5c9544d04dc0e48e7a39f069794c0e116092bdfb Mon Sep 17 00:00:00 2001 From: Firesped <4176294+Firesped@users.noreply.github.com> Date: Mon, 13 Oct 2025 09:26:13 -0700 Subject: [PATCH 1/2] Update GunshellCommand.java .hasPermission requires a player. sender is not a player. new variable player type Player filled with sender converted to a Player with (Player) used to check the permission. --- .../com/jazzkuh/gunshell/common/commands/GunshellCommand.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/jazzkuh/gunshell/common/commands/GunshellCommand.java b/src/main/java/com/jazzkuh/gunshell/common/commands/GunshellCommand.java index 3636dc3..b440e86 100644 --- a/src/main/java/com/jazzkuh/gunshell/common/commands/GunshellCommand.java +++ b/src/main/java/com/jazzkuh/gunshell/common/commands/GunshellCommand.java @@ -20,6 +20,7 @@ public class GunshellCommand extends ExtendedAnnotationCommand { @Main @Alias("gs") public void main(CommandSender sender) { + Player player = (Player) sender; if (!sender.hasPermission("gunshell.commands.gunshell")) { this.onInfo(sender); return; @@ -143,4 +144,4 @@ public void onGetMelee(CommandSender sender, GunshellMelee melee, int durability player.getInventory().addItem(melee.getItemStack(durability)); MessagesConfig.SUCCESSFULLY_ADDED_MELEE_TO_INVENTORY.get(sender); } -} \ No newline at end of file +} From 1cfcfee92ab2f2bef7662fcc2a6037062fdaa1be Mon Sep 17 00:00:00 2001 From: Firesped <4176294+Firesped@users.noreply.github.com> Date: Mon, 13 Oct 2025 09:39:16 -0700 Subject: [PATCH 2/2] Update v1_21_8.java mappings changed. https://mappings.dev/1.21.5/ https://mappings.dev/1.21.8/ https://mappings.dev/1.21.9/ also implementation should be isolated with the specific require dependencies to compile. 1.21.5 (1.21.R4) uses the spigot-api for 1.21.5 and the spigot 1.21.5 1.21.8 (1.21.R5) uses the spigot-api for 1.21.8 and the spigot 1.21.8 for future notes 1.21.9 (1.21.R6) uses the spigot-api for 1.21.9 and the spigot 1.21.9 1.21.11(in theory as we have snapshots for it)(1.21.R7) will use the spigot-api for 1.21.11 and the spigot 1.21.11 --- .../jazzkuh/gunshell/compatibility/versions/v1_21_8.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/jazzkuh/gunshell/compatibility/versions/v1_21_8.java b/src/main/java/com/jazzkuh/gunshell/compatibility/versions/v1_21_8.java index 58aa23d..01aaaf3 100644 --- a/src/main/java/com/jazzkuh/gunshell/compatibility/versions/v1_21_8.java +++ b/src/main/java/com/jazzkuh/gunshell/compatibility/versions/v1_21_8.java @@ -64,13 +64,13 @@ public String getRayTraceResult(Player player, int range) { @Override public void showEndCreditScene(Player player) { PacketPlayOutGameStateChange gameStateChange = new PacketPlayOutGameStateChange(PacketPlayOutGameStateChange.e, 1f); - ((CraftPlayer) player).getHandle().f.a(gameStateChange); + ((CraftPlayer) player).getHandle().g.a(gameStateChange); } @Override public void showDemoMenu(Player player) { PacketPlayOutGameStateChange gameStateChange = new PacketPlayOutGameStateChange(PacketPlayOutGameStateChange.f, 0f); - ((CraftPlayer) player).getHandle().f.a(gameStateChange); + ((CraftPlayer) player).getHandle().g.a(gameStateChange); } @Override @@ -81,7 +81,7 @@ public void sendPumpkinEffect(Player player, boolean forRemoval) { itemStack = XMaterial.CARVED_PUMPKIN.parseItem(); } - craftPlayer.getHandle().f.a(new PacketPlayOutSetSlot(0, 0, 5, + craftPlayer.getHandle().g.a(new PacketPlayOutSetSlot(0, 0, 5, CraftItemStack.asNMSCopy(itemStack))); }