From 118964d0736d2a2542bddeb8882db8806bc5500a Mon Sep 17 00:00:00 2001 From: Nicko Winner-Arroyo Date: Tue, 25 Aug 2020 15:50:48 -0400 Subject: [PATCH 1/5] Fix importing so that you can import like this: import { Alert } from '@helix-design-system/helix-react/'; --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 8350b20..c4dc304 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,7 @@ "source": "src/index.mjs", "main": "dist/index.js", "umd:main": "dist/index.umd.js", - "module": "dist/index.m.js", + "module": "dist/index.js", "scripts": { "install:clean": "rm -rf node_modules && yarn install", "build": "microbundle -i src/index.mjs --external react,react-dom --name HelixReact --jsx React.createElement --jsxFragment React.Fragment --compress false --sourcemap false", From d0bbcff8fed324096a63270c9be3ceda8ed964a4 Mon Sep 17 00:00:00 2001 From: Nicko Winner-Arroyo Date: Tue, 25 Aug 2020 15:59:36 -0400 Subject: [PATCH 2/5] Update Readme --- README.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 75b05be..eac6c18 100644 --- a/README.md +++ b/README.md @@ -42,7 +42,11 @@ you can also see the components in Storybook in order to play around yourself. ## Installation -More details to come. +```npm -i @helix-design-system/helix-react helix-ui prop-types``` + +or + +```yarn add @helix-design-system/helix-react helix-ui prop-types``` ### Prerequisites From 907660d359239a97e64b01cff95ace09f0e697b6 Mon Sep 17 00:00:00 2001 From: Nicko Winner-Arroyo Date: Tue, 25 Aug 2020 21:59:51 -0400 Subject: [PATCH 3/5] Change export style so that CJS imports work --- package.json | 6 +++--- src/index.mjs | 2 +- yarn.lock | 5 ----- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/package.json b/package.json index c4dc304..3ce12a7 100644 --- a/package.json +++ b/package.json @@ -3,9 +3,9 @@ "version": "1.0.0", "description": "React components to wrap HelixUI custom elements", "source": "src/index.mjs", - "main": "dist/index.js", - "umd:main": "dist/index.umd.js", - "module": "dist/index.js", + "main": "dist/helix-react.js", + "module": "dist/helix-react.module.js", + "unpkg": "dist/helix-react.umd.js", "scripts": { "install:clean": "rm -rf node_modules && yarn install", "build": "microbundle -i src/index.mjs --external react,react-dom --name HelixReact --jsx React.createElement --jsxFragment React.Fragment --compress false --sourcemap false", diff --git a/src/index.mjs b/src/index.mjs index 74a7325..33e8fac 100644 --- a/src/index.mjs +++ b/src/index.mjs @@ -21,7 +21,7 @@ import Text from './Text'; import TextArea from './TextArea'; import Tooltip from './Tooltip'; -export default { +export { Alert, Button, Checkbox, diff --git a/yarn.lock b/yarn.lock index c8fc2f2..e5792ae 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2700,11 +2700,6 @@ "@webassemblyjs/wast-parser" "1.8.5" "@xtuc/long" "4.2.2" -"@webcomponents/webcomponentsjs@^2.4.3": - version "2.4.4" - resolved "https://registry.yarnpkg.com/@webcomponents/webcomponentsjs/-/webcomponentsjs-2.4.4.tgz#14b7e78da47f8f0071ff96c35335b871534179bc" - integrity sha512-UWXZYbaDLLfhm+xONXTiDciyhOSwKRrZieGQHFMSMGSxY4mbjZ5uYzOKgnuX0luYFvjJw32G3r0sCwQZPJIR4Q== - "@xtuc/ieee754@^1.2.0": version "1.2.0" resolved "https://registry.yarnpkg.com/@xtuc/ieee754/-/ieee754-1.2.0.tgz#eef014a3145ae477a1cbc00cd1e552336dceb790" From 200327a6a043624791203ec1e4b706dd01e5a4ac Mon Sep 17 00:00:00 2001 From: Nicko Winner-Arroyo Date: Wed, 26 Aug 2020 09:14:12 -0400 Subject: [PATCH 4/5] Make it closer to helix naming convention --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 3ce12a7..a1f6982 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "description": "React components to wrap HelixUI custom elements", "source": "src/index.mjs", "main": "dist/helix-react.js", - "module": "dist/helix-react.module.js", + "module": "dist/helix-react.esm.js", "unpkg": "dist/helix-react.umd.js", "scripts": { "install:clean": "rm -rf node_modules && yarn install", From 4ae3600b5de0ca6346fba3613ba6b72f97190eef Mon Sep 17 00:00:00 2001 From: Nicko Winner-Arroyo Date: Wed, 26 Aug 2020 20:46:20 -0400 Subject: [PATCH 5/5] unpkg changed over to using cjs bundle --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index a1f6982..94030b7 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,7 @@ "source": "src/index.mjs", "main": "dist/helix-react.js", "module": "dist/helix-react.esm.js", - "unpkg": "dist/helix-react.umd.js", + "unpkg": "dist/helix-react.js", "scripts": { "install:clean": "rm -rf node_modules && yarn install", "build": "microbundle -i src/index.mjs --external react,react-dom --name HelixReact --jsx React.createElement --jsxFragment React.Fragment --compress false --sourcemap false",