From 4077589b7e77da2a72fa2423564f3582db3ad8d0 Mon Sep 17 00:00:00 2001 From: Abdirahim Musse <33973272+abmusse@users.noreply.github.com> Date: Tue, 1 Nov 2022 14:28:52 -0500 Subject: [PATCH 1/5] ci: Disable running integration tests Currently we don't have a remote system to run the integration tests on. This causes every PR check to fail. Until we resolve this disable running the integration tests. --- .github/workflows/ci.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 01bb1d0f..c9a40570 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -26,12 +26,12 @@ jobs: - run: npm test env: CI: true - - run: npm run test-integration - env: - TKTRANSPORT: 'ssh' - TKHOST: ${{ secrets.IBMI_HOSTNAME }} - TKUSER: ${{ secrets.IBMI_USERNAME }} - TKPASS: ${{ secrets.IBMI_PASSWORD }} +# - run: npm run test-integration +# env: +# TKTRANSPORT: 'ssh' +# TKHOST: ${{ secrets.IBMI_HOSTNAME }} +# TKUSER: ${{ secrets.IBMI_USERNAME }} +# TKPASS: ${{ secrets.IBMI_PASSWORD }} eslint: runs-on: ubuntu-latest From 00896633d821a6c00740b85bf112315be077a164 Mon Sep 17 00:00:00 2001 From: Abdirahim Musse <33973272+abmusse@users.noreply.github.com> Date: Tue, 1 Nov 2022 14:34:02 -0500 Subject: [PATCH 2/5] Remove node 8 as yargs used min node 10 --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c9a40570..f1c5dea9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,8 @@ jobs: strategy: matrix: - node-version: [8.x, 10.x, 12.x] + # yargs for mocha uses minimum node 10 + node-version: [10.x, 12.x] steps: - uses: actions/checkout@v2 From 8dda4e6d4d4d612896055d900c42dcf37eaf4945 Mon Sep 17 00:00:00 2001 From: Abdirahim Musse <33973272+abmusse@users.noreply.github.com> Date: Tue, 1 Nov 2022 14:58:05 -0500 Subject: [PATCH 3/5] mochajs 10.x.x uses min node 14 --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f1c5dea9..f2ecbfd1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,13 +13,13 @@ jobs: strategy: matrix: - # yargs for mocha uses minimum node 10 - node-version: [10.x, 12.x] + # yargs for mochajs 10 uses min node 14 + node-version: [14.x, 16.x, 18.x] steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} - run: npm ci From d0270b5f849d9c1961b5180840475e01f5b52fa2 Mon Sep 17 00:00:00 2001 From: Abdirahim Musse <33973272+abmusse@users.noreply.github.com> Date: Tue, 1 Nov 2022 14:58:43 -0500 Subject: [PATCH 4/5] typo fixup --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f2ecbfd1..37161cac 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,7 @@ jobs: strategy: matrix: - # yargs for mochajs 10 uses min node 14 + # mochajs 10.x.x uses min node 14 node-version: [14.x, 16.x, 18.x] steps: From a79eff9456b609e3e06479b2ab0c95c973d12ace Mon Sep 17 00:00:00 2001 From: Abdirahim Musse <33973272+abmusse@users.noreply.github.com> Date: Tue, 1 Nov 2022 15:47:05 -0500 Subject: [PATCH 5/5] use checkout v3 for eslint job too --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 37161cac..bd5f3444 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -37,6 +37,6 @@ jobs: eslint: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - run: npm ci - run: npm run lint