From 89ef31bd9e18e9f553e1f896b29ce11824bd5c3a Mon Sep 17 00:00:00 2001 From: Michael Heppler Date: Tue, 21 May 2019 16:59:08 -0400 Subject: [PATCH 01/10] Added focus to contact dialog with render logic for userEmail vs messageSubject [ref #5717] --- src/main/webapp/contactFormFragment.xhtml | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/webapp/contactFormFragment.xhtml b/src/main/webapp/contactFormFragment.xhtml index 33565e21e8f..88759ee590e 100644 --- a/src/main/webapp/contactFormFragment.xhtml +++ b/src/main/webapp/contactFormFragment.xhtml @@ -8,6 +8,7 @@ +
From 6f9a38bf01a97d39e7739d523a876a548508edbd Mon Sep 17 00:00:00 2001 From: Michael Heppler Date: Thu, 23 May 2019 16:44:19 -0400 Subject: [PATCH 02/10] Added focus component to popups and changed btn-link styles for Cancel btns [ref #5717] --- src/main/java/propertyFiles/Bundle.properties | 1 - src/main/webapp/contactFormFragment.xhtml | 6 +- src/main/webapp/dashboard-datamove.xhtml | 5 +- src/main/webapp/dashboard-users.xhtml | 11 +-- src/main/webapp/dataset-widgets.xhtml | 12 ++-- src/main/webapp/dataverse.xhtml | 70 ++++++++++--------- src/main/webapp/dataverse_template.xhtml | 11 +-- .../webapp/explicitGroup-new-dialog.xhtml | 3 +- .../file-configure-popup-fragment.xhtml | 2 +- .../webapp/file-download-popup-fragment.xhtml | 3 +- .../file-request-access-popup-fragment.xhtml | 2 +- src/main/webapp/file.xhtml | 18 ++--- src/main/webapp/harvestclients.xhtml | 14 ++-- src/main/webapp/harvestsets.xhtml | 8 +-- src/main/webapp/manage-groups.xhtml | 9 +-- src/main/webapp/manage-guestbooks.xhtml | 8 +-- src/main/webapp/manage-templates.xhtml | 11 +-- src/main/webapp/permissions-configure.xhtml | 1 + .../webapp/permissions-manage-files.xhtml | 17 ++--- src/main/webapp/permissions-manage.xhtml | 6 +- src/main/webapp/roles-assign.xhtml | 13 ++-- src/main/webapp/roles-edit.xhtml | 51 +++++++------- src/main/webapp/search-include-fragment.xhtml | 2 +- 23 files changed, 140 insertions(+), 144 deletions(-) diff --git a/src/main/java/propertyFiles/Bundle.properties b/src/main/java/propertyFiles/Bundle.properties index 81598c22947..4938c300283 100755 --- a/src/main/java/propertyFiles/Bundle.properties +++ b/src/main/java/propertyFiles/Bundle.properties @@ -569,7 +569,6 @@ dashboard.list_users.removeAll.message.failure=Failed to remove roles for user { dashboard.list_users.toggleSuperuser=Edit Superuser Status dashboard.list_users.toggleSuperuser.confirmationText.add=Are you sure you want to enable superuser status for user {0}? dashboard.list_users.toggleSuperuser.confirmationText.remove=Are you sure you want to disable superuser status for user {0}? -dashboard.list_users.toggleSuperuser.confirm=Continue dashboard.list_users.api.auth.invalid_apikey=The API key is invalid. dashboard.list_users.api.auth.not_superuser=Forbidden. You must be a superuser. diff --git a/src/main/webapp/contactFormFragment.xhtml b/src/main/webapp/contactFormFragment.xhtml index 88759ee590e..6d924b535f4 100644 --- a/src/main/webapp/contactFormFragment.xhtml +++ b/src/main/webapp/contactFormFragment.xhtml @@ -8,7 +8,7 @@ - +
@@ -72,10 +72,10 @@
+ update="@form" oncomplete="if (args && !args.validationFailed) PF('contactForm').hide();" actionListener="#{sendFeedbackDialog.sendMessage}"> -
diff --git a/src/main/webapp/dashboard-datamove.xhtml b/src/main/webapp/dashboard-datamove.xhtml index 869c1e6130d..dc64e972885 100644 --- a/src/main/webapp/dashboard-datamove.xhtml +++ b/src/main/webapp/dashboard-datamove.xhtml @@ -24,6 +24,7 @@ +
#{bundle['dashboard.card.datamove.selectdataset.header']}
@@ -125,7 +126,7 @@ prevents the confirm dialog to pop up (client side) if validation fails --> - + @@ -139,7 +140,7 @@ onclick="PF('datamoveConfirmation').hide();" action="#{DashboardDatamovePage.move()}" update=":datamove-form:dsPersistentIds,:datamove-form:move" /> -
diff --git a/src/main/webapp/dashboard-users.xhtml b/src/main/webapp/dashboard-users.xhtml index d424da75680..f234ee779a0 100644 --- a/src/main/webapp/dashboard-users.xhtml +++ b/src/main/webapp/dashboard-users.xhtml @@ -24,6 +24,7 @@ +
@@ -99,15 +100,15 @@

- - + +
- +

#{DashboardUsersPage.confirmRemoveRolesMessage}

- - + +
diff --git a/src/main/webapp/dataset-widgets.xhtml b/src/main/webapp/dataset-widgets.xhtml index 4adaf814f8f..1d7cfbc1787 100644 --- a/src/main/webapp/dataset-widgets.xhtml +++ b/src/main/webapp/dataset-widgets.xhtml @@ -75,18 +75,18 @@
- +
- +

- #{bundle['dataset.thumbnailsAndWidget.removeThumbnail.tip']} + #{bundle['dataset.thumbnailsAndWidget.removeThumbnail.tip']}

- +
@@ -111,13 +111,11 @@
- -
- diff --git a/src/main/webapp/dataverse.xhtml b/src/main/webapp/dataverse.xhtml index b2366e3bd58..fed7d31a398 100644 --- a/src/main/webapp/dataverse.xhtml +++ b/src/main/webapp/dataverse.xhtml @@ -579,55 +579,56 @@ -
-

#{bundle['dataverse.selectToFeature']}

- -
-
- - -
+ +
+

#{bundle['dataverse.selectToFeature']}

+ +
+
+ + +
-

- #{bundle['dataverse.nopublished.tip']} -

-
- -
+

+ #{bundle['dataverse.nopublished.tip']} +

+
+ +
- +

#{bundle['dataverse.publish.tip']}

- - + +
- +

#{bundle['dataverse.publish.failed.tip']}

- +
- +

#{bundle['dataverse.delete.tip']}

- - + +
@@ -642,6 +643,7 @@ +

#{bundle['dataverse.link.dataverse.choose']}

@@ -655,7 +657,7 @@
- + @@ -699,11 +701,11 @@
- - - +
@@ -721,8 +723,8 @@
- - + +
@@ -730,7 +732,7 @@ #{bundle['dataverse.link.no.linkable']}

- +
@@ -741,8 +743,8 @@ #{bundle['dataverse.resetModifications.text']}

- - + +
diff --git a/src/main/webapp/dataverse_template.xhtml b/src/main/webapp/dataverse_template.xhtml index 612d6bf0107..fd442541f7a 100644 --- a/src/main/webapp/dataverse_template.xhtml +++ b/src/main/webapp/dataverse_template.xhtml @@ -78,16 +78,7 @@ - - - -

-
- -
-
+ diff --git a/src/main/webapp/explicitGroup-new-dialog.xhtml b/src/main/webapp/explicitGroup-new-dialog.xhtml index a061e29ebd6..9fa4ea992b5 100644 --- a/src/main/webapp/explicitGroup-new-dialog.xhtml +++ b/src/main/webapp/explicitGroup-new-dialog.xhtml @@ -5,6 +5,7 @@ xmlns:iqbs="http://xmlns.jcp.org/jsf/composite/iqbs"> +
@@ -90,7 +91,7 @@ oncomplete="if (args && !args.validationFailed) PF('explicitGroupForm').hide();"> - +
diff --git a/src/main/webapp/file-configure-popup-fragment.xhtml b/src/main/webapp/file-configure-popup-fragment.xhtml index 232b8d2dbb2..d369b5ff417 100644 --- a/src/main/webapp/file-configure-popup-fragment.xhtml +++ b/src/main/webapp/file-configure-popup-fragment.xhtml @@ -19,6 +19,6 @@ onclick="PF('configureToolPopup').hide();" update=":messagePanel"> - +
\ No newline at end of file diff --git a/src/main/webapp/file-download-popup-fragment.xhtml b/src/main/webapp/file-download-popup-fragment.xhtml index b514e9a56dc..43652e44054 100644 --- a/src/main/webapp/file-download-popup-fragment.xhtml +++ b/src/main/webapp/file-download-popup-fragment.xhtml @@ -10,6 +10,7 @@ +

#{bundle['file.downloadDialog.tip']}

@@ -182,6 +183,6 @@ #{bundle['acceptTerms']} - +
\ No newline at end of file diff --git a/src/main/webapp/file-request-access-popup-fragment.xhtml b/src/main/webapp/file-request-access-popup-fragment.xhtml index 573b22fee8b..ef405e01999 100644 --- a/src/main/webapp/file-request-access-popup-fragment.xhtml +++ b/src/main/webapp/file-request-access-popup-fragment.xhtml @@ -46,6 +46,6 @@ update="@([id$=requestAccessPopupButton])" oncomplete="PF('requestAccessPopup').hide();"> #{bundle['acceptTerms']} - + diff --git a/src/main/webapp/file.xhtml b/src/main/webapp/file.xhtml index 26e0f766117..d4ed80cc957 100644 --- a/src/main/webapp/file.xhtml +++ b/src/main/webapp/file.xhtml @@ -544,15 +544,15 @@ - +

#{bundle['file.deleteFileDialog.immediate']}

#{bundle['file.deleteFileDialog.failed.tip']}

- - +
@@ -584,8 +584,8 @@ - + @@ -597,7 +597,7 @@ - +

  @@ -644,8 +644,8 @@

- - + +
@@ -668,7 +668,7 @@
- +

#{bundle['file.compute.fileAccessDenied']}

diff --git a/src/main/webapp/harvestclients.xhtml b/src/main/webapp/harvestclients.xhtml index 18a65f87b8f..86c527682e5 100644 --- a/src/main/webapp/harvestclients.xhtml +++ b/src/main/webapp/harvestclients.xhtml @@ -165,8 +165,8 @@

- - + +
@@ -174,8 +174,8 @@ + -

@@ -287,9 +287,9 @@ #{bundle.next} @@ -374,7 +374,7 @@ #{bundle.next} -
@@ -469,7 +469,7 @@ action="#{harvestingClientsPage.goToStepFour()}"> #{bundle.next} - @@ -550,7 +550,7 @@ update="newHarvestingClientDialogContent :messagePanel :harvestingClientsForm clientsTable emptyClientsTable" actionListener="#{harvestingClientsPage.saveClient}" oncomplete="if (args && !args.validationFailed) PF('newHarvestingClientForm').hide(); else PF('newHarvestingClientForm').show();bind_bsui_components();"/> - + diff --git a/src/main/webapp/harvestsets.xhtml b/src/main/webapp/harvestsets.xhtml index 12c539b12b5..bf9db5f06b9 100644 --- a/src/main/webapp/harvestsets.xhtml +++ b/src/main/webapp/harvestsets.xhtml @@ -184,8 +184,8 @@

- - + +
@@ -251,8 +251,8 @@ #{bundle.next} @@ -318,7 +318,7 @@ update="newOAISetDialogContent :messagePanel :harvestingSetsForm setsTable emptySetsTable" actionListener="#{harvestingSetsPage.saveSet}" oncomplete="if (args && !args.validationFailed) PF('newOAISetForm').hide(); else PF('newOAISetForm').show();bind_bsui_components();"/> - + diff --git a/src/main/webapp/manage-groups.xhtml b/src/main/webapp/manage-groups.xhtml index adf5eebc4c8..ca2ec0cd4e9 100644 --- a/src/main/webapp/manage-groups.xhtml +++ b/src/main/webapp/manage-groups.xhtml @@ -87,16 +87,17 @@ - +

#{bundle['dataverse.manageGroups.tab.action.btn.delete.dialog.tip']}

- - + +
+
diff --git a/src/main/webapp/manage-guestbooks.xhtml b/src/main/webapp/manage-guestbooks.xhtml index 8146b920978..51eae85b71b 100644 --- a/src/main/webapp/manage-guestbooks.xhtml +++ b/src/main/webapp/manage-guestbooks.xhtml @@ -145,13 +145,13 @@
- +

#{bundle['dataset.manageGuestbooks.tab.action.btn.delete.dialog.tip']}

- - + +
@@ -220,7 +220,7 @@
- +
diff --git a/src/main/webapp/manage-templates.xhtml b/src/main/webapp/manage-templates.xhtml index dbbfd31daee..62538d5f532 100644 --- a/src/main/webapp/manage-templates.xhtml +++ b/src/main/webapp/manage-templates.xhtml @@ -141,9 +141,10 @@ - +

-   +  

@@ -158,8 +159,8 @@

- - + +
@@ -184,7 +185,7 @@
- +
diff --git a/src/main/webapp/permissions-configure.xhtml b/src/main/webapp/permissions-configure.xhtml index 3e8f55ba0a6..60bba91f60e 100644 --- a/src/main/webapp/permissions-configure.xhtml +++ b/src/main/webapp/permissions-configure.xhtml @@ -6,6 +6,7 @@ xmlns:p="http://primefaces.org/ui" xmlns:o="http://omnifaces.org/ui"> +
- +

@@ -236,11 +236,12 @@ - +

- + +
@@ -335,21 +336,21 @@ - +
- +

- #{bundle['dataverse.permissionsFiles.viewRemoveDialog.removeBtn.confirmation']} + #{bundle['dataverse.permissionsFiles.viewRemoveDialog.removeBtn.confirmation']}

- - +
diff --git a/src/main/webapp/permissions-manage.xhtml b/src/main/webapp/permissions-manage.xhtml index b912f457ae1..e65380f5aaf 100644 --- a/src/main/webapp/permissions-manage.xhtml +++ b/src/main/webapp/permissions-manage.xhtml @@ -208,7 +208,7 @@ update=":#{p:resolveClientId('rolesPermissionsForm:configureSettings', view)} @([id$=assignedRoles]) assignedRoles @([id$=Messages])" actionListener="#{managePermissionsPage.saveConfiguration}" oncomplete="PF('accessForm').hide()"/> - +
@@ -217,7 +217,7 @@ - +

#{bundle['dataverse.permissions.usersOrGroups.removeBtn.confirmation']}

@@ -225,7 +225,7 @@ - +
diff --git a/src/main/webapp/roles-assign.xhtml b/src/main/webapp/roles-assign.xhtml index 078c8be747d..435878064c0 100644 --- a/src/main/webapp/roles-assign.xhtml +++ b/src/main/webapp/roles-assign.xhtml @@ -6,6 +6,7 @@ xmlns:jsf="http://xmlns.jcp.org/jsf" xmlns:iqbs="http://xmlns.jcp.org/jsf/composite/iqbs"> +
@@ -50,7 +51,7 @@ #{bundle['dataverse.permissions.usersOrGroups.tabHeader.role']}
-
+
-
+

#{bundle['dataverse.permissions.usersOrGroups.assignDialog.role.description']}

@@ -75,8 +76,8 @@

- - + + @@ -96,7 +97,7 @@ oncomplete="if (args && !args.validationFailed) PF('userGroupsForm').hide();"> - +

@@ -111,7 +112,7 @@ - +
diff --git a/src/main/webapp/roles-edit.xhtml b/src/main/webapp/roles-edit.xhtml index 4f02e163ae6..358943842f9 100644 --- a/src/main/webapp/roles-edit.xhtml +++ b/src/main/webapp/roles-edit.xhtml @@ -6,47 +6,44 @@ +
-
-