diff --git a/src/main/java/edu/harvard/iq/dataverse/DatasetVersion.java b/src/main/java/edu/harvard/iq/dataverse/DatasetVersion.java index 73b4723de53..faa91b87e12 100644 --- a/src/main/java/edu/harvard/iq/dataverse/DatasetVersion.java +++ b/src/main/java/edu/harvard/iq/dataverse/DatasetVersion.java @@ -1686,7 +1686,7 @@ public Set validate() { Set> constraintViolations = validator.validate(toua); if (constraintViolations.size() > 0) { ConstraintViolation violation = constraintViolations.iterator().next(); - String message = BundleUtil.getStringFromBundle("toua.invalid"); + String message = BundleUtil.getStringFromBundle("dataset.message.toua.invalid"); logger.info(message); this.termsOfUseAndAccess.setValidationMessage(message); returnSet.add(violation); diff --git a/src/main/java/edu/harvard/iq/dataverse/TemplatePage.java b/src/main/java/edu/harvard/iq/dataverse/TemplatePage.java index b04136bb5a1..331ecbf24f8 100644 --- a/src/main/java/edu/harvard/iq/dataverse/TemplatePage.java +++ b/src/main/java/edu/harvard/iq/dataverse/TemplatePage.java @@ -129,6 +129,7 @@ public String init() { if (template.getTermsOfUseAndAccess() != null) { TermsOfUseAndAccess terms = template.getTermsOfUseAndAccess().copyTermsOfUseAndAccess(); + terms.setTemplate(template); template.setTermsOfUseAndAccess(terms); } diff --git a/src/main/java/edu/harvard/iq/dataverse/TermsOfUseAndAccessValidator.java b/src/main/java/edu/harvard/iq/dataverse/TermsOfUseAndAccessValidator.java index ee094d772e2..2cf78db0f03 100644 --- a/src/main/java/edu/harvard/iq/dataverse/TermsOfUseAndAccessValidator.java +++ b/src/main/java/edu/harvard/iq/dataverse/TermsOfUseAndAccessValidator.java @@ -28,7 +28,13 @@ public boolean isValid(TermsOfUseAndAccess value, ConstraintValidatorContext con } public static boolean isTOUAValid(TermsOfUseAndAccess value, ConstraintValidatorContext context){ - //If there are no restricted files then terms are valid + + //if part of a template it is valid + if (value.getTemplate() != null){ + return true; + } + + //If there are no restricted files then terms are valid if (!value.getDatasetVersion().isHasRestrictedFile()) { return true; } @@ -39,10 +45,10 @@ public static boolean isTOUAValid(TermsOfUseAndAccess value, ConstraintValidator if (!valid) { try { if (context != null) { - context.buildConstraintViolationWithTemplate(BundleUtil.getStringFromBundle("toua.invalid")).addConstraintViolation(); + context.buildConstraintViolationWithTemplate(BundleUtil.getStringFromBundle("dataset.message.toua.invalid")).addConstraintViolation(); } - value.setValidationMessage(BundleUtil.getStringFromBundle("toua.invalid")); + value.setValidationMessage(BundleUtil.getStringFromBundle("dataset.message.toua.invalid")); } catch (NullPointerException e) { return false; } diff --git a/src/main/java/propertyFiles/Bundle.properties b/src/main/java/propertyFiles/Bundle.properties index 31a58ae65b1..89f3760909b 100644 --- a/src/main/java/propertyFiles/Bundle.properties +++ b/src/main/java/propertyFiles/Bundle.properties @@ -1475,6 +1475,7 @@ dataset.message.editMetadata.label=Edit Dataset Metadata dataset.message.editMetadata.message=Add more metadata about this dataset to help others easily find it. dataset.message.editMetadata.duplicateFilenames=Duplicate filenames: {0} dataset.message.editMetadata.invalid.TOUA.message=Datasets with restricted files are required to have Request Access enabled or Terms of Access to help people access the data. Please edit the dataset to confirm Request Access or provide Terms of Access to be in compliance with the policy. +dataset.message.toua.invalid=You must enable request access or add terms of access in datasets with restricted files. dataset.message.editTerms.label=Edit Dataset Terms dataset.message.editTerms.message=Add the terms of use for this dataset to explain how to access and use your data. diff --git a/src/main/webapp/dataset-license-terms.xhtml b/src/main/webapp/dataset-license-terms.xhtml index a5930ccf35f..9d381f54dd5 100644 --- a/src/main/webapp/dataset-license-terms.xhtml +++ b/src/main/webapp/dataset-license-terms.xhtml @@ -11,7 +11,7 @@ jsf:rendered="#{dataverseSession.user.authenticated and empty editMode and !widgetWrapper.widgetView and permissionsWrapper.canIssueUpdateDatasetCommand(DatasetPage.dataset)}"> + update="@form,:messagePanel" disabled="#{DatasetPage.lockedFromEdits}"> #{bundle['file.dataFilesTab.terms.editTermsBtn']} @@ -50,7 +50,7 @@ - + @@ -296,7 +296,7 @@
- +

@@ -325,13 +325,13 @@

- + value="#{termsOfUseAndAccess.fileAccessRequest}" disabled="#{datasetPage == true and !DatasetPage.isHasRestrictedFiles()}"> +
-
+
#{bundle['file.dataFilesTab.terms.list.termsOfAccess.requestAccess.warning.outofcompliance']}
@@ -342,9 +342,9 @@ data-toggle="tooltip" data-placement="auto right" data-original-title="#{bundle['file.dataFilesTab.terms.list.termsOfAccess.termsOfsAccess.title']}">
- - - + +
@@ -530,7 +530,7 @@ + update=":datasetForm" oncomplete="PF('viewGuestbook').show();"/>
@@ -569,7 +569,7 @@ + update=":datasetForm" oncomplete="PF('viewGuestbook').show();"/> diff --git a/src/main/webapp/dataverse.xhtml b/src/main/webapp/dataverse.xhtml index e7bfb49cd96..572bcf40300 100644 --- a/src/main/webapp/dataverse.xhtml +++ b/src/main/webapp/dataverse.xhtml @@ -97,8 +97,7 @@ style="display:none" process="@this :dataverseForm:selectHostDataverse" update=":dataverseForm,:breadCrumbPanel" - action="#{DataversePage.updateOwnerDataverse()}" - oncomplete="bind_bsui_components();"> + action="#{DataversePage.updateOwnerDataverse()}"> @@ -221,15 +220,13 @@
+ actionListener="#{DataversePage.dataverse.addDataverseContact(valCount.index + 1)}"> + actionListener="#{DataversePage.dataverse.removeDataverseContact(valCount.index)}"> @@ -323,16 +320,14 @@ update="@widgetVar(optionBlock)" process="@this" rendered="#{!mdb.showDatasetFieldTypes and (mdb.selected or mdb.required) and !DataversePage.openMetadataBlock and !DataversePage.inheritMetadataBlockFromParent}" - actionListener="#{DataversePage.showDatasetFieldTypes(mdb.id)}" - oncomplete="javascript:bind_bsui_components();"> + actionListener="#{DataversePage.showDatasetFieldTypes(mdb.id)}"> + actionListener="#{DataversePage.showDatasetFieldTypes(mdb.id, false)}"> @@ -374,7 +369,6 @@ @@ -532,7 +526,7 @@
  • - +
  • diff --git a/src/main/webapp/dataverseuser.xhtml b/src/main/webapp/dataverseuser.xhtml index cb922a0164d..f02acf6ce25 100644 --- a/src/main/webapp/dataverseuser.xhtml +++ b/src/main/webapp/dataverseuser.xhtml @@ -54,7 +54,7 @@ - + @@ -369,8 +369,7 @@
    + action="#{DataverseUserPage.remove(item.id)}" update="@form">
    @@ -394,13 +393,13 @@
  • + actionListener="#{DataverseUserPage.edit}" update="@form">
  • + actionListener="#{DataverseUserPage.changePassword}" update="@form">
  • diff --git a/src/main/webapp/editFilesFragment.xhtml b/src/main/webapp/editFilesFragment.xhtml index e281f406bc7..b7c2943c3e2 100644 --- a/src/main/webapp/editFilesFragment.xhtml +++ b/src/main/webapp/editFilesFragment.xhtml @@ -148,7 +148,7 @@ process="filesTable" update=":datasetForm:filesTable, @([id$=filesButtons])" label="#{bundle['file.selectToAddBtn']}" - oncomplete="javascript:bind_bsui_components();uploadFinished(PF('fileUploadWidget'));" + oncomplete="uploadFinished(PF('fileUploadWidget'));" onstart="javascript:uploadWidgetDropRemoveMsg();uploadStarted();" onerror="javascript:uploadFailure();" sizeLimit="#{EditDatafilesPage.getMaxFileUploadSizeInBytes()}" @@ -298,9 +298,9 @@