From 75ef1ac82807061176dcfd5f1ab8caa6313f8650 Mon Sep 17 00:00:00 2001 From: Ryan Williams Date: Tue, 4 Mar 2025 21:58:40 +0000 Subject: [PATCH 01/10] init new feature request template per @m-i-k-e's suggestion --- .github/ISSUE_TEMPLATE/feature_idea.yml | 80 +++++++++---------------- 1 file changed, 29 insertions(+), 51 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/feature_idea.yml b/.github/ISSUE_TEMPLATE/feature_idea.yml index 956ceb95f..d440768de 100644 --- a/.github/ISSUE_TEMPLATE/feature_idea.yml +++ b/.github/ISSUE_TEMPLATE/feature_idea.yml @@ -1,77 +1,55 @@ name: 💡 Feature idea -description: Idea or request for some feature on the GovTool roadmap +description: Suggest a new feature or enhancement for GovTool. title: "💡 " -labels: ["💡 Feature idea"] +labels: ["💡 Feature idea", "Needs UX Review"] projects: ["IntersectMBO/30", "IntersectMBO/34"] body: - type: markdown attributes: value: | ## 🌟 **Thank you for contributing to GovTool!** + - type: markdown attributes: - value: | - Before submitting a new issue consider [starting a new discussion](https://github.com/IntersectMBO/govtool/discussions/new?category=ideas). - - - type: dropdown - id: area - attributes: - label: Area - description: What part of GovTool does this feature affect? - options: - - Proposal Pillar - - Voting Pillar - - Delegation Pillar - - Wrapper - - Other - - Not sure - validations: - required: true - - - type: dropdown - id: design-needed + value: + Please fill out the following details. + + - type: textarea + id: problem-statement attributes: - label: Is there new design needed? - description: Will this feature require new or edit to existing frontend designs? - options: - - 'Yes' - - 'No' - - Not sure + label: "💡 Suggestion or feature" + description: "Please describe the user need, idea, or pain point." + placeholder: "Example: Users would benefit from having X functionality, so they can do Y..." validations: required: true - + - type: textarea - id: what + id: user-impact attributes: - label: What? - description: What is this feature? - placeholder: | - For example describe a new API endpoint, a change in wording, - a new configuration option, ... + label: "Who does this help?" + description: "Which users will benefit from this feature? How does it improve their experience?" + placeholder: "Example: This feature will help first-time users onboard faster..." validations: required: true - + - type: textarea - id: why + id: dependencies attributes: - label: Why? - description: Why do we need or want this feature? - placeholder: | - Give context and describe the problem the idea solves + label: "How might we do this?" + description: "Suggestions on implementation" + placeholder: "Example: Add a button that says GO to the home page" validations: - required: true - + required: false + - type: textarea - id: how + id: other-info attributes: - label: How? - description: How can we realize this feature? - placeholder: | - Which technical solutions, libraries or systems should be used, which - components need to change, steps how to implement this, ... + label: "Anything else you might want to add?" + description: "Free text box for any comments" + placeholder: "I love GovTool, and so does my dog!" validations: - required: true - + required: false + - type: markdown attributes: value: | From d5f5d54c99b8def931f5a412e7d03cc30fea043b Mon Sep 17 00:00:00 2001 From: Niraj Date: Wed, 2 Apr 2025 15:40:52 +0545 Subject: [PATCH 02/10] fix: test 8E due to mock data --- .../proposalDiscussion.spec.ts | 44 +++++++++++-------- 1 file changed, 26 insertions(+), 18 deletions(-) diff --git a/tests/govtool-frontend/playwright/tests/8-proposal-discussion/proposalDiscussion.spec.ts b/tests/govtool-frontend/playwright/tests/8-proposal-discussion/proposalDiscussion.spec.ts index 769405e84..84d6b408e 100644 --- a/tests/govtool-frontend/playwright/tests/8-proposal-discussion/proposalDiscussion.spec.ts +++ b/tests/govtool-frontend/playwright/tests/8-proposal-discussion/proposalDiscussion.spec.ts @@ -8,6 +8,7 @@ import { test } from "@fixtures/proposal"; import { setAllureEpic } from "@helpers/allure"; import { isBootStrapingPhase, skipIfNotHardFork } from "@helpers/cardano"; import { injectLogger } from "@helpers/page"; +import { extractProposalIdFromUrl } from "@helpers/string"; import { functionWaitedAssert } from "@helpers/waitedLoop"; import ProposalDiscussionDetailsPage from "@pages/proposalDiscussionDetailsPage"; import ProposalDiscussionPage from "@pages/proposalDiscussionPage"; @@ -195,6 +196,31 @@ test("8S. Should restrict proposal creation on disconnected state", async ({ await expect(proposalDiscussionPage.proposalCreateBtn).not.toBeVisible(); }); +test("8E. Should share proposed governance action", async ({ + page, + context, +}) => { + await context.grantPermissions(["clipboard-read", "clipboard-write"]); + const proposalDiscussionPage = new ProposalDiscussionPage(page); + await proposalDiscussionPage.goto(); + + await proposalDiscussionPage.viewFirstProposal(); + + const currentPageUrl = page.url(); + const proposalId = extractProposalIdFromUrl(currentPageUrl); + + await page.getByTestId("share-button").click(); + await page.getByTestId("copy-link").click(); + await expect(page.getByTestId("copy-link-text")).toBeVisible(); + + const copiedTextDRepDirectory = await page.evaluate(() => + navigator.clipboard.readText() + ); + const expectedCopyUrl = `${environments.frontendUrl}/proposal_discussion/${proposalId}`; + + expect(copiedTextDRepDirectory).toEqual(expectedCopyUrl); +}); + test.describe("Mocked proposal", () => { let proposalDiscussionDetailsPage: ProposalDiscussionDetailsPage; @@ -221,24 +247,6 @@ test.describe("Mocked proposal", () => { await proposalDiscussionDetailsPage.goto(mockProposal.data.id); }); - test("8E. Should share proposed governance action", async ({ - page, - context, - }) => { - await context.grantPermissions(["clipboard-read", "clipboard-write"]); - - await page.getByTestId("share-button").click(); - await page.getByTestId("copy-link").click(); - await expect(page.getByTestId("copy-link-text")).toBeVisible(); - - const copiedTextDRepDirectory = await page.evaluate(() => - navigator.clipboard.readText() - ); - const expectedCopyUrl = `${environments.frontendUrl}/proposal_discussion/${mockProposal.data.id}`; - - expect(copiedTextDRepDirectory).toEqual(expectedCopyUrl); - }); - test("8I. Should disable poll voting functionality.", async () => { await expect(proposalDiscussionDetailsPage.pollVoteCard).not.toBeVisible(); await expect(proposalDiscussionDetailsPage.pollYesBtn).not.toBeVisible(); From 1420843854cd1d3aa58e746d2089639b36474e9d Mon Sep 17 00:00:00 2001 From: Niraj Date: Wed, 2 Apr 2025 16:00:51 +0545 Subject: [PATCH 03/10] fix: update mock proposal comments to include bd_proposal_id and comments_reports --- .../playwright/lib/_mock/proposalComments.json | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tests/govtool-frontend/playwright/lib/_mock/proposalComments.json b/tests/govtool-frontend/playwright/lib/_mock/proposalComments.json index 12f0415e2..1334244a6 100644 --- a/tests/govtool-frontend/playwright/lib/_mock/proposalComments.json +++ b/tests/govtool-frontend/playwright/lib/_mock/proposalComments.json @@ -9,6 +9,10 @@ "comment_text": "Hello", "createdAt": "2024-06-14T13:38:35.830Z", "updatedAt": "2024-06-14T13:38:35.830Z", + "bd_proposal_id": null, + "comments_reports": { + "data": [] + }, "user_govtool_username": "Anonymous", "subcommens_number": 0 } @@ -22,6 +26,10 @@ "comment_text": "Nice proposal", "createdAt": "2024-06-14T13:38:31.279Z", "updatedAt": "2024-06-14T13:38:31.279Z", + "bd_proposal_id": null, + "comments_reports": { + "data": [] + }, "user_govtool_username": "Anonymous", "subcommens_number": 0 } @@ -35,6 +43,10 @@ "comment_text": "Go Ahead", "createdAt": "2024-06-14T13:38:27.286Z", "updatedAt": "2024-06-14T13:38:27.286Z", + "bd_proposal_id": null, + "comments_reports": { + "data": [] + }, "user_govtool_username": "Anonymous", "subcommens_number": 0 } From d4afa4decd9732a4c550f53f85339fabac4da590 Mon Sep 17 00:00:00 2001 From: Niraj Date: Wed, 2 Apr 2025 16:02:04 +0545 Subject: [PATCH 04/10] chore: format mock comments --- .../playwright/lib/_mock/proposalComments.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/govtool-frontend/playwright/lib/_mock/proposalComments.json b/tests/govtool-frontend/playwright/lib/_mock/proposalComments.json index 1334244a6..8fb83e3e2 100644 --- a/tests/govtool-frontend/playwright/lib/_mock/proposalComments.json +++ b/tests/govtool-frontend/playwright/lib/_mock/proposalComments.json @@ -11,7 +11,7 @@ "updatedAt": "2024-06-14T13:38:35.830Z", "bd_proposal_id": null, "comments_reports": { - "data": [] + "data": [] }, "user_govtool_username": "Anonymous", "subcommens_number": 0 @@ -28,7 +28,7 @@ "updatedAt": "2024-06-14T13:38:31.279Z", "bd_proposal_id": null, "comments_reports": { - "data": [] + "data": [] }, "user_govtool_username": "Anonymous", "subcommens_number": 0 @@ -45,7 +45,7 @@ "updatedAt": "2024-06-14T13:38:27.286Z", "bd_proposal_id": null, "comments_reports": { - "data": [] + "data": [] }, "user_govtool_username": "Anonymous", "subcommens_number": 0 From 0a27d049006d6b835b4f2c5b8830d856e69dcd29 Mon Sep 17 00:00:00 2001 From: Niraj Date: Thu, 3 Apr 2025 10:04:33 +0545 Subject: [PATCH 05/10] fix: update proposal submission test to use exact text match for proposals --- .../7-proposal-submission/proposalSubmission.loggedin.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/govtool-frontend/playwright/tests/7-proposal-submission/proposalSubmission.loggedin.spec.ts b/tests/govtool-frontend/playwright/tests/7-proposal-submission/proposalSubmission.loggedin.spec.ts index 29aad363e..41fd994dc 100644 --- a/tests/govtool-frontend/playwright/tests/7-proposal-submission/proposalSubmission.loggedin.spec.ts +++ b/tests/govtool-frontend/playwright/tests/7-proposal-submission/proposalSubmission.loggedin.spec.ts @@ -33,7 +33,7 @@ test.describe("Proposal created logged state", () => { await page.goto("/"); await page.getByTestId("proposal-discussion-link").click(); - await expect(page.getByText(/proposals/i)).toHaveCount(2); + await expect(page.getByText("Proposals", { exact: true })).toHaveCount(2); }); test.describe("Accept valid data", () => { From a227568f9cdbc00eb247125e0377f3a346d6bd30 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu, 3 Apr 2025 11:57:58 +0000 Subject: [PATCH 06/10] chore: update @intersect.mbo/pdf-ui to 0.7.0-beta-10 --- govtool/frontend/package-lock.json | 8 ++++---- govtool/frontend/package.json | 2 +- govtool/frontend/yarn.lock | 8 ++++---- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/govtool/frontend/package-lock.json b/govtool/frontend/package-lock.json index ab58512a4..1fc412cb6 100644 --- a/govtool/frontend/package-lock.json +++ b/govtool/frontend/package-lock.json @@ -15,7 +15,7 @@ "@hookform/resolvers": "^3.3.1", "@intersect.mbo/govtool-outcomes-pillar-ui": "1.3.0", "@intersect.mbo/intersectmbo.org-icons-set": "^1.0.8", - "@intersect.mbo/pdf-ui": "0.7.0-beta-8", + "@intersect.mbo/pdf-ui": "0.7.0-beta-10", "@mui/icons-material": "^5.14.3", "@mui/material": "^5.14.4", "@rollup/plugin-babel": "^6.0.4", @@ -3423,9 +3423,9 @@ "license": "ISC" }, "node_modules/@intersect.mbo/pdf-ui": { - "version": "0.7.0-beta-8", - "resolved": "https://registry.npmjs.org/@intersect.mbo/pdf-ui/-/pdf-ui-0.7.0-beta-8.tgz", - "integrity": "sha512-xBd8rl2qC+T5/rHAkDYdD63FoZi84E3LoiVkUZceRzlUcu3/6Ycia8BOzMszS+S9eLPHzYHO6HXy9dOqTObysg==", + "version": "0.7.0-beta-10", + "resolved": "https://registry.npmjs.org/@intersect.mbo/pdf-ui/-/pdf-ui-0.7.0-beta-10.tgz", + "integrity": "sha512-UWPQwNYdAFPte2zUXILhYYqoFCaai9X7EOF5AHafVPfOYBCieaK2EVgzx2XYUr8UukuHHouonlA+PPdOY1DGaQ==", "dependencies": { "@emurgo/cardano-serialization-lib-asmjs": "^12.0.0-beta.2", "@fontsource/poppins": "^5.0.14", diff --git a/govtool/frontend/package.json b/govtool/frontend/package.json index b6b1cb7da..7d7e27503 100644 --- a/govtool/frontend/package.json +++ b/govtool/frontend/package.json @@ -29,7 +29,7 @@ "@hookform/resolvers": "^3.3.1", "@intersect.mbo/govtool-outcomes-pillar-ui": "1.3.0", "@intersect.mbo/intersectmbo.org-icons-set": "^1.0.8", - "@intersect.mbo/pdf-ui": "0.7.0-beta-8", + "@intersect.mbo/pdf-ui": "0.7.0-beta-10", "@mui/icons-material": "^5.14.3", "@mui/material": "^5.14.4", "@rollup/plugin-babel": "^6.0.4", diff --git a/govtool/frontend/yarn.lock b/govtool/frontend/yarn.lock index 7474a7038..1cf6dd5d2 100644 --- a/govtool/frontend/yarn.lock +++ b/govtool/frontend/yarn.lock @@ -1512,10 +1512,10 @@ resolved "https://registry.npmjs.org/@intersect.mbo/intersectmbo.org-icons-set/-/intersectmbo.org-icons-set-1.1.0.tgz" integrity sha512-sjKEtnK9eLYH/8kCD0YRQCms3byFA/tnSsei9NHTZbBYX9sBpeX6ErfR0sKYjOSxQOxl4FumX9D0X+vHIqxo8g== -"@intersect.mbo/pdf-ui@0.7.0-beta-8": - version "0.7.0-beta-8" - resolved "https://registry.npmjs.org/@intersect.mbo/pdf-ui/-/pdf-ui-0.7.0-beta-8.tgz" - integrity sha512-xBd8rl2qC+T5/rHAkDYdD63FoZi84E3LoiVkUZceRzlUcu3/6Ycia8BOzMszS+S9eLPHzYHO6HXy9dOqTObysg== +"@intersect.mbo/pdf-ui@0.7.0-beta-10": + version "0.7.0-beta-10" + resolved "https://registry.npmjs.org/@intersect.mbo/pdf-ui/-/pdf-ui-0.7.0-beta-10.tgz" + integrity sha512-UWPQwNYdAFPte2zUXILhYYqoFCaai9X7EOF5AHafVPfOYBCieaK2EVgzx2XYUr8UukuHHouonlA+PPdOY1DGaQ== dependencies: "@emurgo/cardano-serialization-lib-asmjs" "^12.0.0-beta.2" "@fontsource/poppins" "^5.0.14" From 4e6abcbd0ab315b0eacfb7cc1a79b139ccb625c2 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu, 3 Apr 2025 13:17:38 +0000 Subject: [PATCH 07/10] chore: update @intersect.mbo/pdf-ui to 0.7.0-beta-11 --- govtool/frontend/package-lock.json | 8 ++++---- govtool/frontend/package.json | 2 +- govtool/frontend/yarn.lock | 8 ++++---- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/govtool/frontend/package-lock.json b/govtool/frontend/package-lock.json index 1fc412cb6..aacb7a78e 100644 --- a/govtool/frontend/package-lock.json +++ b/govtool/frontend/package-lock.json @@ -15,7 +15,7 @@ "@hookform/resolvers": "^3.3.1", "@intersect.mbo/govtool-outcomes-pillar-ui": "1.3.0", "@intersect.mbo/intersectmbo.org-icons-set": "^1.0.8", - "@intersect.mbo/pdf-ui": "0.7.0-beta-10", + "@intersect.mbo/pdf-ui": "0.7.0-beta-11", "@mui/icons-material": "^5.14.3", "@mui/material": "^5.14.4", "@rollup/plugin-babel": "^6.0.4", @@ -3423,9 +3423,9 @@ "license": "ISC" }, "node_modules/@intersect.mbo/pdf-ui": { - "version": "0.7.0-beta-10", - "resolved": "https://registry.npmjs.org/@intersect.mbo/pdf-ui/-/pdf-ui-0.7.0-beta-10.tgz", - "integrity": "sha512-UWPQwNYdAFPte2zUXILhYYqoFCaai9X7EOF5AHafVPfOYBCieaK2EVgzx2XYUr8UukuHHouonlA+PPdOY1DGaQ==", + "version": "0.7.0-beta-11", + "resolved": "https://registry.npmjs.org/@intersect.mbo/pdf-ui/-/pdf-ui-0.7.0-beta-11.tgz", + "integrity": "sha512-amFT8stsOFMeFZjoTsCpUguUi2d/tlMZ4G/ARud1ewrRfjDvu6PJhGYlGl2gZBGa75GgvNM27hfEbzv7MDOInA==", "dependencies": { "@emurgo/cardano-serialization-lib-asmjs": "^12.0.0-beta.2", "@fontsource/poppins": "^5.0.14", diff --git a/govtool/frontend/package.json b/govtool/frontend/package.json index 7d7e27503..0a39a2d85 100644 --- a/govtool/frontend/package.json +++ b/govtool/frontend/package.json @@ -29,7 +29,7 @@ "@hookform/resolvers": "^3.3.1", "@intersect.mbo/govtool-outcomes-pillar-ui": "1.3.0", "@intersect.mbo/intersectmbo.org-icons-set": "^1.0.8", - "@intersect.mbo/pdf-ui": "0.7.0-beta-10", + "@intersect.mbo/pdf-ui": "0.7.0-beta-11", "@mui/icons-material": "^5.14.3", "@mui/material": "^5.14.4", "@rollup/plugin-babel": "^6.0.4", diff --git a/govtool/frontend/yarn.lock b/govtool/frontend/yarn.lock index 1cf6dd5d2..5af6913b4 100644 --- a/govtool/frontend/yarn.lock +++ b/govtool/frontend/yarn.lock @@ -1512,10 +1512,10 @@ resolved "https://registry.npmjs.org/@intersect.mbo/intersectmbo.org-icons-set/-/intersectmbo.org-icons-set-1.1.0.tgz" integrity sha512-sjKEtnK9eLYH/8kCD0YRQCms3byFA/tnSsei9NHTZbBYX9sBpeX6ErfR0sKYjOSxQOxl4FumX9D0X+vHIqxo8g== -"@intersect.mbo/pdf-ui@0.7.0-beta-10": - version "0.7.0-beta-10" - resolved "https://registry.npmjs.org/@intersect.mbo/pdf-ui/-/pdf-ui-0.7.0-beta-10.tgz" - integrity sha512-UWPQwNYdAFPte2zUXILhYYqoFCaai9X7EOF5AHafVPfOYBCieaK2EVgzx2XYUr8UukuHHouonlA+PPdOY1DGaQ== +"@intersect.mbo/pdf-ui@0.7.0-beta-11": + version "0.7.0-beta-11" + resolved "https://registry.npmjs.org/@intersect.mbo/pdf-ui/-/pdf-ui-0.7.0-beta-11.tgz" + integrity sha512-amFT8stsOFMeFZjoTsCpUguUi2d/tlMZ4G/ARud1ewrRfjDvu6PJhGYlGl2gZBGa75GgvNM27hfEbzv7MDOInA== dependencies: "@emurgo/cardano-serialization-lib-asmjs" "^12.0.0-beta.2" "@fontsource/poppins" "^5.0.14" From 728e6e5ed65bd179c7c71c50f6f7a6cd5c53f837 Mon Sep 17 00:00:00 2001 From: Ryan Williams Date: Thu, 3 Apr 2025 14:28:25 +0100 Subject: [PATCH 08/10] add back original template --- .github/ISSUE_TEMPLATE/feature_idea.yml | 82 ++++++++++++++--------- .github/ISSUE_TEMPLATE/feature_idea_2.yml | 66 ++++++++++++++++++ 2 files changed, 118 insertions(+), 30 deletions(-) create mode 100644 .github/ISSUE_TEMPLATE/feature_idea_2.yml diff --git a/.github/ISSUE_TEMPLATE/feature_idea.yml b/.github/ISSUE_TEMPLATE/feature_idea.yml index d440768de..8a744a07f 100644 --- a/.github/ISSUE_TEMPLATE/feature_idea.yml +++ b/.github/ISSUE_TEMPLATE/feature_idea.yml @@ -1,55 +1,77 @@ name: 💡 Feature idea -description: Suggest a new feature or enhancement for GovTool. +description: Idea or request for some feature on the GovTool roadmap title: "💡 " -labels: ["💡 Feature idea", "Needs UX Review"] +labels: ["💡 Feature idea"] projects: ["IntersectMBO/30", "IntersectMBO/34"] body: - type: markdown attributes: value: | ## 🌟 **Thank you for contributing to GovTool!** - - type: markdown attributes: - value: - Please fill out the following details. - - - type: textarea - id: problem-statement + value: | + Before submitting a new issue consider [starting a new discussion](https://github.com/IntersectMBO/govtool/discussions/new?category=ideas). + + - type: dropdown + id: area + attributes: + label: Area + description: What part of GovTool does this feature affect? + options: + - Proposal Pillar + - Voting Pillar + - Delegation Pillar + - Wrapper + - Other + - Not sure + validations: + required: true + + - type: dropdown + id: design-needed attributes: - label: "💡 Suggestion or feature" - description: "Please describe the user need, idea, or pain point." - placeholder: "Example: Users would benefit from having X functionality, so they can do Y..." + label: Is there new design needed? + description: Will this feature require new or edit to existing frontend designs? + options: + - 'Yes' + - 'No' + - Not sure validations: required: true - + - type: textarea - id: user-impact + id: what attributes: - label: "Who does this help?" - description: "Which users will benefit from this feature? How does it improve their experience?" - placeholder: "Example: This feature will help first-time users onboard faster..." + label: What? + description: What is this feature? + placeholder: | + For example describe a new API endpoint, a change in wording, + a new configuration option, ... validations: required: true - + - type: textarea - id: dependencies + id: why attributes: - label: "How might we do this?" - description: "Suggestions on implementation" - placeholder: "Example: Add a button that says GO to the home page" + label: Why? + description: Why do we need or want this feature? + placeholder: | + Give context and describe the problem the idea solves validations: - required: false - + required: true + - type: textarea - id: other-info + id: how attributes: - label: "Anything else you might want to add?" - description: "Free text box for any comments" - placeholder: "I love GovTool, and so does my dog!" + label: How? + description: How can we realize this feature? + placeholder: | + Which technical solutions, libraries or systems should be used, which + components need to change, steps how to implement this, ... validations: - required: false - + required: true + - type: markdown attributes: value: | @@ -63,4 +85,4 @@ body: placeholder: | As a [ada holder | DRep | Direct voter], I want [some goal] so that [some reason]. validations: - required: false \ No newline at end of file + required: false diff --git a/.github/ISSUE_TEMPLATE/feature_idea_2.yml b/.github/ISSUE_TEMPLATE/feature_idea_2.yml new file mode 100644 index 000000000..d440768de --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_idea_2.yml @@ -0,0 +1,66 @@ +name: 💡 Feature idea +description: Suggest a new feature or enhancement for GovTool. +title: "💡 " +labels: ["💡 Feature idea", "Needs UX Review"] +projects: ["IntersectMBO/30", "IntersectMBO/34"] +body: + - type: markdown + attributes: + value: | + ## 🌟 **Thank you for contributing to GovTool!** + + - type: markdown + attributes: + value: + Please fill out the following details. + + - type: textarea + id: problem-statement + attributes: + label: "💡 Suggestion or feature" + description: "Please describe the user need, idea, or pain point." + placeholder: "Example: Users would benefit from having X functionality, so they can do Y..." + validations: + required: true + + - type: textarea + id: user-impact + attributes: + label: "Who does this help?" + description: "Which users will benefit from this feature? How does it improve their experience?" + placeholder: "Example: This feature will help first-time users onboard faster..." + validations: + required: true + + - type: textarea + id: dependencies + attributes: + label: "How might we do this?" + description: "Suggestions on implementation" + placeholder: "Example: Add a button that says GO to the home page" + validations: + required: false + + - type: textarea + id: other-info + attributes: + label: "Anything else you might want to add?" + description: "Free text box for any comments" + placeholder: "I love GovTool, and so does my dog!" + validations: + required: false + + - type: markdown + attributes: + value: | + --- + + - type: textarea + id: user-story + attributes: + label: (Optional) User Story with acceptance criteria + description: See GovTool examples [here](https://github.com/IntersectMBO/cardano-test-plans/blob/main/userStoryInventoryChangHF.md#2g-delegate-to-self-for-registered-dreps). + placeholder: | + As a [ada holder | DRep | Direct voter], I want [some goal] so that [some reason]. + validations: + required: false \ No newline at end of file From e0ad457b29aa3a65e359d68aa6ce68b99e905c38 Mon Sep 17 00:00:00 2001 From: Ryan Williams Date: Thu, 3 Apr 2025 14:29:37 +0100 Subject: [PATCH 09/10] align template --- .github/ISSUE_TEMPLATE/feature_idea_2.yml | 30 ++--------------------- 1 file changed, 2 insertions(+), 28 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/feature_idea_2.yml b/.github/ISSUE_TEMPLATE/feature_idea_2.yml index d440768de..596584fc7 100644 --- a/.github/ISSUE_TEMPLATE/feature_idea_2.yml +++ b/.github/ISSUE_TEMPLATE/feature_idea_2.yml @@ -1,19 +1,11 @@ -name: 💡 Feature idea +name: Feature Suggestion description: Suggest a new feature or enhancement for GovTool. -title: "💡 " -labels: ["💡 Feature idea", "Needs UX Review"] -projects: ["IntersectMBO/30", "IntersectMBO/34"] +labels: ["Feature Request", "Needs UX Review"] body: - - type: markdown - attributes: - value: | - ## 🌟 **Thank you for contributing to GovTool!** - - type: markdown attributes: value: Please fill out the following details. - - type: textarea id: problem-statement attributes: @@ -22,7 +14,6 @@ body: placeholder: "Example: Users would benefit from having X functionality, so they can do Y..." validations: required: true - - type: textarea id: user-impact attributes: @@ -31,7 +22,6 @@ body: placeholder: "Example: This feature will help first-time users onboard faster..." validations: required: true - - type: textarea id: dependencies attributes: @@ -40,27 +30,11 @@ body: placeholder: "Example: Add a button that says GO to the home page" validations: required: false - - type: textarea id: other-info attributes: label: "Anything else you might want to add?" description: "Free text box for any comments" placeholder: "I love GovTool, and so does my dog!" - validations: - required: false - - - type: markdown - attributes: - value: | - --- - - - type: textarea - id: user-story - attributes: - label: (Optional) User Story with acceptance criteria - description: See GovTool examples [here](https://github.com/IntersectMBO/cardano-test-plans/blob/main/userStoryInventoryChangHF.md#2g-delegate-to-self-for-registered-dreps). - placeholder: | - As a [ada holder | DRep | Direct voter], I want [some goal] so that [some reason]. validations: required: false \ No newline at end of file From 560c7b258418dedbbc74424e663a8ed7871b1119 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Sza=C5=82owski?= Date: Thu, 3 Apr 2025 17:12:26 +0200 Subject: [PATCH 10/10] fix: add identifiers to drep voting power query keys --- .../frontend/src/hooks/queries/useGetDRepVotingPowerList.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/govtool/frontend/src/hooks/queries/useGetDRepVotingPowerList.ts b/govtool/frontend/src/hooks/queries/useGetDRepVotingPowerList.ts index 3c40d6ca9..c1c180f8a 100644 --- a/govtool/frontend/src/hooks/queries/useGetDRepVotingPowerList.ts +++ b/govtool/frontend/src/hooks/queries/useGetDRepVotingPowerList.ts @@ -16,9 +16,9 @@ export const useGetDRepVotingPowerList = () => { enabled: false, }); - const fetchDRepVotingPowerList = async (identifiers: string[]) => + const fetchDRepVotingPowerList = async (identifiers: string[] = []) => queryClient.fetchQuery({ - queryKey: [QUERY_KEYS.useGetDRepVotingPowerListKey], + queryKey: [QUERY_KEYS.useGetDRepVotingPowerListKey, ...identifiers], queryFn: () => getDRepVotingPowerList(identifiers), });