diff --git a/CHANGELOG.md b/CHANGELOG.md index 3b16353ba..109302a79 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,8 @@ changes. ### Removed +- Remove additional canonicalization of the metadata [Issue 3591](https://github.com/IntersectMBO/govtool/issues/3591) + ## [v2.0.20](https://github.com/IntersectMBO/govtool/releases/tag/v2.0.20) 2025-04-16 ### Added diff --git a/govtool/metadata-validation/src/app.service.ts b/govtool/metadata-validation/src/app.service.ts index cfb1bb0d0..449a716e9 100644 --- a/govtool/metadata-validation/src/app.service.ts +++ b/govtool/metadata-validation/src/app.service.ts @@ -2,7 +2,6 @@ import { Injectable, Logger } from '@nestjs/common'; import { catchError, finalize, firstValueFrom } from 'rxjs'; import { HttpService } from '@nestjs/axios'; import * as blake from 'blakejs'; -import * as jsonld from 'jsonld'; import { ValidateMetadataDTO } from '@dto'; import { LoggerMessage, MetadataValidationStatus } from '@enums'; @@ -81,29 +80,7 @@ export class AppService { const hashedMetadata = blake.blake2bHex(rawData, undefined, 32); if (hashedMetadata !== hash) { - // Optionally validate on a parsed metadata - const hashedParsedMetadata = blake.blake2bHex( - JSON.stringify(parsedData, null, 2), - undefined, - 32, - ); - if (hashedParsedMetadata !== hash) { - // Optional support for the canonized data hash - // Validate canonized data hash - const canonizedMetadata = await jsonld.canonize(JSON.parse(rawData), { - safe: false, - }); - - const hashedCanonizedMetadata = blake.blake2bHex( - canonizedMetadata, - undefined, - 32, - ); - - if (hashedCanonizedMetadata !== hash) { - throw MetadataValidationStatus.INVALID_HASH; - } - } + throw MetadataValidationStatus.INVALID_HASH; } } catch (error) { Logger.error(LoggerMessage.METADATA_VALIDATION_ERROR, error);