From dd7a423e73457fd130d2eb974d18fdb49d674ee7 Mon Sep 17 00:00:00 2001
From: joseph rana <josephranamgr7@gmail.com>
Date: Fri, 5 Sep 2025 13:34:48 +0545
Subject: [PATCH] fix drep vote calculation for proposal display tests

---
 .../playwright/lib/pages/outcomeDetailsPage.ts       | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/tests/govtool-frontend/playwright/lib/pages/outcomeDetailsPage.ts b/tests/govtool-frontend/playwright/lib/pages/outcomeDetailsPage.ts
index 6ead1d8be..1c25fcf6d 100644
--- a/tests/govtool-frontend/playwright/lib/pages/outcomeDetailsPage.ts
+++ b/tests/govtool-frontend/playwright/lib/pages/outcomeDetailsPage.ts
@@ -94,7 +94,7 @@ export default class OutcomeDetailsPage {
     isLoggedIn = false
   ) {
     await Promise.all(
-      Object.keys(outcomeType).map(async (filterKey) => {
+      Object.entries(outcomeType).map(async ([filterKey, filterValue]) => {
         const outcomePage = new OutComesPage(this.page);
         const {
           govActionDetailsPage,
@@ -106,6 +106,7 @@ export default class OutcomeDetailsPage {
           isLoggedIn
         );
 
+        
         if (!govActionDetailsPage) {
           return;
         }
@@ -120,6 +121,11 @@ export default class OutcomeDetailsPage {
             metricsResponse
           );
 
+        const metricsResponseJson = await metricsResponse.json();
+        const totalStakeControlledByNoConfidence = Number(metricsResponseJson.always_no_confidence_voting_power)
+        const dRepYesVotes = filterValue === outcomeType.NoConfidence ? Number(proposalToCheck.yes_votes) + totalStakeControlledByNoConfidence : Number(proposalToCheck.yes_votes);
+        const dRepNoVotes = filterValue != outcomeType.NoConfidence ? Number(proposalToCheck.no_votes) + totalStakeControlledByNoConfidence : Number(proposalToCheck.no_votes) ;
+
         const currentPageUrl = govActionDetailsPage.currentPage.url();
 
         // check dRep votes
@@ -134,7 +140,7 @@ export default class OutcomeDetailsPage {
               message: `DRep "Yes" voting power checked for ${currentPageUrl}`,
             }
           ).toHaveText(
-            `Yes${formatWithThousandSeparator(proposalToCheck.yes_votes, false)}`,
+            `Yes${formatWithThousandSeparator(dRepYesVotes, false)}`,
             {
               timeout: 60_000,
             }
@@ -177,7 +183,7 @@ export default class OutcomeDetailsPage {
               message: `DRep "No" voting power checked for ${currentPageUrl}`,
             }
           ).toHaveText(
-            `No${formatWithThousandSeparator(proposalToCheck.no_votes, false)}`
+            `No${formatWithThousandSeparator(dRepNoVotes, false)}`
           ); //BUG missing testIds
         }