Skip to content

Commit 18bd0af

Browse files
committed
refactor: update initialize2WithApiKey so that parameters are always in the same order
1 parent 7664ace commit 18bd0af

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public void initializeWithApiKey(String apiKey, ReadableMap configReadableMap, S
9797
promise.resolve(true);
9898
}
9999

100-
public void initialize2WithApiKey(String apiKey, ReadableMap configReadableMap, String apiEndPointOverride, String version, Promise promise) {
100+
public void initialize2WithApiKey(String apiKey, ReadableMap configReadableMap, String version, String apiEndPointOverride, Promise promise) {
101101
IterableLogger.d(TAG, "initialize2WithApiKey: " + apiKey);
102102
IterableConfig.Builder configBuilder = Serialization.getConfigFromReadableMap(configReadableMap);
103103

android/src/newarch/java/com/RNIterableAPIModule.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ public void initializeWithApiKey(String apiKey, ReadableMap configReadableMap, S
3232
}
3333

3434
@Override
35-
public void initialize2WithApiKey(String apiKey, ReadableMap configReadableMap, String apiEndPointOverride, String version, Promise promise) {
36-
moduleImpl.initialize2WithApiKey(apiKey, configReadableMap, apiEndPointOverride, version, promise);
35+
public void initialize2WithApiKey(String apiKey, ReadableMap configReadableMap, String version, String apiEndPointOverride, Promise promise) {
36+
moduleImpl.initialize2WithApiKey(apiKey, configReadableMap, version, apiEndPointOverride, promise);
3737
}
3838

3939
@Override

android/src/oldarch/java/com/RNIterableAPIModule.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ public void initializeWithApiKey(String apiKey, ReadableMap configReadableMap, S
3434
}
3535

3636
@ReactMethod
37-
public void initialize2WithApiKey(String apiKey, ReadableMap configReadableMap, String apiEndPointOverride, String version, Promise promise) {
38-
moduleImpl.initialize2WithApiKey(apiKey, configReadableMap, apiEndPointOverride, version, promise);
37+
public void initialize2WithApiKey(String apiKey, ReadableMap configReadableMap, String version, String apiEndPointOverride, Promise promise) {
38+
moduleImpl.initialize2WithApiKey(apiKey, configReadableMap, version, apiEndPointOverride, promise);
3939
}
4040

4141
@ReactMethod

ios/RNIterableAPI/RNIterableAPI.mm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ - (void)initialize2WithApiKey:(NSString *)apiKey
8080
reject:(RCTPromiseRejectBlock)reject {
8181
[_swiftAPI initialize2WithApiKey:apiKey
8282
config:config
83-
apiEndPointOverride:apiEndPointOverride
8483
version:version
84+
apiEndPointOverride:apiEndPointOverride
8585
resolver:resolve
8686
rejecter:reject];
8787
}
@@ -313,8 +313,8 @@ - (void)wakeApp {
313313
resolve reject : (RCTPromiseRejectBlock)reject) {
314314
[_swiftAPI initialize2WithApiKey:apiKey
315315
config:config
316-
apiEndPointOverride:apiEndPointOverride
317316
version:version
317+
apiEndPointOverride:apiEndPointOverride
318318
resolver:resolve
319319
rejecter:reject];
320320
}

ios/RNIterableAPI/ReactIterableAPI.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ import React
7171
rejecter: rejecter)
7272
}
7373

74-
@objc(initialize2WithApiKey:config:apiEndPointOverride:version:resolver:rejecter:)
74+
@objc(initialize2WithApiKey:config:version:apiEndPointOverride:resolver:rejecter:)
7575
public func initialize2WithApiKey(
7676
apiKey: String,
7777
config configDict: NSDictionary,

src/api/NativeRNIterableAPI.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ export interface Spec extends TurboModule {
1212
initialize2WithApiKey(
1313
apiKey: string,
1414
config: { [key: string]: string | number | boolean | undefined | string[] },
15-
apiEndPointOverride: string,
16-
version: string
15+
version: string,
16+
apiEndPointOverride: string
1717
): Promise<boolean>;
1818

1919
// User management

0 commit comments

Comments
 (0)