refactor: update parameter types to nullable in RNIterableAPI for consistency

Author: lposen

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

@@ -172,7 +172,7 @@ public void getUserId(Promise promise) {
         promise.resolve(RNIterableInternal.getUserId());
     }
 
-    public void trackEvent(String name, ReadableMap dataFields) {
+    public void trackEvent(String name, @Nullable ReadableMap dataFields) {
         IterableLogger.v(TAG, "trackEvent");
         IterableApi.getInstance().track(name, optSerializedDataFields(dataFields));
     }
@@ -182,16 +182,16 @@ public void updateCart(ReadableArray items) {
         IterableApi.getInstance().updateCart(Serialization.commerceItemsFromReadableArray(items));
     }
 
-    public void trackPurchase(double total, ReadableArray items, ReadableMap dataFields) {
+    public void trackPurchase(double total, ReadableArray items, @Nullable ReadableMap dataFields) {
         IterableLogger.v(TAG, "trackPurchase");
         IterableApi.getInstance().trackPurchase(total, Serialization.commerceItemsFromReadableArray(items), optSerializedDataFields(dataFields));
     }
 
     public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {
-        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? (int) templateId : null, messageId, optSerializedDataFields(dataFields));
+        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));
     }
 
-    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+    public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
         IterableLogger.v(TAG, "updateSubscriptions");
         Integer finalCampaignId = null, finalTemplateId = null;
         if (campaignId > 0) {
@@ -270,7 +270,7 @@ public void getAttributionInfo(Promise promise) {
         }
     }
 
-    public void setAttributionInfo(ReadableMap attributionInfoReadableMap) {
+    public void setAttributionInfo(@Nullable ReadableMap attributionInfoReadableMap) {
         IterableLogger.printInfo();
         try {
             JSONObject attributionInfoJson = Serialization.convertMapToJson(attributionInfoReadableMap);
@@ -598,7 +598,7 @@ public void removeListeners(double count) {
         // Keep: Required for RN built in Event Emitter Calls.
     }
 
-    public void passAlongAuthToken(String authToken) {
+    public void passAlongAuthToken(@Nullable String authToken) {
         passedAuthToken = authToken;
 
         if (authHandlerCallbackLatch != null) {

android/src/newarch/java/com/iterable/reactnative/RNIterableAPIModule.java

@@ -77,7 +77,7 @@ public void getUserId(Promise promise) {
   }
 
   @Override
-  public void trackEvent(String name, ReadableMap dataFields) {
+  public void trackEvent(String name, @Nullable ReadableMap dataFields) {
     moduleImpl.trackEvent(name, dataFields);
   }
 
@@ -87,7 +87,7 @@ public void updateCart(ReadableArray items) {
   }
 
   @Override
-  public void trackPurchase(double total, ReadableArray items, ReadableMap dataFields) {
+  public void trackPurchase(double total, ReadableArray items, @Nullable ReadableMap dataFields) {
     moduleImpl.trackPurchase(total, items, dataFields);
   }
 
@@ -97,7 +97,7 @@ public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double temp
   }
 
   @Override
-  public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+  public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
     moduleImpl.updateSubscriptions(emailListIds, unsubscribedChannelIds, unsubscribedMessageTypeIds, subscribedMessageTypeIds, campaignId, templateId);
   }
 
@@ -127,7 +127,7 @@ public void getAttributionInfo(Promise promise) {
   }
 
   @Override
-  public void setAttributionInfo(ReadableMap attributionInfoReadableMap) {
+  public void setAttributionInfo(@Nullable ReadableMap attributionInfoReadableMap) {
     moduleImpl.setAttributionInfo(attributionInfoReadableMap);
   }
 
@@ -219,7 +219,7 @@ public void removeListeners(double count) {
     moduleImpl.removeListeners(count);
   }
 
-  public void passAlongAuthToken(String authToken) {
+  public void passAlongAuthToken(@Nullable String authToken) {
     moduleImpl.passAlongAuthToken(authToken);
   }
 

android/src/oldarch/java/com/iterable/reactnative/RNIterableAPIModule.java

@@ -77,7 +77,7 @@ public void getUserId(Promise promise) {
     }
 
     @ReactMethod
-    public void trackEvent(String name, ReadableMap dataFields) {
+    public void trackEvent(String name, @Nullable ReadableMap dataFields) {
       moduleImpl.trackEvent(name, dataFields);
     }
 
@@ -87,7 +87,7 @@ public void updateCart(ReadableArray items) {
     }
 
     @ReactMethod
-    public void trackPurchase(double total, ReadableArray items, ReadableMap dataFields) {
+    public void trackPurchase(double total, ReadableArray items, @Nullable ReadableMap dataFields) {
       moduleImpl.trackPurchase(total, items, dataFields);
     }
 
@@ -97,7 +97,7 @@ public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double temp
     }
 
     @ReactMethod
-    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+    public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
       moduleImpl.updateSubscriptions(emailListIds, unsubscribedChannelIds, unsubscribedMessageTypeIds, subscribedMessageTypeIds, campaignId, templateId);
     }
 
@@ -127,7 +127,7 @@ public void getAttributionInfo(Promise promise) {
     }
 
     @ReactMethod
-    public void setAttributionInfo(ReadableMap attributionInfoReadableMap) {
+    public void setAttributionInfo(@Nullable ReadableMap attributionInfoReadableMap) {
       moduleImpl.setAttributionInfo(attributionInfoReadableMap);
     }
 
@@ -222,7 +222,7 @@ public void removeListeners(double count) {
     }
 
     @ReactMethod
-    public void passAlongAuthToken(String authToken) {
+    public void passAlongAuthToken(@Nullable String authToken) {
       moduleImpl.passAlongAuthToken(authToken);
     }