Skip to content

Commit c009a1e

Browse files
committed
refactor: update templateId type to double in trackPushOpenWithCampaignId
1 parent 5a946b2 commit c009a1e

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,8 @@ public void trackPurchase(double total, ReadableArray items, ReadableMap dataFie
187187
IterableApi.getInstance().trackPurchase(total, Serialization.commerceItemsFromReadableArray(items), optSerializedDataFields(dataFields));
188188
}
189189

190-
public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
191-
RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));
190+
public void trackPushOpenWithCampaignId(double campaignId, double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
191+
RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, (int) templateId, messageId, optSerializedDataFields(dataFields));
192192
}
193193

194194
public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {

android/src/newarch/java/com/iterable/reactnative/RNIterableAPIModule.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public void trackPurchase(double total, ReadableArray items, ReadableMap dataFie
9292
}
9393

9494
@Override
95-
public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
95+
public void trackPushOpenWithCampaignId(double campaignId, double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
9696
moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
9797
}
9898

@@ -191,7 +191,6 @@ public void setAutoDisplayPaused(final boolean paused) {
191191
moduleImpl.setAutoDisplayPaused(paused);
192192
}
193193

194-
@Override
195194
public void wakeApp() {
196195
moduleImpl.wakeApp();
197196
}
@@ -206,7 +205,6 @@ public void endSession() {
206205
moduleImpl.endSession();
207206
}
208207

209-
@Override
210208
public void updateVisibleRows(ReadableArray visibleRows) {
211209
moduleImpl.updateVisibleRows(visibleRows);
212210
}
@@ -221,7 +219,6 @@ public void removeListeners(double count) {
221219
moduleImpl.removeListeners(count);
222220
}
223221

224-
@Override
225222
public void passAlongAuthToken(String authToken) {
226223
moduleImpl.passAlongAuthToken(authToken);
227224
}

android/src/oldarch/java/com/iterable/reactnative/RNIterableAPIModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public void trackPurchase(double total, ReadableArray items, ReadableMap dataFie
9292
}
9393

9494
@ReactMethod
95-
public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
95+
public void trackPushOpenWithCampaignId(double campaignId, double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
9696
moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
9797
}
9898

ios/RNIterableAPI/RNIterableAPI.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ - (void)passAlongAuthToken:(NSString *_Nullable)authToken {
382382
}
383383

384384
RCT_EXPORT_METHOD(
385-
trackPushOpenWithCampaignId : (double)campaignId templateId : (NSNumber *)
385+
trackPushOpenWithCampaignId : (double)campaignId templateId : (double)
386386
templateId messageId : (double)messageId appAlreadyRunning : (BOOL)
387387
appAlreadyRunning dataFields : (NSDictionary *)dataFields) {
388388
[_swiftAPI trackPushOpenWithCampaignId:campaignId

0 commit comments

Comments
 (0)