refactor: update templateId parameter type to Double in RNIterableAPI for consistency

Author: lposen

ios/RNIterableAPI/RNIterableAPI.mm

@@ -155,7 +155,7 @@ - (void)trackEvent:(NSString *)name dataFields:(NSDictionary *)dataFields {
 }
 
 - (void)trackPushOpenWithCampaignId:(double)campaignId
-                         templateId:(NSNumber *_Nullable)templateId
+                         templateId:(double)templateId
                           messageId:(NSString *)messageId
                   appAlreadyRunning:(BOOL)appAlreadyRunning
                          dataFields:(NSDictionary *)dataFields {
@@ -382,9 +382,8 @@ - (void)passAlongAuthToken:(NSString *_Nullable)authToken {
 }
 
 RCT_EXPORT_METHOD(
-    trackPushOpenWithCampaignId : (double)campaignId templateId : (
-        NSNumber *_Nullable)templateId messageId : (NSString *)
-        messageId appAlreadyRunning : (BOOL)
+    trackPushOpenWithCampaignId : (double)campaignId templateId : (NSNumber *)
+        templateId messageId : (double)messageId appAlreadyRunning : (BOOL)
             appAlreadyRunning dataFields : (NSDictionary *)dataFields) {
   [_swiftAPI trackPushOpenWithCampaignId:campaignId
                               templateId:templateId

ios/RNIterableAPI/ReactIterableAPI.swift

@@ -170,7 +170,7 @@ import React
   @objc(trackPushOpenWithCampaignId:templateId:messageId:appAlreadyRunning:dataFields:)
   public func trackPushOpenWithCampaignId(
     campaignId: Double,
-    templateId: NSNumber?,
+    templateId: Double,
     messageId: String,
     appAlreadyRunning: Bool,
     dataFields: NSDictionary?
@@ -180,7 +180,7 @@ import React
 
     IterableAPI.track(
       pushOpen: campaignId as NSNumber,
-      templateId: templateId,
+      templateId: templateId as NSNumber,
       messageId: messageId,
       appAlreadyRunning: appAlreadyRunning,
       dataFields: swiftDict)
@@ -388,7 +388,6 @@ import React
     ITBInfo()
     guard let message = IterableAPI.inAppManager.getMessage(withId: messageId) else {
       ITBError("Could not find message with id: \(messageId)")
-      rejecter("", "Could not find message with id: \(messageId)", NSError(domain: "", code: 0, userInfo: nil))
       return
     }
     if let inAppDeleteSource = InAppDeleteSource.from(number: sourceNumber as NSNumber) {
@@ -416,8 +415,8 @@ import React
     templateId: Double
   ) {
     ITBInfo()
-    let finalCampaignId: NSNumber? = campaignId <= 0 ? nil : campaignId as NSNumber
-    let finalTemplateId: NSNumber? = templateId <= 0 ? nil : templateId as NSNumber
+    let finalCampaignId: NSNumber? = (campaignId as NSNumber).intValue <= 0 ? nil : campaignId as NSNumber
+    let finalTemplateId: NSNumber? = (templateId as NSNumber).intValue <= 0 ? nil : templateId as NSNumber
     IterableAPI.updateSubscriptions(
       emailListIds,
       unsubscribedChannelIds: unsubscribedChannelIds,

src/api/NativeRNIterableAPI.ts

@@ -39,7 +39,7 @@ export interface Spec extends TurboModule {
   ): void;
   trackPushOpenWithCampaignId(
     campaignId: number,
-    templateId: number | null,
+    templateId: number,
     messageId: string,
     appAlreadyRunning: boolean,
     dataFields?: { [key: string]: string | number | boolean }