From 584a8429d1c37fe20cd9a2f13c87916df54ddc1b Mon Sep 17 00:00:00 2001
From: Jumoke Bolanle <jumoke.bolanle@gmail.com>
Date: Thu, 7 May 2026 22:57:15 -0500
Subject: [PATCH] fix: correct About version and fix drag-and-drop file paths

- Use env!("CARGO_PKG_VERSION") in AboutMetadata so the version
  stays in sync with Cargo.toml automatically
- Replace HTML5 drop handler with tauri://drag-drop event listener;
  Tauri v2 webview does not expose file.path on File objects so the
  old handler always fell back to the bare filename instead of the
  absolute path
---
 src-tauri/src/menu.rs             |  2 +-
 src/lib/components/Sidebar.svelte | 23 +++++++++++------------
 src/test/Sidebar.test.ts          | 16 +++++++++++++++-
 3 files changed, 27 insertions(+), 14 deletions(-)

diff --git a/src-tauri/src/menu.rs b/src-tauri/src/menu.rs
index 245c406..e466a3e 100644
--- a/src-tauri/src/menu.rs
+++ b/src-tauri/src/menu.rs
@@ -22,7 +22,7 @@ pub fn build_menu(app: &tauri::AppHandle) -> tauri::Result<(Menu<tauri::Wry>, Me
         Some(AboutMetadata {
             icon: Some(include_image!("icons/icon.png")),
             name: Some("compress[pdf]".to_string()),
-            version: Some("1.1.0".to_string()),
+            version: Some(env!("CARGO_PKG_VERSION").to_string()),
             copyright: Some("Copyright \u{00A9} 2026 Olajumoke Bolanle".to_string()),
             license: Some("GNU Affero General Public License v3.0".to_string()),
             website: Some("https://github.com/JBolanle/PDFCompressor/".to_string()),
diff --git a/src/lib/components/Sidebar.svelte b/src/lib/components/Sidebar.svelte
index 784873e..2cc7c7a 100644
--- a/src/lib/components/Sidebar.svelte
+++ b/src/lib/components/Sidebar.svelte
@@ -1,21 +1,21 @@
 <script lang="ts">
+  import { onMount, onDestroy } from "svelte";
+  import { listen } from "@tauri-apps/api/event";
   import { queue } from "$lib/stores/queueStore";
   import { selectedFileId } from "$lib/stores/selectionStore";
   import { addFiles, addPath } from "$lib/fileActions";
 
   let isDragOver = false;
+  let unlistenDrop: (() => void) | undefined;
 
-  function onDrop(e: DragEvent) {
-    isDragOver = false;
-    e.preventDefault();
-    const items = Array.from(e.dataTransfer?.items ?? []);
-    for (const item of items) {
-      if (item.kind === "file") {
-        const file = item.getAsFile();
-        if (file) addPath((file as any).path ?? file.name);
-      }
-    }
-  }
+  onMount(async () => {
+    unlistenDrop = await listen<{ paths: string[] }>("tauri://drag-drop", (event) => {
+      isDragOver = false;
+      for (const path of event.payload.paths) addPath(path);
+    });
+  });
+
+  onDestroy(() => unlistenDrop?.());
 </script>
 
 <aside
@@ -23,7 +23,6 @@
   class:drag-over={isDragOver}
   on:dragover|preventDefault={() => (isDragOver = true)}
   on:dragleave={() => (isDragOver = false)}
-  on:drop={onDrop}
   role="region"
   aria-label="File queue"
 >
diff --git a/src/test/Sidebar.test.ts b/src/test/Sidebar.test.ts
index 9166acd..97aab3d 100644
--- a/src/test/Sidebar.test.ts
+++ b/src/test/Sidebar.test.ts
@@ -1,11 +1,18 @@
 import { describe, it, expect, beforeEach, vi } from "vitest";
-import { render, screen } from "@testing-library/svelte";
+import { render, screen, waitFor } from "@testing-library/svelte";
 import { queue } from "$lib/stores/queueStore";
 import { selectedFileId } from "$lib/stores/selectionStore";
 import Sidebar from "$lib/components/Sidebar.svelte";
 
+const dropListeners: Array<(e: { payload: { paths: string[] } }) => void> = [];
 vi.mock("@tauri-apps/api/core", () => ({ invoke: vi.fn().mockResolvedValue(true) }));
 vi.mock("@tauri-apps/plugin-dialog", () => ({ open: vi.fn().mockResolvedValue(null) }));
+vi.mock("@tauri-apps/api/event", () => ({
+  listen: vi.fn(async (event: string, handler: (e: unknown) => void) => {
+    if (event === "tauri://drag-drop") dropListeners.push(handler as never);
+    return () => {};
+  }),
+}));
 
 describe("Sidebar", () => {
   beforeEach(() => {
@@ -18,6 +25,13 @@ describe("Sidebar", () => {
     expect(screen.getByText(/drop pdfs/i)).toBeInTheDocument();
   });
 
+  it("adds files via tauri://drag-drop event", async () => {
+    render(Sidebar);
+    await waitFor(() => expect(dropListeners.length).toBeGreaterThan(0));
+    dropListeners[0]({ payload: { paths: ["/tmp/a.pdf"] } });
+    await waitFor(() => expect(screen.getByText("a.pdf")).toBeInTheDocument());
+  });
+
   it("renders one row per file in the queue", () => {
     queue.addFile({ path: "/tmp/a.pdf", name: "a.pdf", size: 1000 });
     queue.addFile({ path: "/tmp/b.pdf", name: "b.pdf", size: 2000 });