From 9d08e71fbbe325958b999f90af13bc942aaaf1cb Mon Sep 17 00:00:00 2001 From: carymcpoland Date: Thu, 19 Oct 2017 22:52:04 +0100 Subject: [PATCH 1/3] Adds lint and test pre-push hooks --- package.json | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/package.json b/package.json index bed8bbf793..dc464851d4 100644 --- a/package.json +++ b/package.json @@ -48,6 +48,7 @@ "nps": "^5.7.1", "nps-utils": "^1.3.0", "nyc": "^11.1.0", + "pre-push": "^0.1.1", "react": "^15.5.0", "react-addons-shallow-compare": "^15.5.0", "react-dom": "^15.5.0", @@ -97,5 +98,9 @@ "react-component", "select", "ui" + ], + "pre-push": [ + "lint", + "test" ] } From 9fc5af4b3bee82f5535bafc223ca2c71b4f61627 Mon Sep 17 00:00:00 2001 From: carymcpoland Date: Wed, 25 Oct 2017 23:18:52 +0100 Subject: [PATCH 2/3] Adds lint and test pre-commit hooks --- package.json | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index dc464851d4..c1ae6a641a 100644 --- a/package.json +++ b/package.json @@ -38,17 +38,18 @@ "extract-text-webpack-plugin": "^3.0.0", "html-loader": "^0.5.1", "html-webpack-plugin": "^2.30.1", + "husky": "^0.14.3", "isomorphic-fetch": "^2.2.1", "istanbul": "^0.4.5", "jsdom": "^9.12.0", "less": "^2.7.2", "less-loader": "^4.0.5", "less-plugin-clean-css": "^1.5.1", + "lint-staged": "^4.3.0", "mocha": "^3.0.2", "nps": "^5.7.1", "nps-utils": "^1.3.0", "nyc": "^11.1.0", - "pre-push": "^0.1.1", "react": "^15.5.0", "react-addons-shallow-compare": "^15.5.0", "react-dom": "^15.5.0", @@ -83,7 +84,8 @@ "lint": "eslint .", "publish:examples": "NODE_ENV=production nps publish", "start": "webpack-dev-server --progress", - "test": "NODE_ENV=test mocha --compilers js:babel-core/register" + "test": "NODE_ENV=test mocha --compilers js:babel-core/register", + "precommit": "lint-staged && yarn run test" }, "files": [ "dist", @@ -99,8 +101,7 @@ "select", "ui" ], - "pre-push": [ - "lint", - "test" - ] + "lint-staged": { + "*.js": ["eslint", "git add"] + } } From cdedc327fd34c5c4077dc019f9ebdb4cc7078d76 Mon Sep 17 00:00:00 2001 From: carymcpoland Date: Thu, 26 Oct 2017 08:39:32 +0100 Subject: [PATCH 3/3] Removes unnecessary 'git add' from lint-staged --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index c1ae6a641a..8c15c174eb 100644 --- a/package.json +++ b/package.json @@ -102,6 +102,6 @@ "ui" ], "lint-staged": { - "*.js": ["eslint", "git add"] + "*.js": "eslint" } }