From 31a7dea5c56f33c304a1771b135c5f6961b52346 Mon Sep 17 00:00:00 2001 From: rafaqz Date: Thu, 18 Jan 2024 15:04:40 +0100 Subject: [PATCH 1/5] add a groupby method --- src/DataAPI.jl | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/DataAPI.jl b/src/DataAPI.jl index da0da0e..d4fe498 100644 --- a/src/DataAPI.jl +++ b/src/DataAPI.jl @@ -522,4 +522,14 @@ Return the row number of `row` in the source table. """ function rownumber end +""" + groupby(obj, args...; kw...) + +Group `obj` into partitions specified by `args` and `kw`, +which may vary according to the implementation for `obj`. + +The return value an iterable over the groups. +""" +function groupby end + end # module From 1c4c503dfcd100f49fbd32ba58b099c559370667 Mon Sep 17 00:00:00 2001 From: rafaqz Date: Thu, 18 Jan 2024 19:57:34 +0100 Subject: [PATCH 2/5] add docs on groupby first argument --- src/DataAPI.jl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/DataAPI.jl b/src/DataAPI.jl index d4fe498..1c6ff1a 100644 --- a/src/DataAPI.jl +++ b/src/DataAPI.jl @@ -529,6 +529,9 @@ Group `obj` into partitions specified by `args` and `kw`, which may vary according to the implementation for `obj`. The return value an iterable over the groups. + +To avoid type piracy and method ambiguities, implementations of `groupby` +must restrict the first argument to a type defined in the same package. """ function groupby end From e5bfd8f3801df15cb777d4092779f5f65e081771 Mon Sep 17 00:00:00 2001 From: rafaqz Date: Thu, 18 Jan 2024 20:00:52 +0100 Subject: [PATCH 3/5] remove return value --- src/DataAPI.jl | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/DataAPI.jl b/src/DataAPI.jl index 1c6ff1a..84bb7d3 100644 --- a/src/DataAPI.jl +++ b/src/DataAPI.jl @@ -528,8 +528,6 @@ function rownumber end Group `obj` into partitions specified by `args` and `kw`, which may vary according to the implementation for `obj`. -The return value an iterable over the groups. - To avoid type piracy and method ambiguities, implementations of `groupby` must restrict the first argument to a type defined in the same package. """ From 102d52faac2037c14e7d61bb636557ad9b6f80f1 Mon Sep 17 00:00:00 2001 From: rafaqz Date: Thu, 18 Jan 2024 20:08:59 +0100 Subject: [PATCH 4/5] bump minor version to 1.6.0 --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index 18e0204..d67a8df 100644 --- a/Project.toml +++ b/Project.toml @@ -1,7 +1,7 @@ name = "DataAPI" uuid = "9a962f9c-6df0-11e9-0e5d-c546b8b5ee8a" authors = ["quinnj "] -version = "1.15.0" +version = "1.16.0" [compat] julia = "1" From 1b8a546a46083dd04dba713fc792bd40a802f295 Mon Sep 17 00:00:00 2001 From: rafaqz Date: Fri, 19 Jan 2024 19:49:56 +0100 Subject: [PATCH 5/5] comment rather than doc --- src/DataAPI.jl | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/DataAPI.jl b/src/DataAPI.jl index 84bb7d3..95604d1 100644 --- a/src/DataAPI.jl +++ b/src/DataAPI.jl @@ -522,15 +522,8 @@ Return the row number of `row` in the source table. """ function rownumber end -""" - groupby(obj, args...; kw...) - -Group `obj` into partitions specified by `args` and `kw`, -which may vary according to the implementation for `obj`. - -To avoid type piracy and method ambiguities, implementations of `groupby` -must restrict the first argument to a type defined in the same package. -""" +# To avoid type piracy and method ambiguities, implementations of `groupby` +# must restrict the first argument to a type defined in the same package. function groupby end end # module