From a2f58b293e6429cc5671420e39115c0e3f71d6c6 Mon Sep 17 00:00:00 2001 From: David Widmann Date: Fri, 17 Sep 2021 08:05:05 +0200 Subject: [PATCH 1/3] Remove rules for `conj`, `adjoint`, and `transpose` --- src/rules.jl | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/rules.jl b/src/rules.jl index e1a1726..6ace211 100644 --- a/src/rules.jl +++ b/src/rules.jl @@ -67,9 +67,6 @@ @define_diffrule SpecialFunctions.loggamma(x) = :( SpecialFunctions.digamma($x) ) -@define_diffrule Base.conj(x) = :( 1 ) -@define_diffrule Base.adjoint(x) = :( 1 ) -@define_diffrule Base.transpose(x) = :( 1 ) @define_diffrule Base.abs(x) = :( DiffRules._abs_deriv($x) ) # We provide this hook for special number types like `Interval` From 4caf56f430e84de632e5ab639a2f24759f30b972 Mon Sep 17 00:00:00 2001 From: David Widmann Date: Fri, 17 Sep 2021 08:05:35 +0200 Subject: [PATCH 2/3] Bump version --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index 28f4607..818be1c 100644 --- a/Project.toml +++ b/Project.toml @@ -1,6 +1,6 @@ name = "DiffRules" uuid = "b552c78f-8df3-52c6-915a-8e097449b14b" -version = "1.3.0" +version = "1.3.1" [deps] NaNMath = "77ba4419-2d1f-58cd-9bb1-8ffee604a2e3" From 8dca5dfeeaa752f31dfea4a4e1d367d56d02a2a8 Mon Sep 17 00:00:00 2001 From: David Widmann Date: Fri, 17 Sep 2021 08:23:38 +0200 Subject: [PATCH 3/3] Add integration test for ReverseDiff --- .github/workflows/downstream.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/downstream.yml b/.github/workflows/downstream.yml index 322ca50..7af4f84 100644 --- a/.github/workflows/downstream.yml +++ b/.github/workflows/downstream.yml @@ -18,6 +18,7 @@ jobs: os: [ubuntu-latest] package: - {user: JuliaDiff, repo: ForwardDiff.jl, group: All} + - {user: JuliaDiff, repo: ReverseDiff.jl, group: All} - {user: FluxML, repo: Tracker.jl, group: All} - {user: FluxML, repo: Zygote.jl, group: All} - {user: invenia, repo: Nabla.jl, group: All}