From a44cdcfeec629bd093773989953e08f422cad65b Mon Sep 17 00:00:00 2001 From: wt Date: Fri, 20 Nov 2020 11:30:50 +0000 Subject: [PATCH 1/4] Tweak Zero to vec --- src/to_vec.jl | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/to_vec.jl b/src/to_vec.jl index ae311186..821d3b2b 100644 --- a/src/to_vec.jl +++ b/src/to_vec.jl @@ -155,10 +155,8 @@ end function FiniteDifferences.to_vec(x::AbstractZero) - function AbstractZero_from_vec(z) - length(z) == 1 || throw(DimensionMismatch("tried to go back to $x from $z")) - iszero(first(z)) || throw(DomainError(first(z))) + function AbstractZero_from_vec(x_vec::Vector) return x end - return [false], AbstractZero_from_vec + return Bool[], AbstractZero_from_vec end From 11d27dfcd416e0a9efaea76e1198ca38de0d034e Mon Sep 17 00:00:00 2001 From: wt Date: Fri, 20 Nov 2020 11:32:42 +0000 Subject: [PATCH 2/4] Bump patch --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index 59f30dfe..9c1dc117 100644 --- a/Project.toml +++ b/Project.toml @@ -1,6 +1,6 @@ name = "FiniteDifferences" uuid = "26cc04aa-876d-5657-8c51-4c34ba976000" -version = "0.11.2" +version = "0.11.3" [deps] ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4" From 361c5692ba0f8cbfcec1fef01ff0cd7453359376 Mon Sep 17 00:00:00 2001 From: wt Date: Fri, 20 Nov 2020 12:51:56 +0000 Subject: [PATCH 3/4] Fix Diagonal --- src/to_vec.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/to_vec.jl b/src/to_vec.jl index 821d3b2b..ed5dd6eb 100644 --- a/src/to_vec.jl +++ b/src/to_vec.jl @@ -76,9 +76,9 @@ function to_vec(x::T) where {T<:LinearAlgebra.HermOrSym} end function to_vec(X::Diagonal) - x_vec, back = to_vec(Matrix(X)) + x_vec, diag_from_vec = to_vec(X.diag) function Diagonal_from_vec(x_vec) - return Diagonal(back(x_vec)) + return Diagonal(diag_from_vec(x_vec)) end return x_vec, Diagonal_from_vec end From 283e82c714ef8105e739683f7c4a921a09091da8 Mon Sep 17 00:00:00 2001 From: wt Date: Fri, 20 Nov 2020 13:10:48 +0000 Subject: [PATCH 4/4] Revert Diagonal changes --- src/to_vec.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/to_vec.jl b/src/to_vec.jl index ed5dd6eb..821d3b2b 100644 --- a/src/to_vec.jl +++ b/src/to_vec.jl @@ -76,9 +76,9 @@ function to_vec(x::T) where {T<:LinearAlgebra.HermOrSym} end function to_vec(X::Diagonal) - x_vec, diag_from_vec = to_vec(X.diag) + x_vec, back = to_vec(Matrix(X)) function Diagonal_from_vec(x_vec) - return Diagonal(diag_from_vec(x_vec)) + return Diagonal(back(x_vec)) end return x_vec, Diagonal_from_vec end