From bb8b616ae49e694d5cb76f40c2e18606be28c60b Mon Sep 17 00:00:00 2001 From: Michael Abbott <32575566+mcabbott@users.noreply.github.com> Date: Sun, 4 Jul 2021 20:59:25 -0400 Subject: [PATCH 1/4] rm rule for conj --- src/dual.jl | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/dual.jl b/src/dual.jl index 431bb3e5..62ce57be 100644 --- a/src/dual.jl +++ b/src/dual.jl @@ -378,8 +378,6 @@ Base.AbstractFloat(d::Dual{T,V,N}) where {T,V,N} = convert(Dual{T,promote_type(V # General Mathematical Operations # ################################### -@inline Base.conj(d::Dual) = d - for (M, f, arity) in DiffRules.diffrules() in((M, f), ((:Base, :^), (:NaNMath, :pow), (:Base, :/), (:Base, :+), (:Base, :-))) && continue if arity == 1 From b32620eb70e96cf99cecdbe51c6f9dae273d6162 Mon Sep 17 00:00:00 2001 From: Michael Abbott <32575566+mcabbott@users.noreply.github.com> Date: Sun, 4 Jul 2021 16:37:26 -0400 Subject: [PATCH 2/4] some Hessian tests --- test/HessianTest.jl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/HessianTest.jl b/test/HessianTest.jl index 1df4232b..f5dd750a 100644 --- a/test/HessianTest.jl +++ b/test/HessianTest.jl @@ -130,13 +130,13 @@ for T in (StaticArrays.SArray, StaticArrays.MArray) result1 = ForwardDiff.hessian!(result1, prod, sx) result2 = ForwardDiff.hessian!(result2, prod, sx, ForwardDiff.HessianConfig(prod, result2, x, ForwardDiff.Chunk(x), nothing)) result3 = ForwardDiff.hessian!(result3, prod, sx, ForwardDiff.HessianConfig(prod, result3, x, ForwardDiff.Chunk(x), nothing)) - @test DiffResults.value(result1) == DiffResults.value(result) + @test_broken DiffResults.value(result1) == DiffResults.value(result) @test DiffResults.value(result2) == DiffResults.value(result) @test DiffResults.value(result3) == DiffResults.value(result) - @test DiffResults.gradient(result1) == DiffResults.gradient(result) + @test_broken DiffResults.gradient(result1) == DiffResults.gradient(result) @test DiffResults.gradient(result2) == DiffResults.gradient(result) @test DiffResults.gradient(result3) == DiffResults.gradient(result) - @test DiffResults.hessian(result1) == DiffResults.hessian(result) + @test_broken DiffResults.hessian(result1) == DiffResults.hessian(result) @test DiffResults.hessian(result2) == DiffResults.hessian(result) @test DiffResults.hessian(result3) == DiffResults.hessian(result) From 5527822053d4bba36e2b7aa1ee415b3004ce8dbc Mon Sep 17 00:00:00 2001 From: Michael Abbott <32575566+mcabbott@users.noreply.github.com> Date: Sat, 17 Jul 2021 18:39:36 -0400 Subject: [PATCH 3/4] lower-bound DiffRules at 1.2.1 --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index 8dc2bcf3..4a3379b5 100644 --- a/Project.toml +++ b/Project.toml @@ -17,7 +17,7 @@ StaticArrays = "90137ffa-7385-5640-81b9-e52037218182" Calculus = "0.2, 0.3, 0.4, 0.5" CommonSubexpressions = "0.3" DiffResults = "0.0.1, 0.0.2, 0.0.3, 0.0.4, 1.0.1" -DiffRules = "0.0.4, 0.0.5, 0.0.6, 0.0.7, 0.0.8, 0.0.9, 0.0.10, 0.1, 1.0" +DiffRules = "1.2.1" DiffTests = "0.0.1, 0.1" NaNMath = "0.2.2, 0.3" SpecialFunctions = "0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 0.10, 1.0" From 4c0f4b96499846c4988175e703ff50f4a5b5581d Mon Sep 17 00:00:00 2001 From: Michael Abbott <32575566+mcabbott@users.noreply.github.com> Date: Sat, 17 Jul 2021 19:12:28 -0400 Subject: [PATCH 4/4] Revert "some Hessian tests" This reverts commit b32620eb70e96cf99cecdbe51c6f9dae273d6162. --- test/HessianTest.jl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/HessianTest.jl b/test/HessianTest.jl index f5dd750a..1df4232b 100644 --- a/test/HessianTest.jl +++ b/test/HessianTest.jl @@ -130,13 +130,13 @@ for T in (StaticArrays.SArray, StaticArrays.MArray) result1 = ForwardDiff.hessian!(result1, prod, sx) result2 = ForwardDiff.hessian!(result2, prod, sx, ForwardDiff.HessianConfig(prod, result2, x, ForwardDiff.Chunk(x), nothing)) result3 = ForwardDiff.hessian!(result3, prod, sx, ForwardDiff.HessianConfig(prod, result3, x, ForwardDiff.Chunk(x), nothing)) - @test_broken DiffResults.value(result1) == DiffResults.value(result) + @test DiffResults.value(result1) == DiffResults.value(result) @test DiffResults.value(result2) == DiffResults.value(result) @test DiffResults.value(result3) == DiffResults.value(result) - @test_broken DiffResults.gradient(result1) == DiffResults.gradient(result) + @test DiffResults.gradient(result1) == DiffResults.gradient(result) @test DiffResults.gradient(result2) == DiffResults.gradient(result) @test DiffResults.gradient(result3) == DiffResults.gradient(result) - @test_broken DiffResults.hessian(result1) == DiffResults.hessian(result) + @test DiffResults.hessian(result1) == DiffResults.hessian(result) @test DiffResults.hessian(result2) == DiffResults.hessian(result) @test DiffResults.hessian(result3) == DiffResults.hessian(result)