From cee5cd3902a6698b0b0f8814e25541a866d087c0 Mon Sep 17 00:00:00 2001 From: Guillaume Dalle <22795598+gdalle@users.noreply.github.com> Date: Sat, 1 Nov 2025 09:02:24 +0100 Subject: [PATCH 1/3] Try tests on Julia 1.12 --- .github/workflows/Test-GPU.yml | 4 ++-- .github/workflows/Test.yml | 2 +- Project.toml | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/Test-GPU.yml b/.github/workflows/Test-GPU.yml index f5a4fbc8..3ba3bd8d 100644 --- a/.github/workflows/Test-GPU.yml +++ b/.github/workflows/Test-GPU.yml @@ -21,10 +21,10 @@ jobs: env: CUDA_VISIBLE_DEVICES: 1 JULIA_DEPOT_PATH: /scratch/github-actions/julia_depot_alexis - JULIA_SMC_TEST_GROUP: "GPU" + JULIA_SMC_TEST_GROUP: 'GPU' strategy: matrix: - julia-version: ['1.10', '1.11'] + julia-version: ['1.10', '1.11', '1.12'] steps: - uses: actions/checkout@v5 - uses: julia-actions/setup-julia@v2 diff --git a/.github/workflows/Test.yml b/.github/workflows/Test.yml index 3e17ae97..e582efa3 100644 --- a/.github/workflows/Test.yml +++ b/.github/workflows/Test.yml @@ -20,7 +20,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - julia-version: ['1.10', '1.11'] + julia-version: ['1.10', '1.11', '1.12'] steps: - uses: actions/checkout@v5 diff --git a/Project.toml b/Project.toml index 864fae83..e34ce604 100644 --- a/Project.toml +++ b/Project.toml @@ -31,9 +31,9 @@ CliqueTrees = "1" Colors = "0.12.11, 0.13" DocStringExtensions = "0.8,0.9" JuMP = "1.29.1" -LinearAlgebra = "<0.0.1, 1" +LinearAlgebra = "1" MathOptInterface = "1.45.0" PrecompileTools = "1.2.1" -Random = "<0.0.1, 1" -SparseArrays = "<0.0.1, 1" +Random = "1" +SparseArrays = "1" julia = "1.10" From c0c9d66004e5d4327426457cbfb6941be8c03737 Mon Sep 17 00:00:00 2001 From: Guillaume Dalle <22795598+gdalle@users.noreply.github.com> Date: Sat, 1 Nov 2025 09:07:29 +0100 Subject: [PATCH 2/3] No 1.12 GPU test --- .github/workflows/Test-GPU.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/Test-GPU.yml b/.github/workflows/Test-GPU.yml index 3ba3bd8d..1795d222 100644 --- a/.github/workflows/Test-GPU.yml +++ b/.github/workflows/Test-GPU.yml @@ -24,7 +24,7 @@ jobs: JULIA_SMC_TEST_GROUP: 'GPU' strategy: matrix: - julia-version: ['1.10', '1.11', '1.12'] + julia-version: ['1.10', '1.11'] steps: - uses: actions/checkout@v5 - uses: julia-actions/setup-julia@v2 From 5807b07f04fe8b1f7d507ff2662cb59d847c7f3d Mon Sep 17 00:00:00 2001 From: Guillaume Dalle <22795598+gdalle@users.noreply.github.com> Date: Sat, 1 Nov 2025 09:43:32 +0100 Subject: [PATCH 3/3] Don't test type stability on 1.12 --- test/runtests.jl | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/test/runtests.jl b/test/runtests.jl index fa5cc7ff..7a070756 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -19,16 +19,16 @@ include("utils.jl") else @testset verbose = true "Code quality" begin @testset "Aqua" begin - Aqua.test_all(SparseMatrixColorings; stale_deps=(; ignore=[:Requires],)) + Aqua.test_all(SparseMatrixColorings; stale_deps = (; ignore = [:Requires])) end @testset "JET" begin - JET.test_package(SparseMatrixColorings; target_defined_modules=true) + JET.test_package(SparseMatrixColorings; target_defined_modules = true) end # @testset "JuliaFormatter" begin - # TODO: switch to Runic (temporarily deactivated) - # @test JuliaFormatter.format( - # SparseMatrixColorings; verbose=false, overwrite=false - # ) + # TODO: switch to Runic (temporarily deactivated) + # @test JuliaFormatter.format( + # SparseMatrixColorings; verbose=false, overwrite=false + # ) # end @testset "Doctests" begin Documenter.doctest(SparseMatrixColorings) @@ -88,7 +88,10 @@ include("utils.jl") end @testset verbose = true "Performance" begin @testset "Type stability" begin - include("type_stability.jl") + if VERSION < v"1.12" + # TODO: fix JET misbehaving + include("type_stability.jl") + end end @testset "Allocations" begin include("allocations.jl")