From 766ed87abeba2ae7e2daad9537cb342b563a6861 Mon Sep 17 00:00:00 2001 From: Oscar Smith Date: Mon, 5 Feb 2024 10:25:12 -0500 Subject: [PATCH 1/8] Hopefully fix codecov. --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 914af21..572c6eb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -69,3 +69,5 @@ jobs: - uses: codecov/codecov-action@v4 with: file: lcov.info + token: ${{ secrets.CODECOV_TOKEN }} + fail_ci_if_error: true From bc751bbaaf3262e329ea0cedee1ecc1fe73ba70d Mon Sep 17 00:00:00 2001 From: Oscar Smith Date: Mon, 5 Feb 2024 15:14:29 -0500 Subject: [PATCH 2/8] Update ci.yml --- .github/workflows/ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 572c6eb..fefe631 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -70,4 +70,3 @@ jobs: with: file: lcov.info token: ${{ secrets.CODECOV_TOKEN }} - fail_ci_if_error: true From 4b5c28061ee9404078bbb281aed84781fad97009 Mon Sep 17 00:00:00 2001 From: Oscar Smith Date: Mon, 5 Feb 2024 15:30:03 -0500 Subject: [PATCH 3/8] Update ci.yml --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fefe631..572c6eb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -70,3 +70,4 @@ jobs: with: file: lcov.info token: ${{ secrets.CODECOV_TOKEN }} + fail_ci_if_error: true From 27ee0e74291190b2f1ebbebec6ce727c25cfbfef Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Mon, 5 Feb 2024 15:32:00 -0500 Subject: [PATCH 4/8] Print the location of all `lcov.info` files --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 572c6eb..4ad3d0a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -66,6 +66,8 @@ jobs: - uses: julia-actions/julia-buildpkg@v1 - uses: julia-actions/julia-runtest@v1 - uses: julia-actions/julia-processcoverage@v1 + # Debugging: + - run: find . -type f -name 'lcov.info' - uses: codecov/codecov-action@v4 with: file: lcov.info From 545472cdde3a4b06fdc40478c4cb497d9e4366ae Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Mon, 5 Feb 2024 15:38:22 -0500 Subject: [PATCH 5/8] Also `cat` the `lcov.info` files --- .github/workflows/ci.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4ad3d0a..a6d631e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -66,8 +66,10 @@ jobs: - uses: julia-actions/julia-buildpkg@v1 - uses: julia-actions/julia-runtest@v1 - uses: julia-actions/julia-processcoverage@v1 - # Debugging: - - run: find . -type f -name 'lcov.info' + - name: (debug) find all lcov.info files + run: find . -type f -name 'lcov.info' + - name: (debug) cat all lcov.info files + run: find . -type f -name 'lcov.info' -exec cat {} \; - uses: codecov/codecov-action@v4 with: file: lcov.info From a92284e01f835282fab0ab9fb14af4c45cced26b Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Mon, 5 Feb 2024 15:42:05 -0500 Subject: [PATCH 6/8] Comment out some debug commands, and skip some dehug commands on Windows --- .github/workflows/ci.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a6d631e..6c71256 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -68,8 +68,10 @@ jobs: - uses: julia-actions/julia-processcoverage@v1 - name: (debug) find all lcov.info files run: find . -type f -name 'lcov.info' - - name: (debug) cat all lcov.info files - run: find . -type f -name 'lcov.info' -exec cat {} \; + if: runner.os == 'Windows' + # - name: (debug) cat all lcov.info files + # run: find . -type f -name 'lcov.info' -exec cat {} \; + # if: runner.os == 'Windows' - uses: codecov/codecov-action@v4 with: file: lcov.info From dfbd2bd0fc1d1d46db6acab2e9f1e7765d8c3a61 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Mon, 5 Feb 2024 15:44:42 -0500 Subject: [PATCH 7/8] Add some comments about the Codecov token --- .github/workflows/ci.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6c71256..375e17a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -75,5 +75,9 @@ jobs: - uses: codecov/codecov-action@v4 with: file: lcov.info + # For `v4` of `codecov/codecov-action`, + # if the repo is public, the following rules apply: + # 1. If the PR is from a fork, then no Codecov token is required. + # 2. If the PR is NOT from a fork, then the Codecov token is required. token: ${{ secrets.CODECOV_TOKEN }} fail_ci_if_error: true From 6a62506fa5b4b5fd53673302dd8674d5e9ee9aff Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Mon, 5 Feb 2024 15:45:22 -0500 Subject: [PATCH 8/8] Fix a conditional --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 375e17a..d7b3ee8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -68,10 +68,10 @@ jobs: - uses: julia-actions/julia-processcoverage@v1 - name: (debug) find all lcov.info files run: find . -type f -name 'lcov.info' - if: runner.os == 'Windows' + if: runner.os != 'Windows' # - name: (debug) cat all lcov.info files # run: find . -type f -name 'lcov.info' -exec cat {} \; - # if: runner.os == 'Windows' + # if: runner.os != 'Windows' - uses: codecov/codecov-action@v4 with: file: lcov.info