From 957e2214e4d38b8b182e342dcea35c186935fb64 Mon Sep 17 00:00:00 2001 From: Mante Balzaraviciute Date: Tue, 28 Feb 2023 20:44:12 +0000 Subject: [PATCH 1/2] ADD: stricter sniffs --- ecs.php | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/ecs.php b/ecs.php index ef0ad2a..703c242 100644 --- a/ecs.php +++ b/ecs.php @@ -16,11 +16,13 @@ use PhpCsFixer\Fixer\Whitespace\ArrayIndentationFixer; use SlevomatCodingStandard\Sniffs\Arrays\TrailingArrayCommaSniff; use SlevomatCodingStandard\Sniffs\Classes\ClassConstantVisibilitySniff; +use SlevomatCodingStandard\Sniffs\Classes\TraitUseDeclarationSniff; use SlevomatCodingStandard\Sniffs\Commenting\EmptyCommentSniff; use SlevomatCodingStandard\Sniffs\Commenting\UselessFunctionDocCommentSniff; use SlevomatCodingStandard\Sniffs\ControlStructures\EarlyExitSniff; use SlevomatCodingStandard\Sniffs\ControlStructures\NewWithParenthesesSniff; use SlevomatCodingStandard\Sniffs\ControlStructures\RequireNullCoalesceOperatorSniff; +use SlevomatCodingStandard\Sniffs\ControlStructures\UselessTernaryOperatorSniff; use SlevomatCodingStandard\Sniffs\Exceptions\DeadCatchSniff; use SlevomatCodingStandard\Sniffs\Functions\UnusedInheritedVariablePassedToClosureSniff; use SlevomatCodingStandard\Sniffs\Functions\UnusedParameterSniff; @@ -29,13 +31,18 @@ use SlevomatCodingStandard\Sniffs\Namespaces\MultipleUsesPerLineSniff; use SlevomatCodingStandard\Sniffs\Namespaces\UnusedUsesSniff; use SlevomatCodingStandard\Sniffs\Namespaces\UseFromSameNamespaceSniff; +use SlevomatCodingStandard\Sniffs\Operators\DisallowEqualOperatorsSniff; use SlevomatCodingStandard\Sniffs\PHP\ShortListSniff; use SlevomatCodingStandard\Sniffs\PHP\TypeCastSniff; use SlevomatCodingStandard\Sniffs\PHP\UselessParenthesesSniff; use SlevomatCodingStandard\Sniffs\PHP\UselessSemicolonSniff; +use SlevomatCodingStandard\Sniffs\TypeHints\DeclareStrictTypesSniff; +use SlevomatCodingStandard\Sniffs\TypeHints\DisallowMixedTypeHintSniff; use SlevomatCodingStandard\Sniffs\TypeHints\LongTypeHintsSniff; use SlevomatCodingStandard\Sniffs\TypeHints\NullableTypeForNullDefaultValueSniff; +use SlevomatCodingStandard\Sniffs\TypeHints\ParameterTypeHintSniff; use SlevomatCodingStandard\Sniffs\TypeHints\ParameterTypeHintSpacingSniff; +use SlevomatCodingStandard\Sniffs\TypeHints\ReturnTypeHintSniff; use SlevomatCodingStandard\Sniffs\TypeHints\ReturnTypeHintSpacingSniff; use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator; use Symplify\CodingStandard\Fixer\ArrayNotation\ArrayOpenerAndCloserNewlineFixer; @@ -57,6 +64,12 @@ CamelCapsFunctionNameSniff::class => [ '/tests/**', ], + 'SlevomatCodingStandard\Sniffs\TypeHints\ReturnTypeHintSniff.MissingTraversableTypeHintSpecification' => [ + '*' + ], + 'SlevomatCodingStandard\Sniffs\TypeHints\ParameterTypeHintSniff.MissingTraversableTypeHintSpecification' => [ + '*' + ], ]); $services = $containerConfigurator->services(); @@ -109,4 +122,11 @@ $services->set(SelfAccessorFixer::class); $services->set(ArrayIndentationFixer::class); $services->set(ArrayOpenerAndCloserNewlineFixer::class); + $services->set(DisallowEqualOperatorsSniff::class); + $services->set(TraitUseDeclarationSniff::class); + $services->set(DeclareStrictTypesSniff::class); + $services->set(ReturnTypeHintSniff::class); + $services->set(UselessTernaryOperatorSniff::class); + $services->set(DisallowMixedTypeHintSniff::class); + $services->set(ParameterTypeHintSniff::class); }; From 12d87e860a1acf6898466383b719adf1d546a75d Mon Sep 17 00:00:00 2001 From: Mante Balzaraviciute Date: Tue, 28 Feb 2023 21:18:20 +0000 Subject: [PATCH 2/2] ADD: SingleLineArrayWhitespaceSniff --- ecs.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ecs.php b/ecs.php index 703c242..0a07303 100644 --- a/ecs.php +++ b/ecs.php @@ -14,6 +14,7 @@ use PhpCsFixer\Fixer\ClassNotation\NoBlankLinesAfterClassOpeningFixer; use PhpCsFixer\Fixer\ClassNotation\SelfAccessorFixer; use PhpCsFixer\Fixer\Whitespace\ArrayIndentationFixer; +use SlevomatCodingStandard\Sniffs\Arrays\SingleLineArrayWhitespaceSniff; use SlevomatCodingStandard\Sniffs\Arrays\TrailingArrayCommaSniff; use SlevomatCodingStandard\Sniffs\Classes\ClassConstantVisibilitySniff; use SlevomatCodingStandard\Sniffs\Classes\TraitUseDeclarationSniff; @@ -129,4 +130,5 @@ $services->set(UselessTernaryOperatorSniff::class); $services->set(DisallowMixedTypeHintSniff::class); $services->set(ParameterTypeHintSniff::class); + $services->set(SingleLineArrayWhitespaceSniff::class); };