From ece9b4e04e4815b90540f1f54381486bd86a3732 Mon Sep 17 00:00:00 2001 From: LeonfLK Date: Wed, 30 Sep 2020 14:58:05 +0200 Subject: [PATCH 1/3] test: updated makeTransfer --- src/faucet/faucet.controller.ts | 3 ++- src/faucet/faucet.module.spec.ts | 15 ++++++++++----- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/src/faucet/faucet.controller.ts b/src/faucet/faucet.controller.ts index f0d7c82..6ff676e 100644 --- a/src/faucet/faucet.controller.ts +++ b/src/faucet/faucet.controller.ts @@ -73,7 +73,8 @@ export class FaucetController { const status: SubmittableResult = await Balance.makeTransfer( faucetAccount, address, - new BN(KILT_FEMTO_COIN).muln(DEFAULT_TOKEN_AMOUNT) + new BN(DEFAULT_TOKEN_AMOUNT), + 0 ) return Promise.resolve(status.isFinalized) } catch (e) { diff --git a/src/faucet/faucet.module.spec.ts b/src/faucet/faucet.module.spec.ts index e48e755..68bc68b 100644 --- a/src/faucet/faucet.module.spec.ts +++ b/src/faucet/faucet.module.spec.ts @@ -110,7 +110,8 @@ describe('Faucet Module', () => { expect(mockedMakeTransfer).toHaveBeenCalledWith( faucetIdentity, claimerAddress, - new BN(KILT_FEMTO_COIN).muln(DEFAULT_TOKEN_AMOUNT) + new BN(DEFAULT_TOKEN_AMOUNT), + 0 ) }) it('updates the database on unsuccessful transfer and throws exception', async () => { @@ -136,7 +137,8 @@ describe('Faucet Module', () => { expect(mockedMakeTransfer).toHaveBeenCalledWith( faucetIdentity, claimerAddress, - new BN(KILT_FEMTO_COIN).muln(DEFAULT_TOKEN_AMOUNT) + new BN(DEFAULT_TOKEN_AMOUNT), + 0 ) expect(updateSpy).toHaveBeenCalledWith(testFaucetDrop) }) @@ -196,7 +198,8 @@ describe('Faucet Module', () => { expect(mockedMakeTransfer).toHaveBeenCalledWith( faucetIdentity, claimerAddress, - new BN(KILT_FEMTO_COIN).muln(DEFAULT_TOKEN_AMOUNT) + new BN(DEFAULT_TOKEN_AMOUNT), + 0 ) }) it(`returns false on thrown error or if the transfer failed`, async () => { @@ -226,7 +229,8 @@ describe('Faucet Module', () => { expect(mockedMakeTransfer).toHaveBeenCalledWith( faucetIdentity, claimerAddress, - new BN(KILT_FEMTO_COIN).muln(DEFAULT_TOKEN_AMOUNT) + new BN(DEFAULT_TOKEN_AMOUNT), + 0 ) mockedMakeTransfer.mockImplementation(async () => { return { @@ -242,7 +246,8 @@ describe('Faucet Module', () => { expect(mockedMakeTransfer).toHaveBeenCalledWith( faucetIdentity, claimerAddress, - new BN(KILT_FEMTO_COIN).muln(DEFAULT_TOKEN_AMOUNT) + new BN(DEFAULT_TOKEN_AMOUNT), + 0 ) }) }) From 604bb5bf4ff9acfd68295bbe33b28dd181f739eb Mon Sep 17 00:00:00 2001 From: LeonfLK Date: Wed, 30 Sep 2020 15:00:46 +0200 Subject: [PATCH 2/3] test: e2e faucet makeTransfer right arguments --- test/faucet.e2e-spec.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/faucet.e2e-spec.ts b/test/faucet.e2e-spec.ts index f777aa3..78fac58 100644 --- a/test/faucet.e2e-spec.ts +++ b/test/faucet.e2e-spec.ts @@ -69,7 +69,8 @@ describe('faucet endpoint (e2e)', () => { expect(spy).toHaveBeenCalledWith( expect.objectContaining({ seedAsHex: FAUCET_SEED }), idAlice.address, - expect.any(BN) + expect.any(BN), + 0 ) }) From 264530f772b84feded1a0a5a4c391880c368ffb9 Mon Sep 17 00:00:00 2001 From: LeonfLK Date: Wed, 30 Sep 2020 16:06:43 +0200 Subject: [PATCH 3/3] chore: removed unused var --- src/faucet/faucet.controller.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/faucet/faucet.controller.ts b/src/faucet/faucet.controller.ts index 6ff676e..1ee54a8 100644 --- a/src/faucet/faucet.controller.ts +++ b/src/faucet/faucet.controller.ts @@ -22,7 +22,6 @@ import { } from './exceptions' import { AuthGuard } from '../auth/auth.guard' -const KILT_FEMTO_COIN = '1000000000000000' const DEFAULT_TOKEN_AMOUNT = 500 @Controller('faucet')