From a4171742c5ba30b779d7f05acfbe9f7061a0e1cd Mon Sep 17 00:00:00 2001
From: Ada <AdaInTheLab@gmail.com>
Date: Thu, 30 Apr 2026 12:48:05 -0400
Subject: [PATCH] Vote Rewards: dedupe provider list on load, idx-aware Vue key
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PR #50 prevented new duplicates forming (the Newtonsoft-append bug),
but admins whose state was poisoned while that bug was active still
carry the doubled list in their persisted JSON. Symptoms after loading:

- /vote prints "<key>: provider disabled" + "<displayname>: granted ..."
  side by side because the foreach iterates both entries
- Settings tab shows two provider blocks; Vue's v-for warns about
  duplicate :key values and the diffing reconciles unpredictably

Two-part fix:

1. EnsureDefaultProviders now deduplicates by Key on every load. The
   entry with the strongest "configured" signal wins (enabled+apiKey >
   enabled > apiKey > anything else), so a real config never gets
   displaced by an empty stub. Logs a one-line note when it dropped
   any rows so admins can see it ran.

2. SettingsView.vue's v-for key is now `${provider.key}-${idx}` so
   duplicate provider keys can't collide in Vue's diffing. Defense in
   depth — the backend dedup means duplicates shouldn't reach the UI
   anymore, but the v-for shouldn't be the thing that breaks if they do.

Self-heals existing poisoned state on the next server boot.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 frontend/src/views/SettingsView.vue           |  5 +++-
 .../Features/VoteRewardsFeature.cs            | 24 +++++++++++++++++++
 2 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/frontend/src/views/SettingsView.vue b/frontend/src/views/SettingsView.vue
index 2c991b3..47a38dd 100644
--- a/frontend/src/views/SettingsView.vue
+++ b/frontend/src/views/SettingsView.vue
@@ -1342,7 +1342,10 @@ onMounted(() => {
             <Card class="settings-card" v-if="voteRewardsSettings.providers && voteRewardsSettings.providers.length > 0">
               <template #title>{{ t('settings.voteRewardsProviderHeader') }}</template>
               <template #content>
-                <div v-for="(provider, idx) in voteRewardsSettings.providers" :key="provider.key" class="provider-block vote-provider">
+                <!-- :key includes idx so duplicate provider keys (legacy state) don't collide
+                     in Vue's v-for diffing. Backend dedups on load now (see EnsureDefaultProviders),
+                     but this is defense in depth for any future regression. -->
+                <div v-for="(provider, idx) in voteRewardsSettings.providers" :key="`${provider.key}-${idx}`" class="provider-block vote-provider">
                   <h3 class="provider-title">{{ voteProviderDisplayName(provider.key) }}</h3>
 
                   <div class="vote-provider-grid">
diff --git a/src/KitsuneCommand/Features/VoteRewardsFeature.cs b/src/KitsuneCommand/Features/VoteRewardsFeature.cs
index aa0e4c2..c57c5c7 100644
--- a/src/KitsuneCommand/Features/VoteRewardsFeature.cs
+++ b/src/KitsuneCommand/Features/VoteRewardsFeature.cs
@@ -541,6 +541,30 @@ private void LoadPersistedSettings()
         private static void EnsureDefaultProviders(VoteRewardsSettings settings)
         {
             if (settings.Providers == null) settings.Providers = new List<VoteProviderSettings>();
+
+            // Deduplicate by Key. PR #50 prevented NEW duplicates forming (the
+            // Newtonsoft-append bug), but admins whose state was poisoned while
+            // that bug was active still carry the doubled list in their saved
+            // JSON. Strip duplicates here on every load — the entry with the
+            // most "configured" signal wins (enabled + has-api-key > enabled-only
+            // > has-api-key > anything else) so a real config is never displaced
+            // by an empty stub.
+            var beforeCount = settings.Providers.Count;
+            settings.Providers = settings.Providers
+                .Where(p => p != null && !string.IsNullOrWhiteSpace(p.Key))
+                .GroupBy(p => p.Key, StringComparer.OrdinalIgnoreCase)
+                .Select(group => group
+                    .OrderByDescending(p => p.Enabled && !string.IsNullOrEmpty(p.ApiKey))
+                    .ThenByDescending(p => p.Enabled)
+                    .ThenByDescending(p => !string.IsNullOrEmpty(p.ApiKey))
+                    .First())
+                .ToList();
+            var afterCount = settings.Providers.Count;
+            if (afterCount < beforeCount)
+            {
+                Log.Out($"[KitsuneCommand] VoteRewards: deduped {beforeCount - afterCount} duplicate provider entry/entries on load.");
+            }
+
             if (!settings.Providers.Any(p => string.Equals(p.Key, "7daystodie-servers", StringComparison.OrdinalIgnoreCase)))
             {
                 settings.Providers.Add(new VoteProviderSettings { Key = "7daystodie-servers", Enabled = false });