From ec5778ba95858c1c8e348e6bc4ef76dcd62fe63a Mon Sep 17 00:00:00 2001 From: Filipe Freire Date: Thu, 12 Oct 2023 16:08:05 +0100 Subject: [PATCH 1/2] update nvmrc and uncomment http2 test --- .nvmrc | 2 +- test/curl/http2.spec.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.nvmrc b/.nvmrc index 8d2a45160..7ec56198d 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -18.16.1 \ No newline at end of file +18.17.1 \ No newline at end of file diff --git a/test/curl/http2.spec.ts b/test/curl/http2.spec.ts index 307cca88d..43c80cc41 100644 --- a/test/curl/http2.spec.ts +++ b/test/curl/http2.spec.ts @@ -60,7 +60,7 @@ describe('HTTP2', () => { }) // skipped until https://github.com/nodejs/node/issues/42713 is fixed - it.skip('should work with https2 site', (done) => { + it('should work with https2 site', (done) => { const curl = new Curl() curl.setOpt('URL', `https://${host}:${portHttp2}/`) From 67b085c082f61ddf29a01f35b56b4d93a25905c4 Mon Sep 17 00:00:00 2001 From: Filipe Freire Date: Thu, 12 Oct 2023 16:13:59 +0100 Subject: [PATCH 2/2] Update http2.spec.ts --- test/curl/http2.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/curl/http2.spec.ts b/test/curl/http2.spec.ts index 43c80cc41..307cca88d 100644 --- a/test/curl/http2.spec.ts +++ b/test/curl/http2.spec.ts @@ -60,7 +60,7 @@ describe('HTTP2', () => { }) // skipped until https://github.com/nodejs/node/issues/42713 is fixed - it('should work with https2 site', (done) => { + it.skip('should work with https2 site', (done) => { const curl = new Curl() curl.setOpt('URL', `https://${host}:${portHttp2}/`)