fix: Duplicate predictions#187
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where predictions were being duplicated by changing the iteration logic to only use the first set of support point predictions instead of iterating over all predictions.
- Replaces nested iteration over all predictions with iteration over only the first support point predictions
- Adds explanatory comments to clarify the new logic
- Prevents duplicate prediction entries in the output
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
| Branch | fix-predictions |
| Testbed | pmcore-runner |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result seconds (s) (Result Δ%) | Upper Boundary seconds (s) (Limit %) |
|---|---|---|---|
| bimodal_ke_npag | 📈 view plot 🚷 view threshold | 34.29 s(+49.81%)Baseline: 22.89 s | 49.46 s (69.32%) |
| bimodal_ke_npod | 📈 view plot 🚷 view threshold | 44.24 s(+85.33%)Baseline: 23.87 s | 70.54 s (62.72%) |
| bimodal_ke_postprob | 📈 view plot 🚷 view threshold | 15.40 s(+85.14%)Baseline: 8.32 s | 24.49 s (62.86%) |
Siel
approved these changes
Sep 29, 2025
Merged
Contributor
|
| Branch | fix-predictions |
| Testbed | rust-loki |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result seconds (s) (Result Δ%) | Upper Boundary seconds (s) (Limit %) |
|---|---|---|---|
| bimodal_ke_npag | 📈 view plot 🚷 view threshold | 34.75 s(+1.33%)Baseline: 34.29 s | 48.85 s (71.14%) |
| bimodal_ke_npod | 📈 view plot 🚷 view threshold | 44.17 s(+0.17%)Baseline: 44.09 s | 46.43 s (95.12%) |
| bimodal_ke_postprob | 📈 view plot 🚷 view threshold | 15.41 s(+0.36%)Baseline: 15.35 s | 17.09 s (90.17%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where predictions were duplicated multiple times
This is something that should be covered by a test, some day...